Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disable grouping by dtype and device if compiling #102771

Closed
wants to merge 4 commits into from
Closed

Disable grouping by dtype and device if compiling #102771

wants to merge 4 commits into from

Conversation

mlazos
Copy link
Contributor

@mlazos mlazos commented Jun 1, 2023 •
edited

Disable grouping if we are compiling, this happens during lowering

@pytorch-bot
Copy link

pytorch-bot bot commented Jun 1, 2023 •
edited

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/102771

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 46ae2d4:
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@pytorch-bot pytorch-bot bot added the release notes: foreach_frontend release notes category label Jun 1, 2023
@mlazos mlazos requested a review from janeyx99 June 1, 2023 20:26
mlazos
mlazos commented Jun 1, 2023
View reviewed changes
torch/utils/_foreach_utils.py Outdated Show resolved Hide resolved
@mlazos mlazos requested a review from albanD as a code owner June 1, 2023 21:37
janeyx99
janeyx99 approved these changes Jun 2, 2023
View reviewed changes
Copy link
Contributor

@janeyx99 janeyx99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks okay overall, thanks for abstracting it out. could you add a comment so code readers could understand why we have the deviation?

torch/optim/optimizer.py Show resolved Hide resolved
@mlazos
Copy link
Contributor Author

mlazos commented Jun 2, 2023

@pytorchbot merge

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Jun 2, 2023
@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

alimoezzi pushed a commit to alimoezzi/pytorch that referenced this pull request Jun 3, 2023
@mlazos @alimoezzi
Disable grouping by dtype and device if compiling (pytorch#102771)
e626afe 
Disable grouping if we are compiling, this happens during lowering
Pull Request resolved: pytorch#102771
Approved by: https://github.com/janeyx99
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@janeyx99 janeyx99 janeyx99 approved these changes

@albanD albanD Awaiting requested review from albanD albanD is a code owner

Assignees
No one assigned
Labels
ciflow/trunk Trigger trunk jobs on your pull request Merged release notes: foreach_frontend release notes category
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@mlazos @pytorchmergebot @janeyx99