New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove incorrect THP{Cpp,}Function_traverse PyObject traversals #102860
Conversation
[ghstack-poisoned]
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/102860
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 84a5842: This comment was automatically generated by Dr. CI and updates every 15 minutes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Did you confirm that the test does fail without the change?
@@ -77,6 +77,14 @@ PyObject* THPCppFunction_call( | |||
|
|||
int THPCppFunction_traverse(PyObject* self, visitproc visit, void* arg) { | |||
auto& fn = *((THPCppFunction*)self)->cdata; | |||
if ((((THPCppFunction*)self)->cdata).use_count() > 1) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This definitely makes the diff easier to read but I think it's better to guard the calls below rather than early returning.
…rsals" Fixes #102174 [ghstack-poisoned]
@pytorchbot merge |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
…rch#102860) Fixes pytorch#102174 Pull Request resolved: pytorch#102860 Approved by: https://github.com/albanD
Stack from ghstack (oldest at bottom):
Fixes #102174