Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix soundness bug with unsupported constraints #102897

Closed

Commits on Jun 3, 2023

  1. fix soundness bug with unsupported constraints

    Differential Revision: [D46415786](https://our.internmc.facebook.com/intern/diff/D46415786/)
    
    [ghstack-poisoned]
    avikchaudhuri committed Jun 3, 2023
    Configuration menu
    Copy the full SHA
    fe20907 View commit details
    Browse the repository at this point in the history
  2. Update on "fix soundness bug with unsupported constraints"

    Differential Revision: [D46415786](https://our.internmc.facebook.com/intern/diff/D46415786/)
    
    cc voznesenskym penguinwu anijain2305 EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng Xia-Weiwen wenzhe-nrv jiayisunx ipiszy
    
    [ghstack-poisoned]
    avikchaudhuri committed Jun 3, 2023
    Configuration menu
    Copy the full SHA
    ebb86f5 View commit details
    Browse the repository at this point in the history
  3. Update on "fix soundness bug with unsupported constraints"

    Differential Revision: [D46415786](https://our.internmc.facebook.com/intern/diff/D46415786/)
    
    cc voznesenskym penguinwu anijain2305 EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng Xia-Weiwen wenzhe-nrv jiayisunx ipiszy
    
    [ghstack-poisoned]
    avikchaudhuri committed Jun 3, 2023
    Configuration menu
    Copy the full SHA
    19a998c View commit details
    Browse the repository at this point in the history
  4. Update on "fix soundness bug with unsupported constraints"

    Differential Revision: [D46415786](https://our.internmc.facebook.com/intern/diff/D46415786/)
    
    cc voznesenskym penguinwu anijain2305 EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng Xia-Weiwen wenzhe-nrv jiayisunx ipiszy
    
    [ghstack-poisoned]
    avikchaudhuri committed Jun 3, 2023
    Configuration menu
    Copy the full SHA
    10dde76 View commit details
    Browse the repository at this point in the history
  5. Update on "fix soundness bug with unsupported constraints"

    Differential Revision: [D46415786](https://our.internmc.facebook.com/intern/diff/D46415786/)
    
    cc voznesenskym penguinwu anijain2305 EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng Xia-Weiwen wenzhe-nrv jiayisunx ipiszy
    
    [ghstack-poisoned]
    avikchaudhuri committed Jun 3, 2023
    Configuration menu
    Copy the full SHA
    11ddeb3 View commit details
    Browse the repository at this point in the history

Commits on Jun 5, 2023

  1. Update on "fix soundness bug with unsupported constraints"

    Differential Revision: [D46415786](https://our.internmc.facebook.com/intern/diff/D46415786/)
    
    cc voznesenskym penguinwu anijain2305 EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng Xia-Weiwen wenzhe-nrv jiayisunx ipiszy
    
    [ghstack-poisoned]
    avikchaudhuri committed Jun 5, 2023
    Configuration menu
    Copy the full SHA
    3b528f1 View commit details
    Browse the repository at this point in the history
  2. Update on "fix soundness bug with unsupported constraints"

    We do not raise constraint violations for complex binary conditions, such as conditions involving `%`. Moreover, while these constraints are discovered by our solver, the solver does not inject new constraint violations. This can result in cases where export passes, appropriate assertions are not added, and we get runtime crashes. 
    
    Now, when the solver discovers constraints that are too complex, we force-specialize the involved dimensions and raise a constraint violation when such dimensions are marked dynamic. This forces the user to remove the dynamic marking, and causes the appropriate specialization assertions to be added.
    
    Differential Revision: [D46415786](https://our.internmc.facebook.com/intern/diff/D46415786/)
    
    cc voznesenskym penguinwu anijain2305 EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng Xia-Weiwen wenzhe-nrv jiayisunx ipiszy
    
    [ghstack-poisoned]
    avikchaudhuri committed Jun 5, 2023
    Configuration menu
    Copy the full SHA
    d422007 View commit details
    Browse the repository at this point in the history

Commits on Jun 7, 2023

  1. Update on "fix soundness bug with unsupported constraints"

    We do not raise constraint violations for complex binary conditions, such as conditions involving `%`. Moreover, while these constraints are discovered by our solver, the solver does not inject new constraint violations. This can result in cases where export passes, appropriate assertions are not added, and we get runtime crashes. 
    
    Now, when the solver discovers constraints that are too complex, we force-specialize the involved dimensions and raise a constraint violation when such dimensions are marked dynamic. This forces the user to remove the dynamic marking, and causes the appropriate specialization assertions to be added.
    
    Differential Revision: [D46415786](https://our.internmc.facebook.com/intern/diff/D46415786/)
    
    cc voznesenskym penguinwu anijain2305 EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng Xia-Weiwen wenzhe-nrv jiayisunx ipiszy
    
    [ghstack-poisoned]
    avikchaudhuri committed Jun 7, 2023
    Configuration menu
    Copy the full SHA
    1bbf112 View commit details
    Browse the repository at this point in the history
  2. Update on "fix soundness bug with unsupported constraints"

    We do not raise constraint violations for complex binary conditions, such as conditions involving `%`. Moreover, while these constraints are discovered by our solver, the solver does not inject new constraint violations. This can result in cases where export passes, appropriate assertions are not added, and we get runtime crashes. 
    
    Now, when the solver discovers constraints that are too complex, we force-specialize the involved dimensions and raise a constraint violation when such dimensions are marked dynamic. This forces the user to remove the dynamic marking, and causes the appropriate specialization assertions to be added.
    
    Differential Revision: [D46415786](https://our.internmc.facebook.com/intern/diff/D46415786/)
    
    cc voznesenskym penguinwu anijain2305 EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng Xia-Weiwen wenzhe-nrv jiayisunx ipiszy
    
    [ghstack-poisoned]
    avikchaudhuri committed Jun 7, 2023
    Configuration menu
    Copy the full SHA
    0ff2384 View commit details
    Browse the repository at this point in the history

Commits on Jun 8, 2023

  1. Update on "fix soundness bug with unsupported constraints"

    We do not raise constraint violations for complex binary conditions, such as conditions involving `%`. Moreover, while these constraints are discovered by our solver, the solver does not inject new constraint violations. This can result in cases where export passes, appropriate assertions are not added, and we get runtime crashes. 
    
    Now, when the solver discovers constraints that are too complex, we force-specialize the involved dimensions and raise a constraint violation when such dimensions are marked dynamic. This forces the user to remove the dynamic marking, and causes the appropriate specialization assertions to be added.
    
    Differential Revision: [D46415786](https://our.internmc.facebook.com/intern/diff/D46415786/)
    
    cc voznesenskym penguinwu anijain2305 EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng Xia-Weiwen wenzhe-nrv jiayisunx ipiszy
    
    [ghstack-poisoned]
    avikchaudhuri committed Jun 8, 2023
    Configuration menu
    Copy the full SHA
    3376754 View commit details
    Browse the repository at this point in the history

Commits on Jun 9, 2023

  1. Update on "fix soundness bug with unsupported constraints"

    We do not raise constraint violations for complex binary conditions, such as conditions involving `%`. Moreover, while these constraints are discovered by our solver, the solver does not inject new constraint violations. This can result in cases where export passes, appropriate assertions are not added, and we get runtime crashes. 
    
    Now, when the solver discovers constraints that are too complex, we force-specialize the involved dimensions and raise a constraint violation when such dimensions are marked dynamic. This forces the user to remove the dynamic marking, and causes the appropriate specialization assertions to be added.
    
    Differential Revision: [D46415786](https://our.internmc.facebook.com/intern/diff/D46415786/)
    
    cc voznesenskym penguinwu anijain2305 EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng Xia-Weiwen wenzhe-nrv jiayisunx ipiszy
    
    [ghstack-poisoned]
    avikchaudhuri committed Jun 9, 2023
    Configuration menu
    Copy the full SHA
    947ca5a View commit details
    Browse the repository at this point in the history
  2. Update on "fix soundness bug with unsupported constraints"

    We do not raise constraint violations for complex binary conditions, such as conditions involving `%`. Moreover, while these constraints are discovered by our solver, the solver does not inject new constraint violations. This can result in cases where export passes, appropriate assertions are not added, and we get runtime crashes. 
    
    Now, when the solver discovers constraints that are too complex, we force-specialize the involved dimensions and raise a constraint violation when such dimensions are marked dynamic. This forces the user to remove the dynamic marking, and causes the appropriate specialization assertions to be added.
    
    Differential Revision: [D46415786](https://our.internmc.facebook.com/intern/diff/D46415786/)
    
    cc voznesenskym penguinwu anijain2305 EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng Xia-Weiwen wenzhe-nrv jiayisunx ipiszy aakhundov
    
    [ghstack-poisoned]
    avikchaudhuri committed Jun 9, 2023
    Configuration menu
    Copy the full SHA
    cc80e79 View commit details
    Browse the repository at this point in the history
  3. Update on "fix soundness bug with unsupported constraints"

    We do not raise constraint violations for complex binary conditions, such as conditions involving `%`. Moreover, while these constraints are discovered by our solver, the solver does not inject new constraint violations. This can result in cases where export passes, appropriate assertions are not added, and we get runtime crashes. 
    
    Now, when the solver discovers constraints that are too complex, we force-specialize the involved dimensions and raise a constraint violation when such dimensions are marked dynamic. This forces the user to remove the dynamic marking, and causes the appropriate specialization assertions to be added.
    
    Differential Revision: [D46415786](https://our.internmc.facebook.com/intern/diff/D46415786/)
    
    cc voznesenskym penguinwu anijain2305 EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng Xia-Weiwen wenzhe-nrv jiayisunx ipiszy aakhundov
    
    [ghstack-poisoned]
    avikchaudhuri committed Jun 9, 2023
    Configuration menu
    Copy the full SHA
    d8a72c8 View commit details
    Browse the repository at this point in the history