-
Notifications
You must be signed in to change notification settings - Fork 21.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix soundness bug with unsupported constraints #102897
Commits on Jun 3, 2023
-
fix soundness bug with unsupported constraints
Differential Revision: [D46415786](https://our.internmc.facebook.com/intern/diff/D46415786/) [ghstack-poisoned]
Configuration menu - View commit details
-
Copy full SHA for fe20907 - Browse repository at this point
Copy the full SHA fe20907View commit details -
Update on "fix soundness bug with unsupported constraints"
Differential Revision: [D46415786](https://our.internmc.facebook.com/intern/diff/D46415786/) cc voznesenskym penguinwu anijain2305 EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng Xia-Weiwen wenzhe-nrv jiayisunx ipiszy [ghstack-poisoned]
Configuration menu - View commit details
-
Copy full SHA for ebb86f5 - Browse repository at this point
Copy the full SHA ebb86f5View commit details -
Update on "fix soundness bug with unsupported constraints"
Differential Revision: [D46415786](https://our.internmc.facebook.com/intern/diff/D46415786/) cc voznesenskym penguinwu anijain2305 EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng Xia-Weiwen wenzhe-nrv jiayisunx ipiszy [ghstack-poisoned]
Configuration menu - View commit details
-
Copy full SHA for 19a998c - Browse repository at this point
Copy the full SHA 19a998cView commit details -
Update on "fix soundness bug with unsupported constraints"
Differential Revision: [D46415786](https://our.internmc.facebook.com/intern/diff/D46415786/) cc voznesenskym penguinwu anijain2305 EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng Xia-Weiwen wenzhe-nrv jiayisunx ipiszy [ghstack-poisoned]
Configuration menu - View commit details
-
Copy full SHA for 10dde76 - Browse repository at this point
Copy the full SHA 10dde76View commit details -
Update on "fix soundness bug with unsupported constraints"
Differential Revision: [D46415786](https://our.internmc.facebook.com/intern/diff/D46415786/) cc voznesenskym penguinwu anijain2305 EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng Xia-Weiwen wenzhe-nrv jiayisunx ipiszy [ghstack-poisoned]
Configuration menu - View commit details
-
Copy full SHA for 11ddeb3 - Browse repository at this point
Copy the full SHA 11ddeb3View commit details
Commits on Jun 5, 2023
-
Update on "fix soundness bug with unsupported constraints"
Differential Revision: [D46415786](https://our.internmc.facebook.com/intern/diff/D46415786/) cc voznesenskym penguinwu anijain2305 EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng Xia-Weiwen wenzhe-nrv jiayisunx ipiszy [ghstack-poisoned]
Configuration menu - View commit details
-
Copy full SHA for 3b528f1 - Browse repository at this point
Copy the full SHA 3b528f1View commit details -
Update on "fix soundness bug with unsupported constraints"
We do not raise constraint violations for complex binary conditions, such as conditions involving `%`. Moreover, while these constraints are discovered by our solver, the solver does not inject new constraint violations. This can result in cases where export passes, appropriate assertions are not added, and we get runtime crashes. Now, when the solver discovers constraints that are too complex, we force-specialize the involved dimensions and raise a constraint violation when such dimensions are marked dynamic. This forces the user to remove the dynamic marking, and causes the appropriate specialization assertions to be added. Differential Revision: [D46415786](https://our.internmc.facebook.com/intern/diff/D46415786/) cc voznesenskym penguinwu anijain2305 EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng Xia-Weiwen wenzhe-nrv jiayisunx ipiszy [ghstack-poisoned]
Configuration menu - View commit details
-
Copy full SHA for d422007 - Browse repository at this point
Copy the full SHA d422007View commit details
Commits on Jun 7, 2023
-
Update on "fix soundness bug with unsupported constraints"
We do not raise constraint violations for complex binary conditions, such as conditions involving `%`. Moreover, while these constraints are discovered by our solver, the solver does not inject new constraint violations. This can result in cases where export passes, appropriate assertions are not added, and we get runtime crashes. Now, when the solver discovers constraints that are too complex, we force-specialize the involved dimensions and raise a constraint violation when such dimensions are marked dynamic. This forces the user to remove the dynamic marking, and causes the appropriate specialization assertions to be added. Differential Revision: [D46415786](https://our.internmc.facebook.com/intern/diff/D46415786/) cc voznesenskym penguinwu anijain2305 EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng Xia-Weiwen wenzhe-nrv jiayisunx ipiszy [ghstack-poisoned]
Configuration menu - View commit details
-
Copy full SHA for 1bbf112 - Browse repository at this point
Copy the full SHA 1bbf112View commit details -
Update on "fix soundness bug with unsupported constraints"
We do not raise constraint violations for complex binary conditions, such as conditions involving `%`. Moreover, while these constraints are discovered by our solver, the solver does not inject new constraint violations. This can result in cases where export passes, appropriate assertions are not added, and we get runtime crashes. Now, when the solver discovers constraints that are too complex, we force-specialize the involved dimensions and raise a constraint violation when such dimensions are marked dynamic. This forces the user to remove the dynamic marking, and causes the appropriate specialization assertions to be added. Differential Revision: [D46415786](https://our.internmc.facebook.com/intern/diff/D46415786/) cc voznesenskym penguinwu anijain2305 EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng Xia-Weiwen wenzhe-nrv jiayisunx ipiszy [ghstack-poisoned]
Configuration menu - View commit details
-
Copy full SHA for 0ff2384 - Browse repository at this point
Copy the full SHA 0ff2384View commit details
Commits on Jun 8, 2023
-
Update on "fix soundness bug with unsupported constraints"
We do not raise constraint violations for complex binary conditions, such as conditions involving `%`. Moreover, while these constraints are discovered by our solver, the solver does not inject new constraint violations. This can result in cases where export passes, appropriate assertions are not added, and we get runtime crashes. Now, when the solver discovers constraints that are too complex, we force-specialize the involved dimensions and raise a constraint violation when such dimensions are marked dynamic. This forces the user to remove the dynamic marking, and causes the appropriate specialization assertions to be added. Differential Revision: [D46415786](https://our.internmc.facebook.com/intern/diff/D46415786/) cc voznesenskym penguinwu anijain2305 EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng Xia-Weiwen wenzhe-nrv jiayisunx ipiszy [ghstack-poisoned]
Configuration menu - View commit details
-
Copy full SHA for 3376754 - Browse repository at this point
Copy the full SHA 3376754View commit details
Commits on Jun 9, 2023
-
Update on "fix soundness bug with unsupported constraints"
We do not raise constraint violations for complex binary conditions, such as conditions involving `%`. Moreover, while these constraints are discovered by our solver, the solver does not inject new constraint violations. This can result in cases where export passes, appropriate assertions are not added, and we get runtime crashes. Now, when the solver discovers constraints that are too complex, we force-specialize the involved dimensions and raise a constraint violation when such dimensions are marked dynamic. This forces the user to remove the dynamic marking, and causes the appropriate specialization assertions to be added. Differential Revision: [D46415786](https://our.internmc.facebook.com/intern/diff/D46415786/) cc voznesenskym penguinwu anijain2305 EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng Xia-Weiwen wenzhe-nrv jiayisunx ipiszy [ghstack-poisoned]
Configuration menu - View commit details
-
Copy full SHA for 947ca5a - Browse repository at this point
Copy the full SHA 947ca5aView commit details -
Update on "fix soundness bug with unsupported constraints"
We do not raise constraint violations for complex binary conditions, such as conditions involving `%`. Moreover, while these constraints are discovered by our solver, the solver does not inject new constraint violations. This can result in cases where export passes, appropriate assertions are not added, and we get runtime crashes. Now, when the solver discovers constraints that are too complex, we force-specialize the involved dimensions and raise a constraint violation when such dimensions are marked dynamic. This forces the user to remove the dynamic marking, and causes the appropriate specialization assertions to be added. Differential Revision: [D46415786](https://our.internmc.facebook.com/intern/diff/D46415786/) cc voznesenskym penguinwu anijain2305 EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng Xia-Weiwen wenzhe-nrv jiayisunx ipiszy aakhundov [ghstack-poisoned]
Configuration menu - View commit details
-
Copy full SHA for cc80e79 - Browse repository at this point
Copy the full SHA cc80e79View commit details -
Update on "fix soundness bug with unsupported constraints"
We do not raise constraint violations for complex binary conditions, such as conditions involving `%`. Moreover, while these constraints are discovered by our solver, the solver does not inject new constraint violations. This can result in cases where export passes, appropriate assertions are not added, and we get runtime crashes. Now, when the solver discovers constraints that are too complex, we force-specialize the involved dimensions and raise a constraint violation when such dimensions are marked dynamic. This forces the user to remove the dynamic marking, and causes the appropriate specialization assertions to be added. Differential Revision: [D46415786](https://our.internmc.facebook.com/intern/diff/D46415786/) cc voznesenskym penguinwu anijain2305 EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng Xia-Weiwen wenzhe-nrv jiayisunx ipiszy aakhundov [ghstack-poisoned]
Configuration menu - View commit details
-
Copy full SHA for d8a72c8 - Browse repository at this point
Copy the full SHA d8a72c8View commit details