fix 'Node' object is not iterable in functorch.compile.minifier

[makslevental]

Fixes #102169

cc @mgehre-amd

[pytorch-bot]

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/103011

• 📄 Preview Python docs built from this PR
• 📄 Preview C++ docs built from this PR
• ❓ Need help or want to give feedback on the CI? Visit the bot commands wiki or our office hours

Note: Links to docs will display an error until the docs builds have been completed.

✅ You can merge normally! (2 Unrelated Failures)

As of commit 936af42 with merge base 388ba7e ():

FLAKY - The following jobs failed but were likely due to flakiness present on trunk:

• linux-focal-rocm5.6-py3.8 / test (default, 1, 3, linux.rocm.gpu) (gh)
• linux-focal-rocm5.6-py3.8 / test (default, 3, 3, linux.rocm.gpu) (gh)

This comment was automatically generated by Dr. CI and updates every 15 minutes.

[linux-foundation-easycla]

The committers listed above are authorized under a signed CLA.

• ✅ login: makslevental / name: Maksim Levental (936af42)

[makslevental]

@zou3519 test fails look like flakes to me.

[zou3519]

Deferring to @Chillee

[github-actions]

Looks like this PR hasn't been updated in a while so we're going to go ahead and mark this as Stale.
Feel free to remove the Stale label if you feel this was a mistake.
If you are unable to remove the Stale label please contact a maintainer in order to do so.
If you want the bot to never mark this PR stale again, add the no-stale label.
Stale pull requests will automatically be closed after 30 days of inactivity.

[mgehre-amd]

Ping, this fix is important for us. Can someone re-run the tests, please?

[zou3519]

@pytorchbot rebase

[pytorchmergebot]

@pytorchbot started a rebase job onto refs/remotes/origin/viable/strict. Check the current status here

[pytorchmergebot]

Successfully rebased fix_minifier onto refs/remotes/origin/viable/strict, please pull locally before adding more changes (for example, via git checkout fix_minifier && git pull --rebase)

[makslevental]

ping @zou3519

[kit1980]

Is this ready to be merged?

[makslevental]

Is this ready to be merged?

approved and all tests pass (1 skip) so i think so?

[kit1980]

@makslevental FYI when a PR is approved by a project member, anyone can post a "@pytorchbot merge" comment to merge the PR.

[makslevental]

@pytorchbot merge

[pytorchmergebot]

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging

Check the merge workflow status
here

[pytorchmergebot]

Merge failed

Reason: 1 jobs have failed, first few of them are: trunk / linux-focal-rocm5.6-py3.8 / test (default, 1, 3, linux.rocm.gpu)

Details for Dev Infra team

Raised by workflow job

[makslevental]

@kit1980 I believe this failed test is a flake. Can you please land on your side.

[Chillee]

Can anybody use pytorchbot merge -f too? haha

[Chillee]

@pytorchbot merge -f "flaky tests"

[pytorchmergebot]

Merge started

Your change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Please use -f as last resort and instead consider -i/--ignore-current to continue the merge ignoring current failures. This will allow currently pending tests to finish and report signal before the merge.

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging

Check the merge workflow status
here