Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add multi swa support for custom device #103297

Closed
wants to merge 1 commit into from
Closed

add multi swa support for custom device #103297

wants to merge 1 commit into from

Conversation

heidongxianhua
Copy link
Contributor

Fixes #ISSUE_NUMBER
add multi swa support for custom device

@pytorch-bot pytorch-bot bot added the release notes: nn release notes category label Jun 9, 2023
@pytorch-bot
Copy link

pytorch-bot bot commented Jun 9, 2023 •
edited

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/103297

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 68ec831:
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

janeyx99
janeyx99 approved these changes Jun 9, 2023
View reviewed changes
Copy link
Contributor

@janeyx99 janeyx99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems okay--have you verified there are no other spots where we'd need to add _get_foreach_kernels_supported_devices()?

@heidongxianhua
Copy link
Contributor Author

@pytorchbot label "ciflow/inductor"

@heidongxianhua
Copy link
Contributor Author

@pytorchbot merge

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Jun 10, 2023
@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@heidongxianhua
Copy link
Contributor Author

seems okay--have you verified there are no other spots where we'd need to add _get_foreach_kernels_supported_devices()?

yeah I have checked again, there is no need to add elsewhere now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@janeyx99 janeyx99 janeyx99 approved these changes

@albanD albanD Awaiting requested review from albanD albanD is a code owner

Assignees
No one assigned
Labels
ciflow/inductor ciflow/trunk Trigger trunk jobs on your pull request Merged open source release notes: nn release notes category
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@heidongxianhua @pytorchmergebot @janeyx99 @pytorchbot