Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[pt2] add metas for avg_pool3d and avg_pool3d_backward #103392

Closed
wants to merge 2 commits into from
Closed

[pt2] add metas for avg_pool3d and avg_pool3d_backward #103392

wants to merge 2 commits into from

Conversation

nkaretnikov
Copy link
Collaborator

@nkaretnikov nkaretnikov commented Jun 11, 2023 •
edited

@pytorch-bot
Copy link

pytorch-bot bot commented Jun 11, 2023 •
edited

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/103392

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 4911f74:
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

nkaretnikov added a commit that referenced this pull request Jun 11, 2023
@nkaretnikov
[pt2] add metas for avg_pool3d and avg_pool3d_backward
89204d4 
ghstack-source-id: fb0d5d7bc45844321b9da373cd705482403ee315
Pull Request resolved: #103392
@nkaretnikov nkaretnikov added ciflow/trunk Trigger trunk jobs on your pull request topic: not user facing topic category ciflow/inductor labels Jun 11, 2023
nkaretnikov added a commit that referenced this pull request Jun 11, 2023
@nkaretnikov
[pt2] add metas for avg_pool3d and avg_pool3d_backward
e038849 
ghstack-source-id: 3487bd0a73a428d1d3001609a9f466fe94cb89e8
Pull Request resolved: #103392
This was referenced Jun 11, 2023
Closed
Closed
@nkaretnikov nkaretnikov marked this pull request as ready for review June 12, 2023 03:28
ezyang
ezyang approved these changes Jun 12, 2023
View reviewed changes
Copy link
Contributor

@ezyang ezyang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are opportunities to use Python to make this more maintainable, like kwargs, but a straight port is fine to start

@facebook-github-bot facebook-github-bot deleted the gh/nkaretnikov/135/head branch June 17, 2023 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ezyang ezyang ezyang approved these changes

@Chillee Chillee Awaiting requested review from Chillee

Assignees
No one assigned
Labels
ciflow/inductor ciflow/trunk Trigger trunk jobs on your pull request Merged open source topic: not user facing topic category
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@nkaretnikov @ezyang @pytorchbot @pytorchmergebot