Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use assertEqual() instead of assertTrue(same()) #103429

Closed
wants to merge 2 commits into from

Conversation

Signed-off-by: Edward Z. Yang <ezyang@meta.com>

[ghstack-poisoned]
@pytorch-bot pytorch-bot bot added the topic: not user facing topic category label Jun 12, 2023
ezyang added a commit that referenced this pull request Jun 12, 2023
Signed-off-by: Edward Z. Yang <ezyangmeta.com>

ghstack-source-id: 22d027b7bbd51fef48ae0a0162955f9a7a07bdae
Pull Request resolved: #103429
Signed-off-by: Edward Z. Yang <ezyangmeta.com>

cc voznesenskym penguinwu anijain2305 EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng Xia-Weiwen wenzhe-nrv jiayisunx ipiszy

[ghstack-poisoned]
ezyang added a commit that referenced this pull request Jun 12, 2023
Signed-off-by: Edward Z. Yang <ezyangmeta.com>

ghstack-source-id: 48fa4cb654caa824761f424b714d0af836407f75
Pull Request resolved: #103429
Copy link
Collaborator

@albanD albanD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good!
CI doesn't seem happy though

@github-actions
Copy link

Looks like this PR hasn't been updated in a while so we're going to go ahead and mark this as Stale.
Feel free to remove the Stale label if you feel this was a mistake.
If you are unable to remove the Stale label please contact a maintainer in order to do so.
If you want the bot to never mark this PR stale again, add the no-stale label.
Stale pull requests will automatically be closed after 30 days of inactivity.

@github-actions github-actions bot added the Stale label Aug 19, 2023
@github-actions github-actions bot closed this Sep 18, 2023
@facebook-github-bot facebook-github-bot deleted the gh/ezyang/2171/head branch October 19, 2023 14:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants