[memory_viz] profile_plot generates snapshot objects #103497
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will make it easier to use a single html viewer for both ways of generating the data. The next PR will change MemoryPlot.js to simply read the snapshot information directly. [ghstack-poisoned]
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/103497
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 06f90c5: This comment was automatically generated by Dr. CI and updates every 15 minutes. |
zdevito
added a commit
that referenced
this pull request
Jun 13, 2023
This will make it easier to use a single html viewer for both ways of generating the data. The next PR will change MemoryPlot.js to simply read the snapshot information directly. ghstack-source-id: 4be1800adfad3f027a42b4dbc3bcf9984e302710 Pull Request resolved: #103497
This will make it easier to use a single html viewer for both ways of generating the data. The next PR will change MemoryPlot.js to simply read the snapshot information directly. [ghstack-poisoned]
eellison
approved these changes
Jun 14, 2023
This will make it easier to use a single html viewer for both ways of generating the data. The next PR will change MemoryPlot.js to simply read the snapshot information directly. [ghstack-poisoned]
This will make it easier to use a single html viewer for both ways of generating the data. The next PR will change MemoryPlot.js to simply read the snapshot information directly. [ghstack-poisoned]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
This will make it easier to use a single html viewer for
both ways of generating the data. The next PR will change MemoryPlot.js
to simply read the snapshot information directly.