Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FSDP][state_dict] Add a summary log when finishing state_dict #103784

Closed
wants to merge 5 commits into from

Conversation

Add a summary log when finishing state_dict

Differential Revision: [D46807103](https://our.internmc.facebook.com/intern/diff/D46807103/)

[ghstack-poisoned]
@pytorch-bot
Copy link

pytorch-bot bot commented Jun 16, 2023

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/103784

Note: Links to docs will display an error until the docs builds have been completed.

❌ 2 New Failures

As of commit 75766be:

NEW FAILURES - The following jobs have failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

Copy link
Contributor

@fduwjj fduwjj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

…dict"

Add a summary log when finishing state_dict

Differential Revision: [D46807103](https://our.internmc.facebook.com/intern/diff/D46807103/)

[ghstack-poisoned]
fegin added a commit that referenced this pull request Jun 20, 2023
Pull Request resolved: #103784

Add a summary log when finishing state_dict
ghstack-source-id: 192644996

Differential Revision: [D46807103](https://our.internmc.facebook.com/intern/diff/D46807103/)
…dict"

Add a summary log when finishing state_dict

Differential Revision: [D46807103](https://our.internmc.facebook.com/intern/diff/D46807103/)

[ghstack-poisoned]
fegin added a commit that referenced this pull request Jun 20, 2023
Pull Request resolved: #103784

Add a summary log when finishing state_dict
ghstack-source-id: 192657165

Differential Revision: [D46807103](https://our.internmc.facebook.com/intern/diff/D46807103/)
@fegin fegin added the ciflow/trunk Trigger trunk jobs on your pull request label Jun 20, 2023
@fegin
Copy link
Contributor Author

fegin commented Jun 21, 2023

The failing test is not related

HEAD is now at 45c9b82 Auto-detect C++ ABI version (#321)
+ python multipy/runtime/example/generate_examples.py
/opt/conda/envs/py_3.10/lib/python3.10/site-packages/torch/package/package_exporter.py:925: UserWarning: TypedStorage is deprecated. It will be removed in the future and UntypedStorage will be the only storage class. This should only matter to you if you are using storages directly.  To access UntypedStorage directly, use tensor.untyped_storage() instead of tensor.storage()
  storage_type_str = obj.pickle_storage_type()
+ pip install -e . --install-option=--cudatests

Usage:   
  pip install [options] <requirement specifier> [package-index-options] ...
  pip install [options] -r <requirements file> [package-index-options] ...
  pip install [options] [-e] <vcs project url> ...
  pip install [options] [-e] <local project path> ...
  pip install [options] <archive url/path> ...

Copy link
Contributor

@fduwjj fduwjj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

…dict"

Add a summary log when finishing state_dict

Differential Revision: [D46807103](https://our.internmc.facebook.com/intern/diff/D46807103/)

[ghstack-poisoned]
fegin added a commit that referenced this pull request Jun 21, 2023
Pull Request resolved: #103784

Add a summary log when finishing state_dict
ghstack-source-id: 192732157

Differential Revision: [D46807103](https://our.internmc.facebook.com/intern/diff/D46807103/)
…dict"

Add a summary log when finishing state_dict

Differential Revision: [D46807103](https://our.internmc.facebook.com/intern/diff/D46807103/)

[ghstack-poisoned]
fegin added a commit that referenced this pull request Jun 21, 2023
Pull Request resolved: #103784

Add a summary log when finishing state_dict
ghstack-source-id: 192833263

Differential Revision: [D46807103](https://our.internmc.facebook.com/intern/diff/D46807103/)
@fegin
Copy link
Contributor Author

fegin commented Jun 22, 2023

@pytorchbot merge -f "The failing test is not related"

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@facebook-github-bot facebook-github-bot deleted the gh/fegin/141/head branch June 26, 2023 14:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ciflow/trunk Trigger trunk jobs on your pull request Merged release notes: distributed (fsdp) release notes category
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants