[pytorch/tensorexpr] Create LLJIT instance with an ObjectLinkingLayer #103824
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/103824
Note: Links to docs will display an error until the docs builds have been completed. ✅ 3 Unrelated FailuresAs of commit 05fbe78: UNSTABLE - The following jobs failed but were likely due to flakiness present on trunk and has been marked as unstable:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
Upstream LLVM switched LLJIT's default JIT linker for ELF/x86-64 to JITLink. This patch updates PytorchLLVMJITImpl to set ObjectLinkingLayer on LLJIT creation.
janeyx99
added
oncall: jit
|
@davidberard98 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
jeffdaily
approved these changes
Jun 22, 2023
davidberard98
approved these changes
Jun 22, 2023
|
@pytorchbot merge |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
jithunnair-amd
pushed a commit
to ROCm/pytorch
that referenced
this pull request
Jul 3, 2023
…pytorch#103824) - Upstream LLVM switched LLJIT's default JIT linker for ELF/x86-64 to JITLink: [commit](llvm/llvm-project@b92839c). This commit mandates clients to use JITLink plugins, following the example in "llvm/examples/OrcV2Examples/LLJITWithCustomObjectLinkingLayer". - Current change updates PytorchLLVMJITImpl to set ObjectLinkingLayer on LLJIT creation. - If setObjectLinkingLayerCreator not set, RTDyldObjectLinkingLayer will be constructed. This is currently causing "Symbols not found: [ llvm_orc_registerEHFrameSectionWrapper ]" error for tests in test_quantization.py when pytorch is built to use latest LLVM. Pull Request resolved: pytorch#103824 Approved by: https://github.com/jeffdaily, https://github.com/davidberard98 (cherry picked from commit d2d3394)
jithunnair-amd
pushed a commit
to ROCm/pytorch
that referenced
this pull request
Jul 3, 2023
…pytorch#103824) - Upstream LLVM switched LLJIT's default JIT linker for ELF/x86-64 to JITLink: [commit](llvm/llvm-project@b92839c). This commit mandates clients to use JITLink plugins, following the example in "llvm/examples/OrcV2Examples/LLJITWithCustomObjectLinkingLayer". - Current change updates PytorchLLVMJITImpl to set ObjectLinkingLayer on LLJIT creation. - If setObjectLinkingLayerCreator not set, RTDyldObjectLinkingLayer will be constructed. This is currently causing "Symbols not found: [ llvm_orc_registerEHFrameSectionWrapper ]" error for tests in test_quantization.py when pytorch is built to use latest LLVM. Pull Request resolved: pytorch#103824 Approved by: https://github.com/jeffdaily, https://github.com/davidberard98 (cherry picked from commit d2d3394)
jithunnair-amd
pushed a commit
to ROCm/pytorch
that referenced
this pull request
Jul 3, 2023
…pytorch#103824) - Upstream LLVM switched LLJIT's default JIT linker for ELF/x86-64 to JITLink: [commit](llvm/llvm-project@b92839c). This commit mandates clients to use JITLink plugins, following the example in "llvm/examples/OrcV2Examples/LLJITWithCustomObjectLinkingLayer". - Current change updates PytorchLLVMJITImpl to set ObjectLinkingLayer on LLJIT creation. - If setObjectLinkingLayerCreator not set, RTDyldObjectLinkingLayer will be constructed. This is currently causing "Symbols not found: [ llvm_orc_registerEHFrameSectionWrapper ]" error for tests in test_quantization.py when pytorch is built to use latest LLVM. Pull Request resolved: pytorch#103824 Approved by: https://github.com/jeffdaily, https://github.com/davidberard98 (cherry picked from commit d2d3394)
jithunnair-amd
pushed a commit
to ROCm/pytorch
that referenced
this pull request
Jul 3, 2023
…pytorch#103824) - Upstream LLVM switched LLJIT's default JIT linker for ELF/x86-64 to JITLink: [commit](llvm/llvm-project@b92839c). This commit mandates clients to use JITLink plugins, following the example in "llvm/examples/OrcV2Examples/LLJITWithCustomObjectLinkingLayer". - Current change updates PytorchLLVMJITImpl to set ObjectLinkingLayer on LLJIT creation. - If setObjectLinkingLayerCreator not set, RTDyldObjectLinkingLayer will be constructed. This is currently causing "Symbols not found: [ llvm_orc_registerEHFrameSectionWrapper ]" error for tests in test_quantization.py when pytorch is built to use latest LLVM. Pull Request resolved: pytorch#103824 Approved by: https://github.com/jeffdaily, https://github.com/davidberard98 (cherry picked from commit d2d3394)
jithunnair-amd
pushed a commit
to ROCm/pytorch
that referenced
this pull request
Jul 3, 2023
…pytorch#103824) - Upstream LLVM switched LLJIT's default JIT linker for ELF/x86-64 to JITLink: [commit](llvm/llvm-project@b92839c). This commit mandates clients to use JITLink plugins, following the example in "llvm/examples/OrcV2Examples/LLJITWithCustomObjectLinkingLayer". - Current change updates PytorchLLVMJITImpl to set ObjectLinkingLayer on LLJIT creation. - If setObjectLinkingLayerCreator not set, RTDyldObjectLinkingLayer will be constructed. This is currently causing "Symbols not found: [ llvm_orc_registerEHFrameSectionWrapper ]" error for tests in test_quantization.py when pytorch is built to use latest LLVM. Pull Request resolved: pytorch#103824 Approved by: https://github.com/jeffdaily, https://github.com/davidberard98 (cherry picked from commit d2d3394)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upstream LLVM switched LLJIT's default JIT linker for ELF/x86-64 to JITLink: commit. This commit mandates clients to use JITLink plugins, following the example in "llvm/examples/OrcV2Examples/LLJITWithCustomObjectLinkingLayer".
Current change updates PytorchLLVMJITImpl to set ObjectLinkingLayer on LLJIT creation.
If setObjectLinkingLayerCreator not set, RTDyldObjectLinkingLayer will be constructed. This is currently causing "Symbols not found: [ llvm_orc_registerEHFrameSectionWrapper ]" error for tests in test_quantization.py when pytorch is built to use latest LLVM.
cc @EikanWang @jgong5 @wenzhe-nrv @sanchitintel @jeffdaily