Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[pytorch] Update docstring for FSDP.set_state_dict_type #103864

Closed
wants to merge 1 commit into from
Closed

[pytorch] Update docstring for FSDP.set_state_dict_type #103864

wants to merge 1 commit into from

Conversation

daniellepintz
Copy link
Contributor

Summary: I noticed optim_state_dict_config was missing from the Args section

Test Plan: N/A

Reviewed By: rohan-varma

Differential Revision: D46670165

@pytorch-bot
Copy link

pytorch-bot bot commented Jun 19, 2023 •
edited

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/103864

Note: Links to docs will display an error until the docs builds have been completed.

❗ 1 Merge Blocking SEVs

There is 1 active merge blocking SEVs. Please view them below:

If you must merge, use @pytorchbot merge -f.

✅ You can merge normally! (1 Unrelated Failure)

As of commit 3afc55d with merge base a74f50d (image):

FLAKY - The following job failed but was likely due to flakiness present on trunk:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@pytorch-bot pytorch-bot bot added the release notes: distributed (sharded) release notes category label Jun 19, 2023
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D46670165

@rohan-varma
Copy link
Member

pls fix lint before landing

fegin
fegin approved these changes Jun 20, 2023
View reviewed changes
Copy link
Contributor

@fegin fegin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

daniellepintz added a commit to daniellepintz/pytorch that referenced this pull request Jun 20, 2023
@daniellepintz @facebook-github-bot
[pytorch] Update docstring for FSDP.set_state_dict_type (pytorch#103864)
8ffbe98 
Summary:
Pull Request resolved: pytorch#103864

I noticed optim_state_dict_config was missing from the Args section

Test Plan: N/A

Reviewed By: fegin, rohan-varma

Differential Revision: D46670165

fbshipit-source-id: 696fa03463e6bdecdf3ed1c38a75d1713b392f88
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D46670165

@daniellepintz
Copy link
Contributor Author

Hi, how do I land this?

@fduwjj
Copy link
Contributor

fduwjj commented Jun 21, 2023

@daniellepintz you can use pytorchbot to rebase and merge on Github first. Then the diff will be landed in a diff train which you don't need to worry about.

@daniellepintz
Copy link
Contributor Author

@pytorchbot merge

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Jun 21, 2023
@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@pytorchmergebot
Copy link
Collaborator

Merge failed

Reason: 1 mandatory check(s) failed. The first few are:

Dig deeper by viewing the failures on hud

Details for Dev Infra team Raised by workflow job

Failing merge rule: Core Maintainers

@daniellepintz
Copy link
Contributor Author

@pytorchbot merge

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@pytorchmergebot
Copy link
Collaborator

Merge failed

Reason: This PR is too stale; the last push date was more than 3 days ago. Please rebase and try again. You can rebase and merge by leaving the following comment on this PR:
@pytorchbot merge -r
Or just rebase by leaving @pytorchbot rebase comment

Details for Dev Infra team Raised by workflow job

@daniellepintz
Copy link
Contributor Author

@rohan-varma @fduwjj @fegin Could someone pls help me land this PR?

@daniellepintz
Copy link
Contributor Author

@pytorchbot merge

@pytorchmergebot
Copy link
Collaborator

Merge failed

Reason: Not merging any PRs at the moment because there is a merge blocking https://github.com/pytorch/pytorch/labels/ci:%20sev issue open at:
#108524

Details for Dev Infra team Raised by workflow job

daniellepintz added a commit to daniellepintz/pytorch that referenced this pull request Sep 5, 2023
@daniellepintz @facebook-github-bot
[pytorch] Update docstring for FSDP.set_state_dict_type (pytorch#103864)
b0427e1 
Summary:

I noticed optim_state_dict_config was missing from the Args section

Test Plan: N/A

Reviewed By: fegin, fduwjj, rohan-varma

Differential Revision: D46670165
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D46670165

@daniellepintz @facebook-github-bot
[pytorch] Update docstring for FSDP.set_state_dict_type (pytorch#103864)
3afc55d 
Summary:
Pull Request resolved: pytorch#103864

I noticed optim_state_dict_config was missing from the Args section

Test Plan: N/A

Reviewed By: fegin, fduwjj, rohan-varma

Differential Revision: D46670165

fbshipit-source-id: 2efea7e382ba268df9b002eefc20ca0b9c700091
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D46670165

@daniellepintz
Copy link
Contributor Author

@pytorchbot merge

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@daniellepintz daniellepintz deleted the export-D46670165 branch September 5, 2023 22:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fegin fegin fegin approved these changes

@fduwjj fduwjj fduwjj approved these changes

@rohan-varma rohan-varma rohan-varma approved these changes

@mrshenli mrshenli Awaiting requested review from mrshenli

@zhaojuanmao zhaojuanmao Awaiting requested review from zhaojuanmao

@H-Huang H-Huang Awaiting requested review from H-Huang

@awgu awgu Awaiting requested review from awgu

@kwen2501 kwen2501 Awaiting requested review from kwen2501

@wanchaol wanchaol Awaiting requested review from wanchaol

@kiukchung kiukchung Awaiting requested review from kiukchung

@d4l3k d4l3k Awaiting requested review from d4l3k

@wz337 wz337 Awaiting requested review from wz337

Assignees
No one assigned
Labels
ciflow/trunk Trigger trunk jobs on your pull request fb-exported Merged release notes: distributed (sharded) release notes category
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@daniellepintz @facebook-github-bot @rohan-varma @fduwjj @pytorchmergebot @fegin