Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix a docstring of resolve_neg #104151

Closed
wants to merge 2 commits into from
Closed

Fix a docstring of resolve_neg #104151

wants to merge 2 commits into from

Conversation

kato8966
Copy link
Contributor

@kato8966 kato8966 commented Jun 25, 2023 •
edited by pytorch-bot bot

@pytorch-bot pytorch-bot bot added the release notes: python_frontend release notes category label Jun 25, 2023
@pytorch-bot
Copy link

pytorch-bot bot commented Jun 25, 2023 •
edited

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/104151

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 54326ab:
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Jun 25, 2023 •
edited

CLA Signed

The committers listed above are authorized under a signed CLA.

@kit1980
Copy link
Member

kit1980 commented Jun 25, 2023

@kato8966 please sign the CLA

@kato8966
Copy link
Contributor Author

@kit1980 Ok. I signed it and sent it to the PyTorch team.

@kit1980
Copy link
Member

kit1980 commented Jun 26, 2023

/easycla

@malfet malfet added module: docs Related to our documentation, both in docs/ and docblocks triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module labels Jun 27, 2023
@malfet
Copy link
Contributor

malfet commented Jun 27, 2023

/easycla

@malfet
Copy link
Contributor

malfet commented Jun 27, 2023

@kato8966 you need to sign CLA using the same email as commit you've authored, and this email also must be registered with your github account.

@kato8966
Copy link
Contributor Author

@malfet Sorry, I didn't sign a CLA with an email address used for the merge commit. I resent the PyTorch team a signed CLA with the address.

@kit1980
Copy link
Member

kit1980 commented Jun 28, 2023

/easycla

@kit1980
Copy link
Member

kit1980 commented Jun 28, 2023

@kato8966 The CLA check is still failing.
Did you click "Please click here to be authorized" link and followed the steps?

@kato8966
Copy link
Contributor Author

@kit1980 I proceeded to the link, filled out the form, printed it out, signed it, and emailed it to the PyTorch team. Maybe they hadn't checked the email yet?

@kato8966
Copy link
Contributor Author

kato8966 commented Jul 9, 2023

/easycla

@kato8966
Copy link
Contributor Author

EasyCLA check was passed.

@malfet
Copy link
Contributor

malfet commented Jul 19, 2023

@pytorchbot merge -f "Doc only change"

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@kato8966 kato8966 deleted the fix-resolve_neg-docstring branch July 21, 2023 03:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@malfet malfet malfet approved these changes

Assignees
No one assigned
Labels
Merged module: docs Related to our documentation, both in docs/ and docblocks open source release notes: python_frontend release notes category triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@kato8966 @kit1980 @malfet @pytorchmergebot @pytorchbot