-
Notifications
You must be signed in to change notification settings - Fork 21.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix an ASAN error in MKLDNN #104331
fix an ASAN error in MKLDNN #104331
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/104331
Note: Links to docs will display an error until the docs builds have been completed. ✅ 1 Unrelated FailureAs of commit c3439d8: UNSTABLE - The following job failed but was likely due to flakiness present on trunk and has been marked as unstable:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
@pytorchbot label "topic: not user facing" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you elaborate on why this fixes the ASAN error?
@soulitzer contiguous_strides returns a DimVector, then the old function call passed it to a IntArrayRef result, which became a dangling reference. And in fact, this commit was picked from PR #104224. The error disappeared after the change. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
@pytorchmergebot merge |
@pytorchmergebot merge |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
Fixes ASAN stack-use-after-scope in MKLDNN.
The stack trace is
cc @jgong5 @mingfeima @XiaobingSuper @sanchitintel @ashokei @jingxu10