Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix UntypedStorage pin error #104355

Closed
wants to merge 1 commit into from
Closed

Conversation

r-barnes
Copy link
Contributor

Summary:
Fixes:

TypeError: cannot pin 'torch.storage.UntypedStorage' only CPU memory can be pinned

Test Plan: Sandcastle

Differential Revision: D47093797

@pytorch-bot
Copy link

pytorch-bot bot commented Jun 28, 2023

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/104355

Note: Links to docs will display an error until the docs builds have been completed.

✅ 1 Unrelated Failure

As of commit 24c512f:

UNSTABLE - The following job failed but was likely due to flakiness present on trunk and has been marked as unstable:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D47093797

r-barnes added a commit to r-barnes/pytorch that referenced this pull request Jun 28, 2023
Summary:
Pull Request resolved: pytorch#104355

Fixes:
```
TypeError: cannot pin 'torch.storage.UntypedStorage' only CPU memory can be pinned
```

Test Plan: Sandcastle

Differential Revision: D47093797

fbshipit-source-id: 54ace8fad4aecf5055f1448bba309ded7517791a
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D47093797

Summary:
Pull Request resolved: pytorch#104355

Fixes:
```
TypeError: cannot pin 'torch.storage.UntypedStorage' only CPU memory can be pinned
```

Test Plan: Sandcastle

Differential Revision: D47093797

fbshipit-source-id: 3c024538331c29c8c0fd494ab0915093d73fb422
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D47093797

@r-barnes
Copy link
Contributor Author

Test failure is unrelated.

@r-barnes r-barnes added release notes: memory format release notes category topic: improvements topic category topic: bug fixes topic category labels Jun 29, 2023
Copy link
Contributor

@malfet malfet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but not sure how is this possible right now. Are we not running the test for some reason?

@malfet
Copy link
Contributor

malfet commented Jun 29, 2023

@pytorchbot drci

@malfet
Copy link
Contributor

malfet commented Jun 29, 2023

@pytorchbot merge

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Jun 29, 2023
@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ciflow/trunk Trigger trunk jobs on your pull request fb-exported Merged release notes: memory format release notes category topic: bug fixes topic category topic: improvements topic category
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants