Make torch._dynamo lazy-importable
#104368
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use https://peps.python.org/pep-0562 to import `_dynamo` and `_inductor` only when needed. Remove redundant imports from tests
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/104368
Note: Links to docs will display an error until the docs builds have been completed. ✅ 1 Unrelated FailureAs of commit 8578509: UNSTABLE - The following job failed but was likely due to flakiness present on trunk and has been marked as unstable:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
malfet
added
release notes: python_frontend
albanD
approved these changes
Jun 28, 2023
msaroufim
reviewed
Jun 28, 2023
|
@pytorchbot merge |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
pytorchmergebot
pushed a commit
that referenced
this pull request
Jul 1, 2023
This fixes the bug in profiler code exposed by #104368 that introduced on the fact that `import torch._dynamo` also imports `torch._inductor.config`: ``` $ python -c "import torch._inductor;print(torch._inductor.config)" Traceback (most recent call last): File "<string>", line 1, in <module> AttributeError: module 'torch._inductor' has no attribute 'config' (base) $ python -c "import torch._dynamo;print(torch._inductor.config)" <module 'torch._inductor.config' from '/home/nshulga/git/pytorch/pytorch/torch/_inductor/config.py'> ``` ### Testing D47159397 Pull Request resolved: #104477 Approved by: https://github.com/aaronenyeshi, https://github.com/malfet
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use PEP-562 to import
_dynamoand_inductoronly when needed.test_lazy_imports_are_lazyto make sure they will not get imported by accident🤖 Generated by Copilot at bae8e90
cc @voznesenskym @penguinwu @EikanWang @jgong5 @Guobing-Chen @XiaobingSuper @zhuhaozhe @blzheng @Xia-Weiwen @wenzhe-nrv @jiayisunx @peterbell10 @ipiszy @ngimel @yf225 @chenyang78 @anijain2305