-
Notifications
You must be signed in to change notification settings - Fork 21.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FSDP][3/N] Unify fully_shard
auto wrap
#104408
Closed
Closed
Changes from all commits
Commits
Show all changes
15 commits
Select commit
Hold shift + click to select a range
960ce5c
[FSDP][3/N] Unify `fully_shard` auto wrap
awgu e6e27b7
Update on "[FSDP][3/N] Unify `fully_shard` auto wrap"
awgu c0097c2
Update on "[FSDP][3/N] Unify `fully_shard` auto wrap"
awgu b5e6340
Update on "[FSDP][3/N] Unify `fully_shard` auto wrap"
awgu a6b5800
Update on "[FSDP][3/N] Unify `fully_shard` auto wrap"
awgu 90a74eb
Update on "[FSDP][3/N] Unify `fully_shard` auto wrap"
awgu 0458533
Update on "[FSDP][3/N] Unify `fully_shard` auto wrap"
awgu 14a0ef4
Update on "[FSDP][3/N] Unify `fully_shard` auto wrap"
awgu e35cc2e
Update on "[FSDP][3/N] Unify `fully_shard` auto wrap"
awgu f3be93d
Update on "[FSDP][3/N] Unify `fully_shard` auto wrap"
awgu 141f2e8
Update on "[FSDP][3/N] Unify `fully_shard` auto wrap"
awgu ecbfd72
Update on "[FSDP][3/N] Unify `fully_shard` auto wrap"
voznesenskym 6a01c9a
Update on "[FSDP][3/N] Unify `fully_shard` auto wrap"
awgu 954b142
Update on "[FSDP][3/N] Unify `fully_shard` auto wrap"
awgu c501068
Update on "[FSDP][3/N] Unify `fully_shard` auto wrap"
awgu File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
did we add a test for this + test to ensure that if a composable FSDP module manages no params, it is still marked as FSDP managed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the
_has_fsdp_params()
check is still valid. Before, the composable path would raise an error when it did not need to, which is why I had to add this case.In other words, this is covered by the existing tests.
summon_full_params()
on a module withfully_shard()
applied but no managed parameters would error otherwise.