Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix torch.bucketize docs for "right" #104474

Closed

Commits on Jun 30, 2023

  1. Fix torch.bucketize docs for "right"

    The docs correctly (i.e matching actual op behavior) state that
    
    `right = False` means `boundaries[i-1] < input[m][n]...[l][x] <= boundaries[i]`.
    
    However they previously stated that
    `If 'right' is False (default), then the left boundary is closed.`
    
    which contradicts the `boundaries[i-1] < input[m][n]...[l][x] <= boundaries[i]` statement.
    
    This modifies the docs to say `... then the left boundary is OPEN.` and also clarifies that this is the opposite behavior of numpy.digitize.
    
    [ghstack-poisoned]
    davidberard98 committed Jun 30, 2023
    Configuration menu
    Copy the full SHA
    68b00ac View commit details
    Browse the repository at this point in the history

Commits on Aug 16, 2023

  1. Update on "Fix torch.bucketize docs for "right""

    The docs correctly (i.e matching actual op behavior) state that
    
    `right = False` means `boundaries[i-1] < input[m][n]...[l][x] <= boundaries[i]`.
    
    However they previously stated that
    `If 'right' is False (default), then the left boundary is closed.`
    
    which contradicts the `boundaries[i-1] < input[m][n]...[l][x] <= boundaries[i]` statement.
    
    This modifies the docs to say `... then the left boundary is OPEN.` and also clarifies that this is the opposite behavior of numpy.digitize.
    
    Fixes #91580
    
    [ghstack-poisoned]
    davidberard98 committed Aug 16, 2023
    Configuration menu
    Copy the full SHA
    febb5e8 View commit details
    Browse the repository at this point in the history
  2. Add missing period as suggested by svekars on "Fix torch.bucketize do…

    …cs for "right""
    
    
    The docs correctly (i.e matching actual op behavior) state that
    
    `right = False` means `boundaries[i-1] < input[m][n]...[l][x] <= boundaries[i]`.
    
    However they previously stated that
    `If 'right' is False (default), then the left boundary is closed.`
    
    which contradicts the `boundaries[i-1] < input[m][n]...[l][x] <= boundaries[i]` statement.
    
    This modifies the docs to say `... then the left boundary is OPEN.` and also clarifies that this is the opposite behavior of numpy.digitize.
    
    Fixes #91580
    
    [ghstack-poisoned]
    davidberard98 committed Aug 16, 2023
    Configuration menu
    Copy the full SHA
    9159edc View commit details
    Browse the repository at this point in the history