Move most SymPy functions to their own file #104556
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
All these are standalone implementations of some functions and they don't depend on anything else, so we better have them under the `_sympy/` folder on their own [ghstack-poisoned]
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/104556
Note: Links to docs will display an error until the docs builds have been completed. ✅ 1 Unrelated FailureAs of commit c81683f: UNSTABLE - The following job failed but was likely due to flakiness present on trunk and has been marked as unstable:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
This was referenced Jul 3, 2023
lezcano
added
the
suppress-bc-linter
ezyang
approved these changes
Jul 3, 2023
All these are standalone implementations of some functions and they don't depend on anything else, so we better have them under the `_sympy/` folder on their own cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng Xia-Weiwen wenzhe-nrv jiayisunx peterbell10 ipiszy ngimel yf225 chenyang78 [ghstack-poisoned]
|
@pytorchbot merge |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
vkallesh
pushed a commit
to amd/ZenDNN-pytorch
that referenced
this pull request
Jul 5, 2023
All these are standalone implementations of some functions and they don't depend on anything else, so we better have them under the `_sympy/` folder on their own ghstack-source-id: 5b31750359455a299026b92f3d627fe85edb369e Pull Request resolved: pytorch/pytorch#104556
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
All these are standalone implementations of some functions and they
don't depend on anything else, so we better have them under the
_sympy/folder on their owncc @voznesenskym @penguinwu @EikanWang @jgong5 @Guobing-Chen @XiaobingSuper @zhuhaozhe @blzheng @Xia-Weiwen @wenzhe-nrv @jiayisunx @peterbell10 @ipiszy @ngimel @yf225 @chenyang78