Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cmake: allow USE_SYSTEM_ZSTD #104611

Closed
wants to merge 1 commit into from
Closed

cmake: allow USE_SYSTEM_ZSTD #104611

wants to merge 1 commit into from

Conversation

ConnorBaker
Copy link
Contributor

Fixes #44255.

This is part of larger work I'm doing to allow for more USE_SYSTEM_* options to allow Nix to have faster re-builds of PyTorch: NixOS/nixpkgs#239291.

@pytorch-bot
Copy link

pytorch-bot bot commented Jul 5, 2023 •
edited

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/104611

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 2772660:
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@ConnorBaker ConnorBaker mentioned this pull request Jul 5, 2023
Draft
42 tasks
@ConnorBaker
Copy link
Contributor Author

@ezyang or @malfet, if you have the bandwidth would you mind taking a look?

@ezyang
Copy link
Contributor

ezyang commented Jul 5, 2023

@pytorchbot merge

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Jul 5, 2023
@pytorchmergebot
Copy link
Collaborator

Merge failed

Reason: This PR needs a release notes: label
If your changes are user facing and intended to be a part of release notes, please use a label starting with release notes:.

If not, please add the topic: not user facing label.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "topic: not user facing"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

Details for Dev Infra team Raised by workflow job

@malfet malfet added release notes: build release notes category topic: improvements topic category labels Jul 5, 2023
@malfet
Copy link
Contributor

malfet commented Jul 5, 2023

@pytorchbot merge

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

ConnorBaker added a commit to ConnorBaker/pytorch that referenced this pull request Jul 5, 2023
@ConnorBaker @pytorchmergebot
cmake: allow USE_SYSTEM_ZSTD (pytorch#104611)
0c8323e 
Fixes pytorch#44255.

This is part of larger work I'm doing to allow for more `USE_SYSTEM_*` options to allow Nix to have faster re-builds of PyTorch: NixOS/nixpkgs#239291.

Pull Request resolved: pytorch#104611
Approved by: https://github.com/ezyang, https://github.com/malfet
@ConnorBaker ConnorBaker closed this Jul 6, 2023
@ConnorBaker ConnorBaker deleted the feat-use-system-zstd branch July 6, 2023 14:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ezyang ezyang ezyang approved these changes

@malfet malfet malfet approved these changes

Assignees
No one assigned
Labels
ciflow/trunk Trigger trunk jobs on your pull request Merged release notes: build release notes category topic: improvements topic category
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Allow to use system zstd
4 participants
@ConnorBaker @ezyang @pytorchmergebot @malfet