Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ONNX] Remove unnecessary deepcopy on args in 'DynamoExport' #104736

Closed
wants to merge 2 commits into from

Conversation

BowenBao
Copy link
Collaborator

@BowenBao BowenBao commented Jul 6, 2023

Stack from ghstack (oldest at bottom):

The comment is outdated. There should be no side-effects on args and kwargs.

@pytorch-bot
Copy link

pytorch-bot bot commented Jul 6, 2023

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/104736

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 9194480:
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@pytorch-bot pytorch-bot bot added release notes: onnx torch.onnx related changes that should show up in the release notes labels Jul 6, 2023
BowenBao added a commit that referenced this pull request Jul 6, 2023
ghstack-source-id: 33cad21d49b86a3b84c5ff8e0e56ea16ded4f2c4
Pull Request resolved: #104736
@BowenBao BowenBao marked this pull request as ready for review July 7, 2023 01:04
@BowenBao BowenBao added the topic: improvements topic category label Jul 7, 2023
@thiagocrepaldi
Copy link
Collaborator

@pytorchbot merge

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Jul 7, 2023
@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@pytorchmergebot
Copy link
Collaborator

Merge failed

Reason: 1 mandatory check(s) failed. The first few are:

Dig deeper by viewing the failures on hud

Details for Dev Infra team Raised by workflow job

Failing merge rule: Core Maintainers

@thiagocrepaldi
Copy link
Collaborator

@BowenBao there is an unused import copy at torch/onnx/_internal/fx/dynamo_graph_extractor.py

The comment is outdated. There should be no side-effects on `args` and `kwargs`.

[ghstack-poisoned]
BowenBao added a commit that referenced this pull request Jul 7, 2023
ghstack-source-id: dab13a91694caac44b6c1b2d957a619472eb3c48
Pull Request resolved: #104736
@thiagocrepaldi
Copy link
Collaborator

@pytorchbot merge

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@facebook-github-bot facebook-github-bot deleted the gh/BowenBao/259/head branch July 11, 2023 14:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ciflow/trunk Trigger trunk jobs on your pull request Merged open source release notes: onnx torch.onnx related changes that should show up in the release notes topic: improvements topic category
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants