Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Doc] Add Tensor.Shape #104750

Closed
wants to merge 1 commit into from
Closed

[Doc] Add Tensor.Shape #104750

wants to merge 1 commit into from

Conversation

isdanni
Copy link
Contributor

@isdanni isdanni commented Jul 6, 2023 •
edited

@pytorch-bot
Copy link

pytorch-bot bot commented Jul 6, 2023 •
edited

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/104750

Note: Links to docs will display an error until the docs builds have been completed.

✅ 1 Unrelated Failure

As of commit 990864e:

UNSTABLE - The following job failed but was likely due to flakiness present on trunk and has been marked as unstable:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D47278630

@vadimkantorov
Copy link
Contributor

vadimkantorov commented Jul 7, 2023 •
edited

Also, if tensor.shape is considered recommended over more ancient tensor.size(), it would be nice to have it mentioned explicitly in docs (and maybe should have See also: tensor.size() and mention that it's equivalent?)

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D47278630

isdanni added a commit to isdanni/pytorch that referenced this pull request Jul 7, 2023
@isdanni @facebook-github-bot
[Doc] Add Tensor.Shape (pytorch#104750)
0f9cb03 
Summary:
Pull Request resolved: pytorch#104750

Add `Tensor.Shape` doc.

Ref:

- pytorch#5544
- pytorch#1980

Differential Revision: D47278630

fbshipit-source-id: b549a68eb632f46db921fd5ae89ad58767a880a4
@isdanni
Copy link
Contributor Author

isdanni commented Jul 7, 2023

Also, if tensor.shape is considered recommended over more ancient tensor.size(), it would be nice to have it mentioned explicitly in docs (and maybe should have See also: tensor.size() and mention that it's equivalent?)

Thanks for the review! I added see also reference. I do agree shape makes more sense intuitively but it's really personal preference picking which to use(As seen in many codebase). I'd advise against including it in the official documentation for now.

@isdanni
Copy link
Contributor Author

isdanni commented Jul 18, 2023

Can anyone help me review the updated diff? :)

@vadimkantorov @svekars @carljparker

mikaylagawarecki
mikaylagawarecki approved these changes Jul 25, 2023
View reviewed changes
Copy link
Contributor

@mikaylagawarecki mikaylagawarecki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@isdanni @facebook-github-bot
[Doc] Add Tensor.Shape (pytorch#104750)
990864e 
Summary:
Pull Request resolved: pytorch#104750

Add `Tensor.Shape` doc.

Ref:

- pytorch#5544
- pytorch#1980

Differential Revision: D47278630

fbshipit-source-id: aa2466cba60b21860338e1ea6b8850f4395b6255
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D47278630

@mikaylagawarecki
Copy link
Contributor

@pytorchbot merge

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Jul 26, 2023
@pytorchmergebot
Copy link
Collaborator

Merge failed

Reason: Not merging any PRs at the moment because there is a merge blocking https://github.com/pytorch/pytorch/labels/ci:%20sev issue open at:
#105964

Details for Dev Infra team Raised by workflow job

@mikaylagawarecki
Copy link
Contributor

@pytorchbot merge

@pytorchmergebot
Copy link
Collaborator

Merge failed

Reason: This PR needs a release notes: label
If your changes are user facing and intended to be a part of release notes, please use a label starting with release notes:.

If not, please add the topic: not user facing label.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "topic: not user facing"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

Details for Dev Infra team Raised by workflow job

@mikaylagawarecki mikaylagawarecki added topic: docs topic category release notes: python_frontend release notes category labels Jul 26, 2023
@mikaylagawarecki
Copy link
Contributor

@pytorchbot merge

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mikaylagawarecki mikaylagawarecki mikaylagawarecki approved these changes

Assignees
No one assigned
Labels
ciflow/trunk Trigger trunk jobs on your pull request fb-exported Merged release notes: python_frontend release notes category topic: docs topic category
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Tensor.shape not documented
5 participants
@isdanni @facebook-github-bot @vadimkantorov @mikaylagawarecki @pytorchmergebot