[OpInfo] add reference and error inputs for multi_margin_loss
#104850
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[ghstack-poisoned]
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/104850
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 945cc67: This comment was automatically generated by Dr. CI and updates every 15 minutes. |
This was referenced Jul 9, 2023
nkaretnikov
added
ciflow/trunk
|
Summary:
|
nkaretnikov
commented
Jul 10, 2023
| @@ -9297,7 +9297,6 @@ def v(fn): | |||
|
|
|||
| v(lambda: F.nll_loss(input, target, reduction=reduction)) | |||
| v(lambda: F.cross_entropy(input, target, reduction=reduction)) | |||
| v(lambda: F.multi_margin_loss(input, target, reduction=reduction)) | |||
There was a problem hiding this comment.
Invalid reductions are tested in error inputs now.
nkaretnikov
commented
Jul 10, 2023
| def test_multi_margin_loss_errors(self, device): | ||
| self.assertRaises(RuntimeError, | ||
| lambda: nn.functional.multi_margin_loss(torch.randn(5, device=device), | ||
| torch.zeros(3, device=device))) |
There was a problem hiding this comment.
Invalid shapes are tested in error inputs now.
nkaretnikov
commented
Jul 10, 2023
| for target in (torch.tensor(0, device=device), torch.tensor([0], device=device)): | ||
| self.assertEqual(target.shape, torch.nn.functional.multi_margin_loss(input, target, reduction='none').shape) | ||
| self.assertEqual((), torch.nn.functional.multi_margin_loss(input, target, reduction='mean').shape) | ||
| self.assertEqual((), torch.nn.functional.multi_margin_loss(input, target, reduction='sum').shape) |
There was a problem hiding this comment.
Valid shapes/scalars were already tested in sample inputs.
…loss`" [ghstack-poisoned]
nkaretnikov
commented
Jul 13, 2023
| error_regex=( | ||
| r'inconsistent target size, expected 5 but got \[5, 4\]' | ||
| if torch.device(device).type == 'cuda' else | ||
| r'inconsistent target size, got: \[5, 4\]')) |
There was a problem hiding this comment.
This error-message-divergence is fixed in the next PR in the stack.
ezyang
approved these changes
Jul 13, 2023
…loss`" [ghstack-poisoned]
…loss`" [ghstack-poisoned]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
multi_margin_lossops #104578multi_margin_loss: checkweightshape, make contiguous on CPU, add tests #104852multi_margin_loss_shape_checkon CPU and CUDA #104851multi_margin_loss#104850