Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MPI] Allow previously initialized #105023

Closed
wants to merge 1 commit into from
Closed

[MPI] Allow previously initialized #105023

wants to merge 1 commit into from

Conversation

Aidyn-A
Copy link
Collaborator

@Aidyn-A Aidyn-A commented Jul 12, 2023

This pull request fixes #33943 for those applications that initialize MPI before init_process_group("mpi", ...) call, including mpi4py, some LibTorch applications and beyond.

@pytorch-bot
Copy link

pytorch-bot bot commented Jul 12, 2023 •
edited

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/105023

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 6f414f8:
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@pytorch-bot pytorch-bot bot added the release notes: distributed (c10d) release notes category label Jul 12, 2023
@Aidyn-A
Copy link
Collaborator Author

Aidyn-A commented Jul 12, 2023

cc @H-Huang

@soulitzer soulitzer added the triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module label Jul 14, 2023
H-Huang
H-Huang approved these changes Jul 14, 2023
View reviewed changes
Copy link
Member

@H-Huang H-Huang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the change, it looks fine to me. We should probably add new tests for MPI as we now have MPI support in some CI jobs

@Aidyn-A
Copy link
Collaborator Author

Aidyn-A commented Jul 14, 2023

@pytorchbot merge

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Jul 14, 2023
@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@H-Huang H-Huang H-Huang approved these changes

@mrshenli mrshenli Awaiting requested review from mrshenli

@zhaojuanmao zhaojuanmao Awaiting requested review from zhaojuanmao

@rohan-varma rohan-varma Awaiting requested review from rohan-varma

@awgu awgu Awaiting requested review from awgu

@kwen2501 kwen2501 Awaiting requested review from kwen2501

@wanchaol wanchaol Awaiting requested review from wanchaol

@fegin fegin Awaiting requested review from fegin

@fduwjj fduwjj Awaiting requested review from fduwjj

@kiukchung kiukchung Awaiting requested review from kiukchung

@d4l3k d4l3k Awaiting requested review from d4l3k

Assignees
No one assigned
Labels
ciflow/trunk Trigger trunk jobs on your pull request Merged open source release notes: distributed (c10d) release notes category triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Continuous Integration of an existing MPI application with Pytorch MPI Backend
5 participants
@Aidyn-A @pytorchmergebot @H-Huang @soulitzer @pytorchbot