[Profiler][Memory] Export raw timestamped events in export_memory_timeline_raw #105094
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/105094
Note: Links to docs will display an error until the docs builds have been completed. ✅ 2 Unrelated FailuresAs of commit 7273bbc: BROKEN TRUNK - The following jobs failed but were present on the merge base e1502c0:👉 Rebase onto the `viable/strict` branch to avoid these failures
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
|
This pull request was exported from Phabricator. Differential Revision: D47416544 |
aaronenyeshi
force-pushed
the
export-D47416544
branch
from
22aa211
to
9fc1d1e
Compare
|
This pull request was exported from Phabricator. Differential Revision: D47416544 |
aaronenyeshi
added a commit
to aaronenyeshi/pytorch
that referenced
this pull request
Jul 13, 2023
…eline_raw (pytorch#105094) Summary: Pull Request resolved: pytorch#105094 Rather than processing the events into a time and sizes plot, dump the actual events as (timestamp, action, num of bytes, category) when output file ends in `raw.json.gz`. This can allow downstream analysis tools to process these events. It also avoids having to control the granularity of the previous json.gz in memory profiler. Test Plan: CI Tests Differential Revision: D47416544 Pulled By: aaronenyeshi fbshipit-source-id: 770fb2dfa10245e17cd90c03e034d44bbf611f71
aaronenyeshi
added a commit
to aaronenyeshi/pytorch
that referenced
this pull request
Jul 13, 2023
…eline_raw (pytorch#105094) Summary: Pull Request resolved: pytorch#105094 Rather than processing the events into a time and sizes plot, dump the actual events as (timestamp, action, num of bytes, category) when output file ends in `raw.json.gz`. This can allow downstream analysis tools to process these events. It also avoids having to control the granularity of the previous json.gz in memory profiler. Test Plan: CI Tests Differential Revision: D47416544 Pulled By: aaronenyeshi fbshipit-source-id: f47fcc3ec7071875a89d20867db2ba14c535c9a0
aaronenyeshi
force-pushed
the
export-D47416544
branch
from
9fc1d1e
to
85dd6b3
Compare
|
This pull request was exported from Phabricator. Differential Revision: D47416544 |
…eline_raw (pytorch#105094) Summary: Pull Request resolved: pytorch#105094 Rather than processing the events into a time and sizes plot, dump the actual events as (timestamp, action, num of bytes, category) when output file ends in `raw.json.gz`. This can allow downstream analysis tools to process these events. It also avoids having to control the granularity of the previous json.gz in memory profiler. Test Plan: CI Tests Differential Revision: D47416544 Pulled By: aaronenyeshi fbshipit-source-id: 33c68192d56218f78300733c0a7b68e876a395d8
aaronenyeshi
force-pushed
the
export-D47416544
branch
from
85dd6b3
to
7273bbc
Compare
|
This pull request was exported from Phabricator. Differential Revision: D47416544 |
davidberard98
approved these changes
Jul 14, 2023
|
@pytorchmergebot merge |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Rather than processing the events into a time and sizes plot, dump the actual events as (timestamp, action, num of bytes, category) when output file ends in
raw.json.gz.This can allow downstream analysis tools to process these events. It also avoids having to control the granularity of the previous json.gz in memory profiler.
Test Plan: CI Tests
Differential Revision: D47416544
Pulled By: aaronenyeshi