Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix aten.logspace decomposition #105201

Closed
wants to merge 11 commits into from
Closed

Fix aten.logspace decomposition #105201

wants to merge 11 commits into from

Conversation

yanboliang
Copy link
Contributor

Fixes #104118

@pytorch-bot
Copy link

pytorch-bot bot commented Jul 14, 2023 •
edited

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/105201

Note: Links to docs will display an error until the docs builds have been completed.

✅ 4 Unrelated Failures

As of commit 61cc978:

UNSTABLE - The following jobs failed but were likely due to flakiness present on trunk and has been marked as unstable:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@yanboliang yanboliang added topic: not user facing topic category ciflow/trunk Trigger trunk jobs on your pull request labels Jul 14, 2023
@yanboliang yanboliang mentioned this pull request Jul 14, 2023
Closed
@soulitzer
Copy link
Contributor

ci failures look real

@yanboliang yanboliang requested a review from ezyang July 22, 2023 00:28
soulitzer
soulitzer reviewed Jul 22, 2023
View reviewed changes
Copy link
Contributor

@soulitzer soulitzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just minor comments

@yanboliang
Copy link
Contributor Author

@pytorchbot merge

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@yanboliang yanboliang deleted the logspace branch July 22, 2023 04:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@soulitzer soulitzer soulitzer left review comments

@ezyang ezyang ezyang approved these changes

@mruberry mruberry Awaiting requested review from mruberry mruberry is a code owner

@ngimel ngimel Awaiting requested review from ngimel

Assignees
No one assigned
Labels
ciflow/trunk Trigger trunk jobs on your pull request Merged topic: not user facing topic category
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[torch.compile] FakeTensorMode not working with torch.logspace on complex arguments
4 participants
@yanboliang @soulitzer @pytorchmergebot @ezyang