Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MPS] Add lerp implementation #105470

Closed
wants to merge 3 commits into from
Closed

[MPS] Add lerp implementation #105470

wants to merge 3 commits into from

Conversation

malfet
Copy link
Contributor

@malfet malfet commented Jul 18, 2023

lerp.Scalar fits very well into binary op template
Add a very naive implementation for lerp.Tensor as add_out(self, weights.mul(end.sub(self)))

Enable lerp testing in test_mps

Fixes #105382

lerp.Scalar fits very well into binary op template
Add a very naive implementation for lerp.Tensor

Enable `lerp` testing in `test_mps`
@malfet malfet requested a review from kulinseth as a code owner July 18, 2023 15:28
@pytorch-bot
Copy link

pytorch-bot bot commented Jul 18, 2023

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/105470

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit d47b05d:
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@pytorch-bot pytorch-bot bot added ciflow/mps Run MPS tests (subset of trunk) release notes: mps Release notes category labels Jul 18, 2023
@malfet malfet requested a review from albanD July 18, 2023 15:28
@malfet malfet added the topic: improvements topic category label Jul 18, 2023
Copy link
Collaborator

@albanD albanD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Const correctness of the structured kernels seems double broken :(
But sounds good to me.

@malfet
Copy link
Contributor Author

malfet commented Jul 18, 2023

@pytorchbot merge -f "Lint + MPS is green"

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@malfet malfet deleted the malfet/mps-add-lerp branch August 2, 2023 02:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ciflow/mps Run MPS tests (subset of trunk) Merged release notes: mps Release notes category topic: improvements topic category
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Need support and testing for Adam optimizer for MPS
3 participants