Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Inductor] aten.dist decomposition #105586

Closed
wants to merge 3 commits into from
Closed

Conversation

@pytorch-bot
Copy link

pytorch-bot bot commented Jul 19, 2023

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/105586

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit d9b2907:
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@yanboliang yanboliang added the ciflow/trunk Trigger trunk jobs on your pull request label Jul 19, 2023
test/inductor/test_torchinductor.py Outdated Show resolved Hide resolved
@yanboliang
Copy link
Contributor Author

@pytorchbot merge

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@@ -630,6 +630,11 @@ def soft_margin_loss_backward(
return grad_input


@register_decomposition(aten.dist)
def dist(input: Tensor, other: Tensor, p: float = 2):
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This would be better suited for a ref, but fine

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was done as part of a brief hackathon, so we were looking for the smallest tasks possible :P

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

aten.dist
5 participants