[ONNX] Diagnostic option 'warnings_as_errors' #105886
Conversation
If set, diagnostics with level as WARNING will be logged as level with ERROR, and immediately raised. TODO: bikeshed public export api. [ghstack-poisoned]
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/105886
Note: Links to docs will display an error until the docs builds have been completed. ❗ 1 Active SEVsThere are 1 currently active SEVs. If your PR is affected, please view them below: ✅ No FailuresAs of commit e1ac710: This comment was automatically generated by Dr. CI and updates every 15 minutes. |
pytorch-bot
bot
added
the
release notes: onnx
If set, diagnostics with level as WARNING will be logged as level with ERROR, and immediately raised. TODO: bikeshed public export api. ghstack-source-id: 3684381362b7a7e78288be0aa189362a93b21cc0 Pull Request resolved: #105886
| diagnostic = diagnostic.with_source_exception(e) | ||
| self.context.log_and_raise_if_error(diagnostic) | ||
|
|
||
| def test_diagnostic_context_raises_if_diagnostic_is_warning_and_warnings_as_errors_is_true( |
There was a problem hiding this comment.
Nice clear test naming 🎉
| ): | ||
| with self.assertRaises(infra.RuntimeErrorWithDiagnostic): | ||
| self.context.options.warnings_as_errors = True | ||
| self.context.log_and_raise_if_error( |
There was a problem hiding this comment.
Do we need to include this part to enable it? How do we use log_and_raise_if_error and option: warnings_as_errors?
There was a problem hiding this comment.
log_and_raise_if_error is used by diagnose_call internally, so for inflight diagnostics if you set its level as warning, and warnings_as_errors is turned on, the inflight diagnostics becomes an error and raises. E.g, if warnings_as_errors is turned on, failed op_level_debug w/ warning diagnostic will automatically become error and raise.
For regular diagnostics, one always need to log them into diagnostic_context. log_and_raise_if_error is the api for that.
warnings_as_errors is a flag under DiagnosticOptions. This is not exposed in export api though, that is left as a follow up to discuss.
Stack from ghstack (oldest at bottom):
If set, diagnostics with level as WARNING will be logged as level
with ERROR, and immediately raised.
TODO: bikeshed public export api.