Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Optimizer state_dict hooks #105953

Closed
wants to merge 9 commits into from
Closed

Add Optimizer state_dict hooks #105953

wants to merge 9 commits into from

Conversation

janeyx99
Copy link
Contributor

@janeyx99 janeyx99 commented Jul 25, 2023 •
edited

Stack from ghstack (oldest at bottom):

@janeyx99 janeyx99 requested a review from albanD as a code owner July 25, 2023 18:50
@pytorch-bot pytorch-bot bot added the release notes: optimizer Relating to optimizers, torch.optim label Jul 25, 2023
@pytorch-bot
Copy link

pytorch-bot bot commented Jul 25, 2023 •
edited

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/105953

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 28e5de6:
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

janeyx99 added a commit that referenced this pull request Jul 25, 2023
@janeyx99
[WIP] add Optimizer state_dict hooks
999445a 
ghstack-source-id: 206e92795a9210990e63679c627e6174f7c1a9d7
Pull Request resolved: #105953
@janeyx99 janeyx99 requested a review from fegin July 25, 2023 19:07
fegin
fegin reviewed Jul 25, 2023
View reviewed changes
torch/optim/optimizer.py Outdated Show resolved Hide resolved
@janeyx99 janeyx99 mentioned this pull request Jul 26, 2023
Closed
janeyx99 added a commit that referenced this pull request Jul 26, 2023
@janeyx99
[WIP] add Optimizer state_dict hooks
ac40cba 
ghstack-source-id: 9706ad0d90becff26fa5cf2be4130bf9152840aa
Pull Request resolved: #105953
janeyx99 added a commit that referenced this pull request Jul 27, 2023
@janeyx99
[WIP] add Optimizer state_dict hooks
973cf03 
ghstack-source-id: 0e74a91dcc186d97dcdc76b308f3634bd18171fb
Pull Request resolved: #105953
janeyx99 added a commit that referenced this pull request Jul 27, 2023
@janeyx99
[WIP] add Optimizer state_dict hooks
9cdd39f 
ghstack-source-id: 10f4a312fde0e1cd9941567a5449c629e408a985
Pull Request resolved: #105953
janeyx99 added a commit that referenced this pull request Jul 27, 2023
@janeyx99
add Optimizer state_dict hooks
5ec9e53 
ghstack-source-id: 8c738fa95483b9935c6ecf11907e6feead378b14
Pull Request resolved: #105953
@janeyx99 janeyx99 changed the title [WIP] add Optimizer state_dict hooks Add Optimizer state_dict hooks Jul 27, 2023
@janeyx99 janeyx99 added topic: new features topic category suppress-bc-linter Suppresses the failures of API backward-compatibility linter (Lint/bc_linter) labels Jul 27, 2023
@janeyx99
Copy link
Contributor Author

Suppressing bc-linter cuz the warning is actually not a real concern. StateDict is the same thing as Dict[str, Any]

image

@janeyx99 janeyx99 mentioned this pull request Jul 27, 2023
Open
albanD
albanD reviewed Jul 27, 2023
View reviewed changes
torch/optim/optimizer.py Outdated Show resolved Hide resolved
torch/optim/optimizer.py Outdated Show resolved Hide resolved
torch/optim/optimizer.py Outdated Show resolved Hide resolved
torch/optim/optimizer.py Outdated Show resolved Hide resolved
torch/optim/optimizer.py Outdated Show resolved Hide resolved
torch/optim/optimizer.py Outdated Show resolved Hide resolved
janeyx99 added a commit that referenced this pull request Jul 27, 2023
@janeyx99
add Optimizer state_dict hooks
96f8142 
ghstack-source-id: e7d59e4067b26aa1b3c2788d8342ceec6e8f8b27
Pull Request resolved: #105953
@janeyx99 janeyx99 mentioned this pull request Jul 26, 2023
Open
janeyx99 added a commit that referenced this pull request Jul 27, 2023
@janeyx99
add Optimizer state_dict hooks
70f0c34 
ghstack-source-id: 81ca88876c57bdd02db2b4cce56fac61b3d77749
Pull Request resolved: #105953
janeyx99 added a commit that referenced this pull request Jul 27, 2023
@janeyx99
add Optimizer state_dict hooks
4e3f1b0 
ghstack-source-id: c2b2d7362fbade90c51788dae781932e017b52ac
Pull Request resolved: #105953
albanD
albanD approved these changes Jul 27, 2023
View reviewed changes
Copy link
Collaborator

@albanD albanD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SGTM!

torch/optim/optimizer.py Outdated Show resolved Hide resolved
janeyx99 added a commit that referenced this pull request Jul 27, 2023
@janeyx99
add Optimizer state_dict hooks
2b848c1 
ghstack-source-id: 620bac6defa1cf2d1d51b91d3b293f4cc5ac265b
Pull Request resolved: #105953
@janeyx99
Copy link
Contributor Author

@pytorchbot merge

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Jul 27, 2023
@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@pytorchmergebot
Copy link
Collaborator

Merge failed

Reason: 3 jobs have failed, first few of them are: trunk / macos-12-py3-arm64 / test (default, 1, 3, macos-m1-12), trunk / macos-12-py3-arm64 / test (default, 2, 3, macos-m1-12), trunk / macos-12-py3-arm64-mps / test (default, 1, 1)

Details for Dev Infra team Raised by workflow job

@janeyx99
Copy link
Contributor Author

@pytorchbot merge -i

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged while ignoring the following 3 checks: trunk / macos-12-py3-arm64 / test (default, 1, 3, macos-m1-12), trunk / macos-12-py3-arm64 / test (default, 2, 3, macos-m1-12), trunk / macos-12-py3-arm64-mps / test (default, 1, 1)

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@pytorchmergebot
Copy link
Collaborator

The merge job was canceled. If you believe this is a mistake,then you can re trigger it through pytorch-bot.

@janeyx99
Copy link
Contributor Author

@pytorchbot merge

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

bobby-palmer pushed a commit to bobby-palmer/pytorch that referenced this pull request Jul 29, 2023
@janeyx99 @bobby-palmer
Add Optimizer state_dict hooks (pytorch#105953)
c3aa2ea 
Pull Request resolved: pytorch#105953
Approved by: https://github.com/albanD
@facebook-github-bot facebook-github-bot deleted the gh/janeyx99/75/head branch July 31, 2023 14:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fegin fegin fegin left review comments

@albanD albanD albanD approved these changes

Assignees
No one assigned
Labels
ciflow/trunk Trigger trunk jobs on your pull request Merged release notes: optimizer Relating to optimizers, torch.optim suppress-bc-linter Suppresses the failures of API backward-compatibility linter (Lint/bc_linter) topic: new features topic category
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@janeyx99 @pytorchmergebot @fegin @albanD