sparse.mm.backward: fix for non-contiguous grad values on CPU #106127
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[ghstack-poisoned]
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/106127
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 596c378: This comment was automatically generated by Dr. CI and updates every 15 minutes. |
nikitaved
added a commit
that referenced
this pull request
Jul 27, 2023
ghstack-source-id: bfd5b612a65f91ef50a03bf35ad9d87aa8f9f3fc Pull Request resolved: #106127
…CPU" [ghstack-poisoned]
nikitaved
added a commit
that referenced
this pull request
Jul 27, 2023
ghstack-source-id: 0763a7a1591633bb1f0af595610887b9070b9f9c Pull Request resolved: #106127
nikitaved
commented
Jul 27, 2023
Comment on lines
109
to
113
| typename index_t_ptr::value_type Cp[], | ||
| // NOLINTNEXTLINE(modernize-avoid-c-arrays,cppcoreguidelines-avoid-c-arrays) | ||
| int64_t Cj[], | ||
| typename index_t_ptr::value_type Cj[], | ||
| // NOLINTNEXTLINE(modernize-avoid-c-arrays,cppcoreguidelines-avoid-c-arrays) | ||
| scalar_t Cx[]) { | ||
| typename scalar_t_ptr::value_type Cx[]) { |
There was a problem hiding this comment.
Let's probably not assume that C-arrays are always contiguous...
EDIT: not needed. This function is used in a single place, and only receives contiguous output.
nikitaved
added a commit
that referenced
this pull request
Jul 27, 2023
ghstack-source-id: aaf13ecfaef31d33b6ff858985e692f3fc392907 Pull Request resolved: #106127
nikitaved
added
module: sparse
|
@pytorchbot merge -i |
Merge startedYour change will be merged while ignoring the following 0 checks: Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
bobby-palmer
pushed a commit
to bobby-palmer/pytorch
that referenced
this pull request
Jul 29, 2023
…h#106127) Fixes pytorch#102493. The problem was that the backward implementation assumed inputs to be contiguous. This might supersede pytorch#104520. Pull Request resolved: pytorch#106127 Approved by: https://github.com/cpuhrsch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #102493.
The problem was that the backward implementation assumed inputs to be contiguous.
This might supersede #104520.
Stack from ghstack (oldest at bottom):
cc @alexsamardzic @pearu @cpuhrsch @amjames @bhosmer @jgong5 @mingfeima @XiaobingSuper @sanchitintel @ashokei @jingxu10