Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[pt2] add meta for ormqr #106278

Closed
wants to merge 2 commits into from

Conversation

nkaretnikov
Copy link
Collaborator

@nkaretnikov nkaretnikov commented Jul 30, 2023

Stack from ghstack (oldest at bottom):

[ghstack-poisoned]
@pytorch-bot
Copy link

pytorch-bot bot commented Jul 30, 2023

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/106278

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 510a5bc:
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

nkaretnikov added a commit that referenced this pull request Jul 30, 2023
ghstack-source-id: fbff1e0b23bbb25e31b2339c1c67c2fa0b29205c
Pull Request resolved: #106278
@nkaretnikov
Copy link
Collaborator Author

From the list in #105105

stride=make_contiguous_strides_for(other.shape, row_major=False),
dtype=other.dtype,
device=other.device,
)
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is very similar to linalg_householder_product meta.

nkaretnikov added a commit that referenced this pull request Jul 30, 2023
ghstack-source-id: ed3d64857af0206ea878dc253411c7ef75ddb797
Pull Request resolved: #106278
@nkaretnikov nkaretnikov added ciflow/trunk Trigger trunk jobs on your pull request topic: not user facing topic category ciflow/inductor labels Jul 30, 2023
@nkaretnikov
Copy link
Collaborator Author

@pytorchbot rebase

@pytorchmergebot
Copy link
Collaborator

@pytorchbot started a rebase job onto refs/remotes/origin/viable/strict. Check the current status here

@pytorchmergebot
Copy link
Collaborator

Tried to rebase and push PR #106278, but it was already up to date. Try rebasing against main by issuing:
@pytorchbot rebase -b main

@nkaretnikov nkaretnikov marked this pull request as ready for review July 31, 2023 14:56
@nkaretnikov
Copy link
Collaborator Author

@pytorchbot merge

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@facebook-github-bot facebook-github-bot deleted the gh/nkaretnikov/163/head branch August 4, 2023 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ciflow/inductor ciflow/trunk Trigger trunk jobs on your pull request Merged open source topic: not user facing topic category
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants