Add support for edge dialect ops in exir/serde #106371
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/106371
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 46ac7ca: This comment was automatically generated by Dr. CI and updates every 15 minutes. |
|
This pull request was exported from Phabricator. Differential Revision: D47938280 |
This PR needs a
|
angelayi
approved these changes
Aug 1, 2023
tarun292
force-pushed
the
export-D47938280
branch
from
485af35
to
fffd17d
Compare
tarun292
added a commit
to tarun292/pytorch
that referenced
this pull request
Aug 1, 2023
Summary: Pull Request resolved: pytorch#106371 Adding support for edge dialect ops in `exir/serde`. This diff does the following: - Moves the global `serialize_operator/deserialize_operator` implementations in`export/serde/serialize.py` into `GraphModuleSerializer` and `GraphModuleDeserializer` - Adds implementations of `serialize_operator/deserialize_operator` inside `GraphModuleSerializer` and `GraphModuleDeserializer` in `exir/serde/serialize.py` Test Plan: CI + Enabled edge dialect ops in `executorch/exir/tests/test_serde.py` Reviewed By: angelayi Differential Revision: D47938280 fbshipit-source-id: 50bc1fc4c92d04b1f6bdd25058ffcf057a2e5347
|
This pull request was exported from Phabricator. Differential Revision: D47938280 |
tarun292
added a commit
to tarun292/pytorch
that referenced
this pull request
Aug 1, 2023
Summary: Pull Request resolved: pytorch#106371 Adding support for edge dialect ops in `exir/serde`. This diff does the following: - Moves the global `serialize_operator/deserialize_operator` implementations in`export/serde/serialize.py` into `GraphModuleSerializer` and `GraphModuleDeserializer` - Adds implementations of `serialize_operator/deserialize_operator` inside `GraphModuleSerializer` and `GraphModuleDeserializer` in `exir/serde/serialize.py` Test Plan: CI + Enabled edge dialect ops in `executorch/exir/tests/test_serde.py` Reviewed By: angelayi Differential Revision: D47938280 fbshipit-source-id: d290aeee2c49c504fab15ccd0f3b43ced321015c
tarun292
force-pushed
the
export-D47938280
branch
from
fffd17d
to
d69d24e
Compare
|
This pull request was exported from Phabricator. Differential Revision: D47938280 |
1 similar comment
|
This pull request was exported from Phabricator. Differential Revision: D47938280 |
tarun292
force-pushed
the
export-D47938280
branch
from
d69d24e
to
3510de6
Compare
tarun292
added a commit
to tarun292/pytorch
that referenced
this pull request
Aug 1, 2023
Summary: Pull Request resolved: pytorch#106371 Adding support for edge dialect ops in `exir/serde`. This diff does the following: - Moves the global `serialize_operator/deserialize_operator` implementations in`export/serde/serialize.py` into `GraphModuleSerializer` and `GraphModuleDeserializer` - Adds implementations of `serialize_operator/deserialize_operator` inside `GraphModuleSerializer` and `GraphModuleDeserializer` in `exir/serde/serialize.py` Test Plan: CI + Enabled edge dialect ops in `executorch/exir/tests/test_serde.py` Reviewed By: chakriu, angelayi Differential Revision: D47938280 fbshipit-source-id: cf1bb785db5171c9f9bc2c21499f7d9d5bd101a9
tarun292
added a commit
to tarun292/pytorch
that referenced
this pull request
Aug 1, 2023
Summary: Pull Request resolved: pytorch#106371 Adding support for edge dialect ops in `exir/serde`. This diff does the following: - Moves the global `serialize_operator/deserialize_operator` implementations in`export/serde/serialize.py` into `GraphModuleSerializer` and `GraphModuleDeserializer` - Adds implementations of `serialize_operator/deserialize_operator` inside `GraphModuleSerializer` and `GraphModuleDeserializer` in `exir/serde/serialize.py` Test Plan: CI + Enabled edge dialect ops in `executorch/exir/tests/test_serde.py` Reviewed By: chakriu, angelayi Differential Revision: D47938280 fbshipit-source-id: aaa73ff98cc1bb32a495a44d8cbf8ecb97335327
tarun292
force-pushed
the
export-D47938280
branch
from
3510de6
to
43c9899
Compare
|
This pull request was exported from Phabricator. Differential Revision: D47938280 |
tarun292
force-pushed
the
export-D47938280
branch
from
43c9899
to
8fea473
Compare
tarun292
added a commit
to tarun292/pytorch
that referenced
this pull request
Aug 1, 2023
Summary: Pull Request resolved: pytorch#106371 Adding support for edge dialect ops in `exir/serde`. This diff does the following: - Moves the global `serialize_operator/deserialize_operator` implementations in`export/serde/serialize.py` into `GraphModuleSerializer` and `GraphModuleDeserializer` - Adds implementations of `serialize_operator/deserialize_operator` inside `GraphModuleSerializer` and `GraphModuleDeserializer` in `exir/serde/serialize.py` Test Plan: CI + Enabled edge dialect ops in `executorch/exir/tests/test_serde.py` Reviewed By: chakriu, angelayi Differential Revision: D47938280 fbshipit-source-id: a20f3e7441142bf84a0d0f44cba250148b5e5885
|
This pull request was exported from Phabricator. Differential Revision: D47938280 |
tarun292
force-pushed
the
export-D47938280
branch
from
8fea473
to
ea8946f
Compare
tarun292
added a commit
to tarun292/pytorch
that referenced
this pull request
Aug 1, 2023
Summary: Pull Request resolved: pytorch#106371 Adding support for edge dialect ops in `exir/serde`. This diff does the following: - Moves the global `serialize_operator/deserialize_operator` implementations in`export/serde/serialize.py` into `GraphModuleSerializer` and `GraphModuleDeserializer` - Adds implementations of `serialize_operator/deserialize_operator` inside `GraphModuleSerializer` and `GraphModuleDeserializer` in `exir/serde/serialize.py` Test Plan: CI + Enabled edge dialect ops in `executorch/exir/tests/test_serde.py` Reviewed By: chakriu, angelayi Differential Revision: D47938280 fbshipit-source-id: c16c1f160683142f0ed02fee420ad71cf0e3aee1
|
This pull request was exported from Phabricator. Differential Revision: D47938280 |
tarun292
added a commit
to tarun292/pytorch
that referenced
this pull request
Aug 1, 2023
Summary: Pull Request resolved: pytorch#106371 Adding support for edge dialect ops in `exir/serde`. This diff does the following: - Moves the global `serialize_operator/deserialize_operator` implementations in`export/serde/serialize.py` into `GraphModuleSerializer` and `GraphModuleDeserializer` - Adds implementations of `serialize_operator/deserialize_operator` inside `GraphModuleSerializer` and `GraphModuleDeserializer` in `exir/serde/serialize.py` Test Plan: CI + Enabled edge dialect ops in `executorch/exir/tests/test_serde.py` Reviewed By: chakriu, angelayi Differential Revision: D47938280 fbshipit-source-id: 2c53855b5c05b6825690b3962a1270b0973edc52
tarun292
force-pushed
the
export-D47938280
branch
from
ea8946f
to
cae51b9
Compare
|
This pull request was exported from Phabricator. Differential Revision: D47938280 |
1 similar comment
|
This pull request was exported from Phabricator. Differential Revision: D47938280 |
tarun292
added a commit
to tarun292/pytorch
that referenced
this pull request
Aug 1, 2023
Summary: Pull Request resolved: pytorch#106371 Adding support for edge dialect ops in `exir/serde`. This diff does the following: - Moves the global `serialize_operator/deserialize_operator` implementations in`export/serde/serialize.py` into `GraphModuleSerializer` and `GraphModuleDeserializer` - Adds implementations of `serialize_operator/deserialize_operator` inside `GraphModuleSerializer` and `GraphModuleDeserializer` in `exir/serde/serialize.py` Test Plan: CI + Enabled edge dialect ops in `executorch/exir/tests/test_serde.py` Reviewed By: chakriu, angelayi Differential Revision: D47938280 fbshipit-source-id: 6028709c60cec4751092395bfe4926b34db26bed
tarun292
force-pushed
the
export-D47938280
branch
from
cae51b9
to
c6d4520
Compare
tarun292
force-pushed
the
export-D47938280
branch
from
c6d4520
to
47d31ff
Compare
tarun292
added a commit
to tarun292/pytorch
that referenced
this pull request
Aug 2, 2023
Summary: Pull Request resolved: pytorch#106371 Adding support for edge dialect ops in `exir/serde`. This diff does the following: - Moves the global `serialize_operator/deserialize_operator` implementations in`export/serde/serialize.py` into `GraphModuleSerializer` and `GraphModuleDeserializer` - Adds implementations of `serialize_operator/deserialize_operator` inside `GraphModuleSerializer` and `GraphModuleDeserializer` in `exir/serde/serialize.py` Test Plan: CI + Enabled edge dialect ops in `executorch/exir/tests/test_serde.py` Reviewed By: chakriu, angelayi Differential Revision: D47938280 fbshipit-source-id: 5f0fad759875ade2fe010a004f9e7809bb4ebc6b
|
This pull request was exported from Phabricator. Differential Revision: D47938280 |
Summary: Pull Request resolved: pytorch#106371 Adding support for edge dialect ops in `exir/serde`. This diff does the following: - Moves the global `serialize_operator/deserialize_operator` implementations in`export/serde/serialize.py` into `GraphModuleSerializer` and `GraphModuleDeserializer` - Adds implementations of `serialize_operator/deserialize_operator` inside `GraphModuleSerializer` and `GraphModuleDeserializer` in `exir/serde/serialize.py` Test Plan: CI + Enabled edge dialect ops in `executorch/exir/tests/test_serde.py` Reviewed By: chakriu, angelayi Differential Revision: D47938280 fbshipit-source-id: 423892a5b85b53c0dbb8a5293da4b1667f33a041
tarun292
force-pushed
the
export-D47938280
branch
from
47d31ff
to
46ac7ca
Compare
|
This pull request was exported from Phabricator. Differential Revision: D47938280 |
facebook-github-bot
pushed a commit
to pytorch/executorch
that referenced
this pull request
Aug 2, 2023
Summary: X-link: pytorch/pytorch#106371 Adding support for edge dialect ops in `exir/serde`. This diff does the following: - Moves the global `serialize_operator/deserialize_operator` implementations in`export/serde/serialize.py` into `GraphModuleSerializer` and `GraphModuleDeserializer` - Adds implementations of `serialize_operator/deserialize_operator` inside `GraphModuleSerializer` and `GraphModuleDeserializer` in `exir/serde/serialize.py` Reviewed By: chakriu, angelayi Differential Revision: D47938280 fbshipit-source-id: 8a8aed65c51d9cc57b4b37499421be971c19d344
|
@pytorchbot merge (Initiating merge automatically since Phabricator Diff has merged) |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Adding support for edge dialect ops in
exir/serde. This diff does the following:serialize_operator/deserialize_operatorimplementations inexport/serde/serialize.pyintoGraphModuleSerializerandGraphModuleDeserializerserialize_operator/deserialize_operatorinsideGraphModuleSerializerandGraphModuleDeserializerinexir/serde/serialize.pyTest Plan: CI + Enabled edge dialect ops in
executorch/exir/tests/test_serde.pyDifferential Revision: D47938280