[inductor] Fix xpasses being impossible #106631
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This test raises an error inside the test when an xfailed test succeeds, but is also decorated with the xfail decorator which converts the error to an xfail. Instead, this lets the test function pass normally and lets the xfail decorator raise "Unexpected success". I also updated the COLLECT_EXPECT code and run it to get the updated set of failures. [ghstack-poisoned]
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/106631
Note: Links to docs will display an error until the docs builds have been completed. ✅ 1 Unrelated FailureAs of commit 7baf76e: UNSTABLE - The following job failed but was likely due to flakiness present on trunk and has been marked as unstable:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
peterbell10
added a commit
that referenced
this pull request
Aug 4, 2023
This test raises an error inside the test when an xfailed test succeeds, but is also decorated with the xfail decorator which converts the error to an xfail. Instead, this lets the test function pass normally and lets the xfail decorator raise "Unexpected success". I also updated the COLLECT_EXPECT code and run it to get the updated set of failures. ghstack-source-id: 4fb34013e249682e1ec2c0a5047788205586de59 Pull Request resolved: #106631
This test raises an error inside the test when an xfailed test succeeds, but is also decorated with the xfail decorator which converts the error to an xfail. Instead, this lets the test function pass normally and lets the xfail decorator raise "Unexpected success". I also updated the COLLECT_EXPECT code and run it to get the updated set of failures. cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng Xia-Weiwen wenzhe-nrv jiayisunx ipiszy ngimel yf225 chenyang78 kadeng muchulee8 aakhundov [ghstack-poisoned]
peterbell10
added a commit
that referenced
this pull request
Aug 4, 2023
This test raises an error inside the test when an xfailed test succeeds, but is also decorated with the xfail decorator which converts the error to an xfail. Instead, this lets the test function pass normally and lets the xfail decorator raise "Unexpected success". I also updated the COLLECT_EXPECT code and run it to get the updated set of failures. ghstack-source-id: b059c82e69f290dc8e6deda0b36aae0f9226383e Pull Request resolved: #106631
This test raises an error inside the test when an xfailed test succeeds, but is also decorated with the xfail decorator which converts the error to an xfail. Instead, this lets the test function pass normally and lets the xfail decorator raise "Unexpected success". I also updated the COLLECT_EXPECT code and run it to get the updated set of failures. cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng Xia-Weiwen wenzhe-nrv jiayisunx ipiszy ngimel yf225 chenyang78 kadeng muchulee8 aakhundov [ghstack-poisoned]
peterbell10
added a commit
that referenced
this pull request
Aug 4, 2023
This test raises an error inside the test when an xfailed test succeeds, but is also decorated with the xfail decorator which converts the error to an xfail. Instead, this lets the test function pass normally and lets the xfail decorator raise "Unexpected success". I also updated the COLLECT_EXPECT code and run it to get the updated set of failures. ghstack-source-id: 84fa27d2f92cd8f8a38dfb4d72dd5bec3a449db1 Pull Request resolved: #106631
peterbell10
added a commit
to peterbell10/pytorch
that referenced
this pull request
Aug 7, 2023
This test raises an error inside the test when an xfailed test succeeds, but is also decorated with the xfail decorator which converts the error to an xfail. Instead, this lets the test function pass normally and lets the xfail decorator raise "Unexpected success". I also updated the COLLECT_EXPECT code and run it to get the updated set of failures. ghstack-source-id: 84fa27d2f92cd8f8a38dfb4d72dd5bec3a449db1 Pull Request resolved: pytorch#106631
This test raises an error inside the test when an xfailed test succeeds, but is also decorated with the xfail decorator which converts the error to an xfail. Instead, this lets the test function pass normally and lets the xfail decorator raise "Unexpected success". I also updated the COLLECT_EXPECT code and run it to get the updated set of failures. cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng Xia-Weiwen wenzhe-nrv jiayisunx ipiszy ngimel yf225 chenyang78 kadeng muchulee8 aakhundov [ghstack-poisoned]
peterbell10
added a commit
that referenced
this pull request
Aug 7, 2023
This test raises an error inside the test when an xfailed test succeeds, but is also decorated with the xfail decorator which converts the error to an xfail. Instead, this lets the test function pass normally and lets the xfail decorator raise "Unexpected success". I also updated the COLLECT_EXPECT code and run it to get the updated set of failures. ghstack-source-id: a227ca2fa19fe10d21ee2028454022a8b1c8ea16 Pull Request resolved: #106631
This test raises an error inside the test when an xfailed test succeeds, but is also decorated with the xfail decorator which converts the error to an xfail. Instead, this lets the test function pass normally and lets the xfail decorator raise "Unexpected success". I also updated the COLLECT_EXPECT code and run it to get the updated set of failures. cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng Xia-Weiwen wenzhe-nrv jiayisunx ipiszy ngimel yf225 chenyang78 kadeng muchulee8 aakhundov [ghstack-poisoned]
peterbell10
added a commit
that referenced
this pull request
Aug 7, 2023
This test raises an error inside the test when an xfailed test succeeds, but is also decorated with the xfail decorator which converts the error to an xfail. Instead, this lets the test function pass normally and lets the xfail decorator raise "Unexpected success". I also updated the COLLECT_EXPECT code and run it to get the updated set of failures. ghstack-source-id: 03e50939c861770171aaf8ecc868342dd0be8d77 Pull Request resolved: #106631
|
@pytorchbot merge |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
Cyril-Anto
pushed a commit
to Cyril-Anto/pytorch
that referenced
this pull request
Aug 17, 2023
This test raises an error inside the test when an xfailed test succeeds, but is also decorated with the xfail decorator which converts the error to an xfail. Instead, this lets the test function pass normally and lets the xfail decorator raise "Unexpected success". I also updated the COLLECT_EXPECT code and run it to get the updated set of failures. Pull Request resolved: pytorch#106631 Approved by: https://github.com/lezcano ghstack dependencies: pytorch#106319, pytorch#106400
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
This test raises an error inside the test when an xfailed test succeeds, but
is also decorated with the xfail decorator which converts the error to an xfail.
Instead, this lets the test function pass normally and lets the xfail decorator
raise "Unexpected success".
I also updated the COLLECT_EXPECT code and run it to get the updated set of
failures.
cc @voznesenskym @penguinwu @EikanWang @jgong5 @Guobing-Chen @XiaobingSuper @zhuhaozhe @blzheng @Xia-Weiwen @wenzhe-nrv @jiayisunx @ipiszy @ngimel @yf225 @chenyang78 @kadeng @muchulee8 @aakhundov