Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reland "Add nn.CircularPad{*}d for consistency + fix no_batch_dim support (#106148)" #106632

Closed
wants to merge 2 commits into from
Closed

Reland "Add nn.CircularPad{*}d for consistency + fix no_batch_dim support (#106148)" #106632

wants to merge 2 commits into from

Commits on Aug 4, 2023

  1. Reland "Add nn.CircularPad{*}d for consistency + fix no_batch_dim sup… 

    …port (#106148)"

[ghstack-poisoned]
    @mikaylagawarecki
    mikaylagawarecki committed Aug 4, 2023
    Configuration menu
    Copy the full SHA
    5c77258 View commit details
    Browse the repository at this point in the history

Commits on Aug 7, 2023

  1. Update on "Reland "Add nn.CircularPad{*}d for consistency + fix no_ba… 

    …tch_dim support (#106148)""

Previous one was reverted because the PR stacked under which added error-checking to Pad variants #106147 was reverted as internally some people pass 2D inputs to ZeroPad2d (which should actually take 3d or 4d inputs :) but there wasn't actually anything this PR was breaking according to my understanding




[ghstack-poisoned]
    @mikaylagawarecki
    mikaylagawarecki committed Aug 7, 2023
    Configuration menu
    Copy the full SHA
    fa5ddc3 View commit details
    Browse the repository at this point in the history