[pytorch][ao] force weight observer/fake_quant to be on the same device as the weight tensor #106755
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/106755
Note: Links to docs will display an error until the docs builds have been completed. ⏳ 5 Pending, 1 Unrelated FailureAs of commit d40910b: UNSTABLE - The following job failed but was likely due to flakiness present on trunk and has been marked as unstable:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
|
This pull request was exported from Phabricator. Differential Revision: D48141494 |
jiaxuzhu92
force-pushed
the
export-D48141494
branch
from
93bfecd
to
2e00d76
Compare
jiaxuzhu92
added a commit
to jiaxuzhu92/pytorch
that referenced
this pull request
Aug 8, 2023
…ce as the weight tensor (pytorch#106755) Summary: Pull Request resolved: pytorch#106755 As title. There's a corner case where both cpu and gpu are avaiable, although the model is moved to cpu, the newly created PTQ weight observer is still on gpu. Therefore, during the convert, this line will fail https://fburl.com/4rhipfvb Test Plan: CI Differential Revision: D48141494 fbshipit-source-id: 8736e84a6242e18edde862408f11c9d3f8c5b4d3
|
This pull request was exported from Phabricator. Differential Revision: D48141494 |
1 similar comment
|
This pull request was exported from Phabricator. Differential Revision: D48141494 |
jiaxuzhu92
added a commit
to jiaxuzhu92/pytorch
that referenced
this pull request
Aug 8, 2023
…ce as the weight tensor (pytorch#106755) Summary: Pull Request resolved: pytorch#106755 As title. There's a corner case where both cpu and gpu are avaiable, although the model is moved to cpu, the newly created PTQ weight observer is still on gpu. Therefore, during the convert, this line will fail https://fburl.com/4rhipfvb Test Plan: CI Differential Revision: D48141494 fbshipit-source-id: 20fb08ff11d76654308645d6f5aec51b1636faf6
jiaxuzhu92
force-pushed
the
export-D48141494
branch
from
2e00d76
to
10e219d
Compare
…ce as the weight tensor (pytorch#106755) Summary: Pull Request resolved: pytorch#106755 As title. There's a corner case where both cpu and gpu are avaiable, although the model is moved to cpu, the newly created PTQ weight observer is still on gpu. Therefore, during the convert, this line will fail https://fburl.com/4rhipfvb Test Plan: CI Reviewed By: jerryzh168 Differential Revision: D48141494 fbshipit-source-id: 16e696f8bd001e51094be3bfca3ef0fd85d0c5c8
jiaxuzhu92
force-pushed
the
export-D48141494
branch
from
10e219d
to
d40910b
Compare
|
This pull request was exported from Phabricator. Differential Revision: D48141494 |
jerryzh168
approved these changes
Aug 8, 2023
|
@pytorchbot merge |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
Cyril-Anto
pushed a commit
to Cyril-Anto/pytorch
that referenced
this pull request
Aug 17, 2023
…ce as the weight tensor (pytorch#106755) Summary: As title. There's a corner case where both cpu and gpu are avaiable, although the model is moved to cpu, the newly created PTQ weight observer is still on gpu. Therefore, during the convert, this line will fail https://fburl.com/4rhipfvb Test Plan: CI Differential Revision: D48141494 Pull Request resolved: pytorch#106755 Approved by: https://github.com/jerryzh168
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
As title.
There's a corner case where both cpu and gpu are avaiable, although the model is moved to cpu, the newly created PTQ weight observer is still on gpu. Therefore, during the convert, this line will fail https://fburl.com/4rhipfvb
Test Plan: CI
Differential Revision: D48141494