`asarray`: take the default device into consideration. #106779

ysiraichi · 2023-08-08T13:29:06Z

Stack from ghstack (oldest at bottom):

-> asarray: take the default device into consideration. #106779

This PR makes it so asarray takes the default device into consideration when called with
a Python sequence as the data.

Fix: #106773 This PR makes it so `asarray` takes the default device into consideration when called with a Python sequence as the data. [ghstack-poisoned]

pytorch-bot · 2023-08-08T13:29:09Z

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/106779

📄 Preview Python docs built from this PR
📄 Preview C++ docs built from this PR
❓ Need help or want to give feedback on the CI? Visit the bot commands wiki or our office hours

Note: Links to docs will display an error until the docs builds have been completed.

❗ 1 Active SEVs

There are 1 currently active SEVs. If your PR is affected, please view them below:

ROCm CI upgrade in progress

✅ 2 Unrelated Failures

As of commit 4e4abe5:

UNSTABLE - The following jobs failed but were likely due to flakiness present on trunk and has been marked as unstable:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

Fix: #106773 This PR makes it so `asarray` takes the default device into consideration when called with a Python sequence as the data. ghstack-source-id: 92adeacccc0cfadb8268996a2e8a784c254debed Pull Request resolved: #106779

…ation." Fix: #106773 This PR makes it so `asarray` takes the default device into consideration when called with a Python sequence as the data. [ghstack-poisoned]

Fix: #106773 This PR makes it so `asarray` takes the default device into consideration when called with a Python sequence as the data. ghstack-source-id: 12fa2061ec04816b0c0d9a473265651f226ef513 Pull Request resolved: #106779

Fix: #106773 This PR makes it so `asarray` takes the default device into consideration when called with a Python sequence as the data. [ghstack-poisoned]

Fix: #106773 This PR makes it so `asarray` takes the default device into consideration when called with a Python sequence as the data. ghstack-source-id: 50f80e40e925bea99b38448622cf2f4ca9291983 Pull Request resolved: #106779

…ce into consideration." Fix: #106773 This PR makes it so `asarray` takes the default device into consideration when called with a Python sequence as the data. [ghstack-poisoned]

Fix: #106773 This PR makes it so `asarray` takes the default device into consideration when called with a Python sequence as the data. ghstack-source-id: 5da66d04339a5c3e13ca9d833f06821bf74bf019 Pull Request resolved: #106779

Fix: #106773 This PR makes it so `asarray` takes the default device into consideration when called with a Python sequence as the data. [ghstack-poisoned]

Fix: #106773 This PR makes it so `asarray` takes the default device into consideration when called with a Python sequence as the data. ghstack-source-id: 20b11f284198b1ba80facaa977c4e2cd13a0c606 Pull Request resolved: #106779

rgommers

LGTM, thanks for the quick fix @ysiraichi!

rgommers · 2023-08-08T19:59:14Z

test/test_tensor_creation_ops.py

+            3,
+            np.arange(5),
+            torch.arange(5),
+            array.array("f", [1, 2, 3, 4]),


very minor: "f" means this constructs a floating-point number. which is tested for exact equality below; using "i" for integers may be a little more robust (however, tests seem happy, so feel free to ignore this comment)

Ah, you are right. I used "f" here because I could just call asarray without any arguments (otherwise I had to pass the dtype). But, I guess that's more robust. Will change.

…nsideration." Fix: #106773 This PR makes it so `asarray` takes the default device into consideration when called with a Python sequence as the data. [ghstack-poisoned]

Fix: #106773 This PR makes it so `asarray` takes the default device into consideration when called with a Python sequence as the data. ghstack-source-id: 0552a22c3828d69fcc3ce93c5fe44d6326f7de50 Pull Request resolved: #106779

ysiraichi · 2023-08-09T18:37:28Z

@pytorchbot merge

pytorchmergebot · 2023-08-09T18:39:13Z

Merge failed

Reason: This PR needs a release notes: label
If your changes are user facing and intended to be a part of release notes, please use a label starting with release notes:.

If not, please add the topic: not user facing label.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "topic: not user facing"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

Details for Dev Infra team

Raised by workflow job

Fix: #106773 This PR makes it so `asarray` takes the default device into consideration when called with a Python sequence as the data. [ghstack-poisoned]

Fix: #106773 This PR makes it so `asarray` takes the default device into consideration when called with a Python sequence as the data. ghstack-source-id: b4083530905e659983db72dab81eadbc8172ead9 Pull Request resolved: #106779

ysiraichi · 2023-08-11T13:13:58Z

CI failures are not related.

ysiraichi · 2023-08-11T13:14:06Z

@pytorchbot merge

pytorchmergebot · 2023-08-11T13:16:37Z

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging

Check the merge workflow status
here

asarray: take the default device into consideration.

9016c72

Fix: #106773 This PR makes it so `asarray` takes the default device into consideration when called with a Python sequence as the data. [ghstack-poisoned]

Fix lint issues. on "asarray: take the default device into consider…

313138e

…ation." Fix: #106773 This PR makes it so `asarray` takes the default device into consideration when called with a Python sequence as the data. [ghstack-poisoned]

Update on "asarray: take the default device into consideration."

af47933

Fix: #106773 This PR makes it so `asarray` takes the default device into consideration when called with a Python sequence as the data. [ghstack-poisoned]

ysiraichi requested review from albanD and soulitzer as code owners August 8, 2023 15:48

Revert change in implementation. on "asarray: take the default devi…

af3ef62

…ce into consideration." Fix: #106773 This PR makes it so `asarray` takes the default device into consideration when called with a Python sequence as the data. [ghstack-poisoned]

pytorchbot added the open source label Aug 8, 2023

Add tests. on "asarray: take the default device into consideration."

8929618

Fix: #106773 This PR makes it so `asarray` takes the default device into consideration when called with a Python sequence as the data. [ghstack-poisoned]

ysiraichi requested review from rgommers and lezcano August 8, 2023 18:49

rgommers approved these changes Aug 8, 2023

View reviewed changes

lezcano approved these changes Aug 8, 2023

View reviewed changes

Make test more robust. on "asarray: take the default device into co…

7da5b6c

…nsideration." Fix: #106773 This PR makes it so `asarray` takes the default device into consideration when called with a Python sequence as the data. [ghstack-poisoned]

pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Aug 9, 2023

pytorchmergebot added the merging label Aug 9, 2023

pytorchmergebot removed the merging label Aug 9, 2023

ysiraichi added the release notes: python_frontend release notes category label Aug 9, 2023

Rebased. on "asarray: take the default device into consideration."

4e4abe5

Fix: #106773 This PR makes it so `asarray` takes the default device into consideration when called with a Python sequence as the data. [ghstack-poisoned]

pytorchmergebot added the merging label Aug 11, 2023

pytorchmergebot added Merged and removed merging labels Aug 11, 2023

pytorchmergebot closed this in a5d841e Aug 11, 2023

facebook-github-bot deleted the gh/ysiraichi/77/head branch August 14, 2023 14:17

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

`asarray`: take the default device into consideration. #106779

`asarray`: take the default device into consideration. #106779

ysiraichi commented Aug 8, 2023 •

edited

pytorch-bot bot commented Aug 8, 2023 •

edited

rgommers left a comment

rgommers Aug 8, 2023

ysiraichi Aug 9, 2023 •

edited

ysiraichi commented Aug 9, 2023

pytorchmergebot commented Aug 9, 2023

ysiraichi commented Aug 11, 2023

ysiraichi commented Aug 11, 2023

pytorchmergebot commented Aug 11, 2023

asarray: take the default device into consideration. #106779

asarray: take the default device into consideration. #106779

Conversation

ysiraichi commented Aug 8, 2023 • edited

pytorch-bot bot commented Aug 8, 2023 • edited

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/106779

❗ 1 Active SEVs

✅ 2 Unrelated Failures

rgommers left a comment

Choose a reason for hiding this comment

rgommers Aug 8, 2023

Choose a reason for hiding this comment

ysiraichi Aug 9, 2023 • edited

Choose a reason for hiding this comment

ysiraichi commented Aug 9, 2023

pytorchmergebot commented Aug 9, 2023

Merge failed

ysiraichi commented Aug 11, 2023

ysiraichi commented Aug 11, 2023

pytorchmergebot commented Aug 11, 2023

Merge started

`asarray`: take the default device into consideration. #106779

`asarray`: take the default device into consideration. #106779

ysiraichi commented Aug 8, 2023 •

edited

pytorch-bot bot commented Aug 8, 2023 •

edited

ysiraichi Aug 9, 2023 •

edited