-
Notifications
You must be signed in to change notification settings - Fork 21.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use expect_true to make split with unbacked sizes work. #106788
Commits on Aug 8, 2023
-
Use expect_true to make split with unbacked sizes work.
This pattern shows up in torchrec KeyedJaggedTensor. Most of the change in this PR is mechanical: whenever we failed an unbacked symint test due to just error checking, replace the conditional with something that calls expect_true (e.g., torch._check or TORCH_SYM_CHECK). Some of the changes are a bit more nuanced, I've commented on the PR accordingly. Signed-off-by: Edward Z. Yang <ezyang@meta.com> [ghstack-poisoned]
Configuration menu - View commit details
-
Copy full SHA for 1dfa588 - Browse repository at this point
Copy the full SHA 1dfa588View commit details -
Update on "Use expect_true to make split with unbacked sizes work."
This pattern shows up in torchrec KeyedJaggedTensor. Most of the change in this PR is mechanical: whenever we failed an unbacked symint test due to just error checking, replace the conditional with something that calls expect_true (e.g., torch._check or TORCH_SYM_CHECK). Some of the changes are a bit more nuanced, I've commented on the PR accordingly. Signed-off-by: Edward Z. Yang <ezyangmeta.com> [ghstack-poisoned]
Configuration menu - View commit details
-
Copy full SHA for 2c7bd27 - Browse repository at this point
Copy the full SHA 2c7bd27View commit details -
Update on "Use expect_true to make split with unbacked sizes work."
This pattern shows up in torchrec KeyedJaggedTensor. Most of the change in this PR is mechanical: whenever we failed an unbacked symint test due to just error checking, replace the conditional with something that calls expect_true (e.g., torch._check or TORCH_SYM_CHECK). Some of the changes are a bit more nuanced, I've commented on the PR accordingly. Signed-off-by: Edward Z. Yang <ezyangmeta.com> [ghstack-poisoned]
Configuration menu - View commit details
-
Copy full SHA for 2c5497d - Browse repository at this point
Copy the full SHA 2c5497dView commit details
Commits on Aug 9, 2023
-
Update on "Use expect_true to make split with unbacked sizes work."
This pattern shows up in torchrec KeyedJaggedTensor. Most of the change in this PR is mechanical: whenever we failed an unbacked symint test due to just error checking, replace the conditional with something that calls expect_true (e.g., torch._check or TORCH_SYM_CHECK). Some of the changes are a bit more nuanced, I've commented on the PR accordingly. Signed-off-by: Edward Z. Yang <ezyangmeta.com> [ghstack-poisoned]
Configuration menu - View commit details
-
Copy full SHA for 1804469 - Browse repository at this point
Copy the full SHA 1804469View commit details
Commits on Aug 14, 2023
-
Update on "Use expect_true to make split with unbacked sizes work."
This pattern shows up in torchrec KeyedJaggedTensor. Most of the change in this PR is mechanical: whenever we failed an unbacked symint test due to just error checking, replace the conditional with something that calls expect_true (e.g., torch._check or TORCH_SYM_CHECK). Some of the changes are a bit more nuanced, I've commented on the PR accordingly. Signed-off-by: Edward Z. Yang <ezyangmeta.com> cc voznesenskym penguinwu anijain2305 EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng Xia-Weiwen wenzhe-nrv jiayisunx ipiszy chenyang78 aakhundov [ghstack-poisoned]
Configuration menu - View commit details
-
Copy full SHA for bed9199 - Browse repository at this point
Copy the full SHA bed9199View commit details -
Update on "Use expect_true to make split with unbacked sizes work."
This pattern shows up in torchrec KeyedJaggedTensor. Most of the change in this PR is mechanical: whenever we failed an unbacked symint test due to just error checking, replace the conditional with something that calls expect_true (e.g., torch._check or TORCH_SYM_CHECK). Some of the changes are a bit more nuanced, I've commented on the PR accordingly. Signed-off-by: Edward Z. Yang <ezyangmeta.com> cc voznesenskym penguinwu anijain2305 EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng Xia-Weiwen wenzhe-nrv jiayisunx ipiszy chenyang78 aakhundov [ghstack-poisoned]
Configuration menu - View commit details
-
Copy full SHA for eb80f6b - Browse repository at this point
Copy the full SHA eb80f6bView commit details
Commits on Aug 15, 2023
-
Update on "Use expect_true to make split with unbacked sizes work."
This pattern shows up in torchrec KeyedJaggedTensor. Most of the change in this PR is mechanical: whenever we failed an unbacked symint test due to just error checking, replace the conditional with something that calls expect_true (e.g., torch._check or TORCH_SYM_CHECK). Some of the changes are a bit more nuanced, I've commented on the PR accordingly. Signed-off-by: Edward Z. Yang <ezyangmeta.com> cc voznesenskym penguinwu anijain2305 EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng Xia-Weiwen wenzhe-nrv jiayisunx ipiszy chenyang78 aakhundov [ghstack-poisoned]
Configuration menu - View commit details
-
Copy full SHA for 41ce97c - Browse repository at this point
Copy the full SHA 41ce97cView commit details -
Update on "Use expect_true to make split with unbacked sizes work."
This pattern shows up in torchrec KeyedJaggedTensor. Most of the change in this PR is mechanical: whenever we failed an unbacked symint test due to just error checking, replace the conditional with something that calls expect_true (e.g., torch._check or TORCH_SYM_CHECK). Some of the changes are a bit more nuanced, I've commented on the PR accordingly. Signed-off-by: Edward Z. Yang <ezyangmeta.com> cc voznesenskym penguinwu anijain2305 EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng Xia-Weiwen wenzhe-nrv jiayisunx ipiszy chenyang78 aakhundov [ghstack-poisoned]
Configuration menu - View commit details
-
Copy full SHA for 0526cb2 - Browse repository at this point
Copy the full SHA 0526cb2View commit details