Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP] Force KJT list inputs to be unbacked ints #107156

Closed
wants to merge 3 commits into from
Closed

[WIP] Force KJT list inputs to be unbacked ints #107156

wants to merge 3 commits into from

Conversation

ezyang
Copy link
Contributor

@ezyang ezyang commented Aug 14, 2023 •
edited

@ezyang
WIP
0f6bcce 
Signed-off-by: Edward Z. Yang <ezyang@meta.com>

[ghstack-poisoned]
@ezyang ezyang mentioned this pull request Aug 14, 2023
Closed
@pytorch-bot
Copy link

pytorch-bot bot commented Aug 14, 2023 •
edited

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/107156

Note: Links to docs will display an error until the docs builds have been completed.

❌ 68 New Failures, 2 Unrelated Failures

As of commit ce4f67b:

NEW FAILURES - The following jobs have failed:

FLAKY - The following job failed but was likely due to flakiness present on trunk:

UNSTABLE - The following job failed but was likely due to flakiness present on trunk and has been marked as unstable:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@ezyang ezyang mentioned this pull request Aug 14, 2023
Closed
ezyang added a commit that referenced this pull request Aug 14, 2023
@ezyang
WIP
31a5aa2 
Signed-off-by: Edward Z. Yang <ezyangmeta.com>

ghstack-source-id: 20ccb8b5170763585e3a65d16a581169625fbdd9
Pull Request resolved: #107156
@albanD albanD removed their request for review August 14, 2023 18:38
@ezyang
Update on "WIP"
1f79513 
Signed-off-by: Edward Z. Yang <ezyangmeta.com>

cc voznesenskym penguinwu anijain2305 EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng Xia-Weiwen wenzhe-nrv jiayisunx ipiszy chenyang78 aakhundov

[ghstack-poisoned]
ezyang added a commit that referenced this pull request Aug 15, 2023
@ezyang
Force KJT list inputs to be unbacked ints.
bb54f58 
Signed-off-by: Edward Z. Yang <ezyangmeta.com>

ghstack-source-id: e0ab2b4c20ea4a979b814a2fae7d398e6e67f833
Pull Request resolved: #107156
@ezyang ezyang changed the title WIP [WIP] Force KJT list inputs to be unbacked ints Aug 15, 2023
@ezyang
Update on "[WIP] Force KJT list inputs to be unbacked ints"
ce4f67b 
This is still missing a bunch of stuff

Signed-off-by: Edward Z. Yang <ezyangmeta.com>

cc voznesenskym penguinwu anijain2305 EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng Xia-Weiwen wenzhe-nrv jiayisunx ipiszy chenyang78 aakhundov

[ghstack-poisoned]
ezyang added a commit that referenced this pull request Aug 15, 2023
@ezyang
Force KJT list inputs to be unbacked ints.
3f2cb13 
Signed-off-by: Edward Z. Yang <ezyangmeta.com>

ghstack-source-id: c595dfc5fbe53b6f36f2be164a1ea4a2294ce437
Pull Request resolved: #107156
ezyang added a commit that referenced this pull request Aug 15, 2023
@ezyang
Force KJT list inputs to be unbacked ints.
0b61ddf 
Signed-off-by: Edward Z. Yang <ezyangmeta.com>

ghstack-source-id: c595dfc5fbe53b6f36f2be164a1ea4a2294ce437
Pull Request resolved: #107156
ezyang added a commit that referenced this pull request Aug 16, 2023
@ezyang
Force KJT list inputs to be unbacked ints.
2736ade 
Signed-off-by: Edward Z. Yang <ezyangmeta.com>

ghstack-source-id: c595dfc5fbe53b6f36f2be164a1ea4a2294ce437
Pull Request resolved: #107156
@zhxchen17 zhxchen17 mentioned this pull request Aug 16, 2023
Closed
zhxchen17 added a commit that referenced this pull request Aug 16, 2023
@zhxchen17
[dynamo] Make KeyedKaggedTensor a variable.[1/2]
4bcaec2 
This is extracted from #107156
to model KeyedKaggedTensor as a first class concept in dynamo. We will
add support for pytree later in the diff stack and test it with torchrec.

Summary:

Test Plan:

Reviewers:

Subscribers:

Tasks:

Tags:
zhxchen17 added a commit that referenced this pull request Aug 16, 2023
@zhxchen17
[dynamo] Make KeyedKaggedTensor a variable.[1/2]
eb8867c 
This is extracted from #107156
to model KeyedKaggedTensor as a first class concept in dynamo. We will
add support for pytree later in the diff stack and test it with torchrec.

Summary:

Test Plan:

Reviewers:

Subscribers:

Tasks:

Tags:
zhxchen17 added a commit that referenced this pull request Aug 17, 2023
@zhxchen17
[dynamo] Make KeyedKaggedTensor a variable.[1/2]
0c33fde 
This is extracted from #107156
to model KeyedKaggedTensor as a first class concept in dynamo. We will
add support for pytree later in the diff stack and test it with torchrec.

Summary:

Test Plan:

Reviewers:

Subscribers:

Tasks:

Tags:
zhxchen17 added a commit that referenced this pull request Aug 17, 2023
@zhxchen17
[dynamo] Make KeyedKaggedTensor a variable.[1/2]
4d357e4 
This is extracted from #107156
to model KeyedKaggedTensor as a first class concept in dynamo. We will
add support for pytree later in the diff stack and test it with torchrec.

Summary:

Test Plan:

Reviewers:

Subscribers:

Tasks:

Tags:
pytorchmergebot pushed a commit that referenced this pull request Aug 18, 2023
@zhxchen17 @pytorchmergebot
[dynamo] Make KeyedJaggedTensor a variable. (#107319)
8d6a487 
This is extracted from #107156
to model KeyedKaggedTensor as a first class concept in dynamo.
Summary:

Test Plan:

Reviewers:

Subscribers:

Tasks:

Tags:

Fixes #ISSUE_NUMBER

Pull Request resolved: #107319
Approved by: https://github.com/ezyang
tugsbayasgalan
tugsbayasgalan reviewed Aug 22, 2023
View reviewed changes
torch/_dynamo/variables/builder.py
value, int
):
wrapped_value = shape_env.create_unbacked_symint()
_constrain_range_for_size(wrapped_value)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we use constrain_as_size instead?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This fails with torch._dynamo.exc.InternalTorchDynamoError: tried to get Int out of SymInt

ezyang added a commit that referenced this pull request Aug 23, 2023
@ezyang
Force KJT list inputs to be unbacked ints.
11c4772 
Signed-off-by: Edward Z. Yang <ezyangmeta.com>

ghstack-source-id: c595dfc5fbe53b6f36f2be164a1ea4a2294ce437
Pull Request resolved: #107156
@ezyang ezyang closed this Aug 23, 2023
@ezyang
Copy link
Contributor Author

ezyang commented Aug 23, 2023

updated PR at #107788

@facebook-github-bot facebook-github-bot deleted the gh/ezyang/2300/head branch September 23, 2023 14:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tugsbayasgalan tugsbayasgalan tugsbayasgalan left review comments

@antoniojkim antoniojkim Awaiting requested review from antoniojkim

@bdhirsh bdhirsh Awaiting requested review from bdhirsh

@jbschlosser jbschlosser Awaiting requested review from jbschlosser

@miladm miladm Awaiting requested review from miladm

@SherlockNoMad SherlockNoMad Awaiting requested review from SherlockNoMad

@voznesenskym voznesenskym Awaiting requested review from voznesenskym

@wconstab wconstab Awaiting requested review from wconstab

Assignees
No one assigned
Labels
ciflow/inductor module: dynamo
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ezyang @tugsbayasgalan