Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ONNX] Add huggingface models into CI tests #107247
[ONNX] Add huggingface models into CI tests #107247
Changes from 19 commits
aae282d
dc16fb9
1e3a8f7
9fccefd
aec630d
8c25e11
6cdc7a0
d45c180
52cc050
7f64709
6bbef52
b29316c
079a6e9
38b18dd
866bf27
ec896d0
b9b122d
f365371
dcea1d4
8927ebc
487fa54
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
#107715
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this still needs to be cached though right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oops. Added back the tiny-gpt2 cache.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In
_test_fake_tensor_mode_exporter
, the exported ONNX model and PyTorch model are run and their outputs are compared. However, I am wondering if that really checksdynamic_shapes
. If not, probably with the next (or 2nd next), let's modifycreate_args
,create_kwargs
, andtest_fake_tensor_mode_exporter
to guarddynamic_shapes
supports different batch and sequence sizes.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is
assert_dynamic_shapes
inside the_test_fake_tensor_mode_exporter
should address your concern.