Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BE][PG NCCL] Improve input mismatch error msg #107281

Closed
wants to merge 1 commit into from
Closed

[BE][PG NCCL] Improve input mismatch error msg #107281

wants to merge 1 commit into from

Conversation

rohan-varma
Copy link
Member

Test Plan: CI

Differential Revision: D48363238

@pytorch-bot pytorch-bot bot added the release notes: distributed (c10d) release notes category label Aug 16, 2023
@pytorch-bot
Copy link

pytorch-bot bot commented Aug 16, 2023 •
edited

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/107281

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 6a62073 with merge base d0e50d9 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D48363238

@rohan-varma rohan-varma changed the title [BE] Improve input mismatch error msg [BE][PG NCCL] Improve input mismatch error msg Aug 16, 2023
rohan-varma
rohan-varma commented Aug 16, 2023
View reviewed changes
torch/csrc/distributed/c10d/ProcessGroupNCCL.cpp
" with world_size",
world_size,
" and ",
num_devices,
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is always 1 afaik, so can also exclude it.

awgu
awgu approved these changes Aug 16, 2023
View reviewed changes
Copy link
Contributor

@awgu awgu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Double check the nit.

torch/csrc/distributed/c10d/ProcessGroupNCCL.cpp Outdated
"but got ",
tensor_lists[i].size(),
" inputs",
" with world_size",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: I think?

Suggested change
" with world_size",
" with world_size ",

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D48363238

rohan-varma added a commit to rohan-varma/pytorch that referenced this pull request Aug 16, 2023
@rohan-varma @facebook-github-bot
[BE] Improve input mismatch error msg (pytorch#107281)
cef1ca4 
Summary: Pull Request resolved: pytorch#107281

Test Plan: CI

Reviewed By: daniellepintz, H-Huang, awgu

Differential Revision: D48363238

fbshipit-source-id: e2b0573dd02e4225820cd90f2c7feaa42c90136a
@rohan-varma @facebook-github-bot
[BE] Improve input mismatch error msg (pytorch#107281)
6a62073 
Summary: Pull Request resolved: pytorch#107281

Test Plan: CI

Reviewed By: daniellepintz, H-Huang, awgu

Differential Revision: D48363238

fbshipit-source-id: 705bc6cc63d4173fba630f69471fbfa0d35bb636
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D48363238

@rohan-varma
Copy link
Member Author

@pytorchbot merge -f "CI done"

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Please use -f as last resort and instead consider -i/--ignore-current to continue the merge ignoring current failures. This will allow currently pending tests to finish and report signal before the merge.

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

summerdo pushed a commit to summerdo/pytorch that referenced this pull request Aug 17, 2023
@rohan-varma @summerdo
[BE][PG NCCL] Improve input mismatch error msg (pytorch#107281)
3fa80b3 
Test Plan: CI

Differential Revision: D48363238

Pull Request resolved: pytorch#107281
Approved by: https://github.com/awgu, https://github.com/H-Huang, https://github.com/fegin
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fegin fegin fegin approved these changes

@H-Huang H-Huang H-Huang approved these changes

@awgu awgu awgu approved these changes

@mrshenli mrshenli Awaiting requested review from mrshenli

@zhaojuanmao zhaojuanmao Awaiting requested review from zhaojuanmao

@kwen2501 kwen2501 Awaiting requested review from kwen2501

@wanchaol wanchaol Awaiting requested review from wanchaol

@fduwjj fduwjj Awaiting requested review from fduwjj

@kiukchung kiukchung Awaiting requested review from kiukchung

@d4l3k d4l3k Awaiting requested review from d4l3k

Assignees
No one assigned
Labels
fb-exported Merged release notes: distributed (c10d) release notes category
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@rohan-varma @facebook-github-bot @pytorchmergebot @fegin @H-Huang @awgu