Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[export] Add schema version to serializer/deserializer #107420

Closed
wants to merge 2 commits into from

Conversation

angelayi
Copy link
Contributor

Added a version number to the schema for BC issues. We will add this number to the serialized ExportedProgram and then when deserializing, if the number does not match up with the existing deserializer, we will error. We should update the number of there are any major changes to the schema.

@pytorch-bot
Copy link

pytorch-bot bot commented Aug 17, 2023

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/107420

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit e2c0ea8 with merge base 139437b (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@angelayi
Copy link
Contributor Author

@pytorchbot merge

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Aug 18, 2023
@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@pytorchmergebot
Copy link
Collaborator

Merge failed

Reason: 1 jobs have failed, first few of them are: trunk / win-vs2019-cpu-py3 / test (default, 3, 3, windows.4xlarge.nonephemeral)

Details for Dev Infra team Raised by workflow job

@angelayi
Copy link
Contributor Author

@pytorchbot merge

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@ZainRizvi
Copy link
Contributor

@pytorchbot revert -m "Sorry, but this is breaking internal tests. Please see D48549362 for more details" -c ghfirst

@pytorchmergebot
Copy link
Collaborator

@pytorchbot successfully started a revert job. Check the current status here.
Questions? Feedback? Please reach out to the PyTorch DevX Team

@pytorchmergebot
Copy link
Collaborator

Reverting PR 107420 failed

Reason: Command git -C /home/runner/work/pytorch/pytorch revert --no-edit 63e9b5481d0d7e8d1f4e2fa85a010ce054751001 returned non-zero exit code 1

Auto-merging test/export/test_serialize.py
Auto-merging torch/_export/serde/schema.py
CONFLICT (content): Merge conflict in torch/_export/serde/schema.py
Auto-merging torch/_export/serde/serialize.py
error: could not revert 63e9b5481d0... [export] Add schema version to serializer/deserializer (#107420)
hint: After resolving the conflicts, mark them with
hint: "git add/rm <pathspec>", then run
hint: "git revert --continue".
hint: You can instead skip this commit with "git revert --skip".
hint: To abort and get back to the state before "git revert",
hint: run "git revert --abort".
Details for Dev Infra team Raised by workflow job

facebook-github-bot pushed a commit to pytorch/executorch that referenced this pull request Aug 23, 2023
Summary:
Added a version number to the schema for BC issues. We will add this number to the serialized ExportedProgram and then when deserializing, if the number does not match up with the existing deserializer, we will error. We should update the number of there are any major changes to the schema.

X-link: pytorch/pytorch#107420
Approved by: https://github.com/zhxchen17

Reviewed By: gmagogsfm, tugsbayasgalan

Differential Revision: D48549362

Pulled By: angelayi

fbshipit-source-id: 83a67bcdfeea2d2d05bf27283f46fe1f6bc12ad5
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ciflow/trunk Trigger trunk jobs on your pull request Merged release notes: export
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants