New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[export] Add schema version to serializer/deserializer #107420
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/107420
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit e2c0ea8 with merge base 139437b (): This comment was automatically generated by Dr. CI and updates every 15 minutes. |
@pytorchbot merge |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
Merge failedReason: 1 jobs have failed, first few of them are: trunk / win-vs2019-cpu-py3 / test (default, 3, 3, windows.4xlarge.nonephemeral) Details for Dev Infra teamRaised by workflow job |
a1bc450
to
e2c0ea8
Compare
@pytorchbot merge |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
@pytorchbot revert -m "Sorry, but this is breaking internal tests. Please see D48549362 for more details" -c ghfirst |
@pytorchbot successfully started a revert job. Check the current status here. |
Reverting PR 107420 failedReason: Command
Details for Dev Infra teamRaised by workflow job |
Summary: Added a version number to the schema for BC issues. We will add this number to the serialized ExportedProgram and then when deserializing, if the number does not match up with the existing deserializer, we will error. We should update the number of there are any major changes to the schema. X-link: pytorch/pytorch#107420 Approved by: https://github.com/zhxchen17 Reviewed By: gmagogsfm, tugsbayasgalan Differential Revision: D48549362 Pulled By: angelayi fbshipit-source-id: 83a67bcdfeea2d2d05bf27283f46fe1f6bc12ad5
Added a version number to the schema for BC issues. We will add this number to the serialized ExportedProgram and then when deserializing, if the number does not match up with the existing deserializer, we will error. We should update the number of there are any major changes to the schema.