Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix deepcopy for tensor with MTIA device key. #107427

Closed
wants to merge 1 commit into from
Closed

Fix deepcopy for tensor with MTIA device key. #107427

wants to merge 1 commit into from

Conversation

egienvalue
Copy link
Contributor

Summary: Tensor with MTIA device type doesn't have storage and we need to treat it same as other tensors which don't have storage.

Test Plan: CI tests.

Differential Revision: D48456004

@pytorch-bot
Copy link

pytorch-bot bot commented Aug 18, 2023 •
edited

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/107427

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit e5bb8bd with merge base 2e05403 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D48456004

@github-actions
Copy link

This PR needs a release notes: label

If your changes are user facing and intended to be a part of release notes, please use a label starting with release notes:.

If not, please add the topic: not user facing label.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "topic: not user facing"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D48456004

egienvalue added a commit to egienvalue/pytorch that referenced this pull request Aug 22, 2023
@egienvalue @facebook-github-bot
Fix deepcopy for tensor with MTIA device key. (pytorch#107427)
b936f82 
Summary:
Pull Request resolved: pytorch#107427

Tensor with MTIA device type doesn't have storage and we need to treat it same as other tensors which don't have storage.

Test Plan: CI tests.

Differential Revision: D48456004

fbshipit-source-id: ec3e87caf86d6df16866b3fbec878355a6c0707f
@egienvalue @facebook-github-bot
Fix deepcopy for tensor with MTIA device key. (pytorch#107427)
e5bb8bd 
Summary:
Pull Request resolved: pytorch#107427

Tensor with MTIA device type doesn't have storage and we need to treat it same as other tensors which don't have storage.

Test Plan: CI tests.

Differential Revision: D48456004

fbshipit-source-id: 941beb1ebd74ddcb338f109e9e030db9142d0ddb
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D48456004

@facebook-github-bot
Copy link
Contributor

@pytorchbot merge

(Initiating merge automatically since Phabricator Diff has merged)

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Aug 23, 2023
@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ezyang ezyang ezyang approved these changes

@cx-yin cx-yin cx-yin approved these changes

Assignees
No one assigned
Labels
ciflow/trunk Trigger trunk jobs on your pull request fb-exported Merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@egienvalue @facebook-github-bot @pytorchmergebot @ezyang @cx-yin