[Dynamo] cache_size policy #107496
Closed
[Dynamo] cache_size policy #107496
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[ghstack-poisoned]
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/107496
Note: Links to docs will display an error until the docs builds have been completed. ✅ You can merge normally! (1 Unrelated Failure)As of commit 4df4d5d with merge base 28dc1a0 ( BROKEN TRUNK - The following job failed but were present on the merge base:👉 Rebase onto the `viable/strict` branch to avoid these failures
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
anijain2305
added a commit
that referenced
this pull request
Aug 18, 2023
ghstack-source-id: d3985ded75703c44342139c5d67dbfc188dd7564 Pull Request resolved: #107496
cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng Xia-Weiwen wenzhe-nrv jiayisunx ipiszy chenyang78 aakhundov [ghstack-poisoned]
anijain2305
added a commit
that referenced
this pull request
Aug 19, 2023
ghstack-source-id: 555ff8f31be3932aea2bd24653b540602e1b9880 Pull Request resolved: #107496
cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng Xia-Weiwen wenzhe-nrv jiayisunx ipiszy chenyang78 aakhundov [ghstack-poisoned]
anijain2305
added a commit
that referenced
this pull request
Aug 19, 2023
ghstack-source-id: 0ea08b1a253b83eb5fdd4c7e460b04a9ee8a52d0 Pull Request resolved: #107496
cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng Xia-Weiwen wenzhe-nrv jiayisunx ipiszy chenyang78 aakhundov [ghstack-poisoned]
anijain2305
added a commit
that referenced
this pull request
Aug 19, 2023
ghstack-source-id: 1efe2c2c0c93d80c361f9c048bc891d7ff26e1e8 Pull Request resolved: #107496
cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng Xia-Weiwen wenzhe-nrv jiayisunx ipiszy chenyang78 aakhundov [ghstack-poisoned]
anijain2305
added a commit
that referenced
this pull request
Aug 19, 2023
ghstack-source-id: d8525c221539ef491691e280ffceee841cba57c1 Pull Request resolved: #107496
cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng Xia-Weiwen wenzhe-nrv jiayisunx ipiszy chenyang78 aakhundov [ghstack-poisoned]
anijain2305
added a commit
that referenced
this pull request
Aug 20, 2023
ghstack-source-id: 0f0a45ac12378eff68f95df5ea19e5e40551c7f5 Pull Request resolved: #107496
cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng Xia-Weiwen wenzhe-nrv jiayisunx ipiszy chenyang78 aakhundov [ghstack-poisoned]
anijain2305
added a commit
that referenced
this pull request
Aug 21, 2023
ghstack-source-id: 2be72a6142aee4268bbf3f80390d894a7ea0e525 Pull Request resolved: #107496
cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng Xia-Weiwen wenzhe-nrv jiayisunx ipiszy chenyang78 aakhundov [ghstack-poisoned]
anijain2305
added a commit
that referenced
this pull request
Aug 21, 2023
ghstack-source-id: 14b3f7ab17aa38a23f9c7c4b1c96d234f8aa3bff Pull Request resolved: #107496
cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng Xia-Weiwen wenzhe-nrv jiayisunx ipiszy chenyang78 aakhundov [ghstack-poisoned]
This was referenced Aug 21, 2023
anijain2305
added a commit
that referenced
this pull request
Aug 21, 2023
ghstack-source-id: 4b060461a3f1ed61331884757adb4edb6f0e83ea Pull Request resolved: #107496
cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng Xia-Weiwen wenzhe-nrv jiayisunx ipiszy chenyang78 aakhundov [ghstack-poisoned]
anijain2305
added a commit
that referenced
this pull request
Aug 21, 2023
ghstack-source-id: b442b524b0f8966952f02f90c40f746e37b7d713 Pull Request resolved: #107496
cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng Xia-Weiwen wenzhe-nrv jiayisunx ipiszy chenyang78 aakhundov [ghstack-poisoned]
anijain2305
added a commit
that referenced
this pull request
Aug 22, 2023
ghstack-source-id: 148d27a92044a5d74dad3450763cdec8965a44f9 Pull Request resolved: #107496
cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng Xia-Weiwen wenzhe-nrv jiayisunx ipiszy chenyang78 aakhundov [ghstack-poisoned]
jon-chuang
added a commit
that referenced
this pull request
Oct 26, 2023
--- Fixes: #110682 Replaces: #111074 The guards are installed based on config that is valid at the call to `torch.compile`, rather than at any subsequent call / triggered compilation. Subsequent compilations will restore the config if there is a config mismatch of the existing global config with the saved config. TODO: - [X] add tests Follow up PRs: - [x] add revised cache size computation (follow up PR: #111300 , based on: #107496) - [ ] handle run-only mode? - [ ] config restoration itself is not thread-safe (tracked: #111150) cc voznesenskym ezyang Chillee [ghstack-poisoned]
jon-chuang
added a commit
that referenced
this pull request
Oct 26, 2023
--- Fixes: #110682 Replaces: #111074 The guards are installed based on config that is valid at the call to `torch.compile`, rather than at any subsequent call / triggered compilation. Subsequent compilations will restore the config if there is a config mismatch of the existing global config with the saved config. TODO: - [X] add tests Follow up PRs: - [x] add revised cache size computation (follow up PR: #111300 , based on: #107496) - [ ] handle run-only mode? - [ ] config restoration itself is not thread-safe (tracked: #111150) cc voznesenskym ezyang Chillee [ghstack-poisoned]
jon-chuang
added a commit
that referenced
this pull request
Oct 26, 2023
--- Fixes: #110682 Replaces: #111074 The guards are installed based on config that is valid at the call to `torch.compile`, rather than at any subsequent call / triggered compilation. Subsequent compilations will restore the config if there is a config mismatch of the existing global config with the saved config. TODO: - [X] add tests Follow up PRs: - [x] add revised cache size computation (follow up PR: #111300 , based on: #107496) - [ ] handle run-only mode? - [ ] config restoration itself is not thread-safe (tracked: #111150) cc voznesenskym ezyang Chillee [ghstack-poisoned]
jon-chuang
added a commit
that referenced
this pull request
Oct 26, 2023
--- Fixes: #110682 Replaces: #111074 The guards are installed based on config that is valid at the call to `torch.compile`, rather than at any subsequent call / triggered compilation. Subsequent compilations will restore the config if there is a config mismatch of the existing global config with the saved config. TODO: - [X] add tests Follow up PRs: - [x] add revised cache size computation (follow up PR: #111300 , based on: #107496) - [ ] handle run-only mode? - [ ] config restoration itself is not thread-safe (tracked: #111150) cc voznesenskym ezyang Chillee [ghstack-poisoned]
jon-chuang
added a commit
that referenced
this pull request
Oct 26, 2023
--- Fixes: #110682 Replaces: #111074 The guards are installed based on config that is valid at the call to `torch.compile`, rather than at any subsequent call / triggered compilation. Subsequent compilations will restore the config if there is a config mismatch of the existing global config with the saved config. TODO: - [X] add tests Follow up PRs: - [x] add revised cache size computation (follow up PR: #111300 , based on: #107496) - [ ] handle run-only mode? - [ ] config restoration itself is not thread-safe (tracked: #111150) cc voznesenskym ezyang Chillee [ghstack-poisoned]
jon-chuang
added a commit
that referenced
this pull request
Oct 26, 2023
--- Fixes: #110682 Replaces: #111074 The guards are installed based on config that is valid at the call to `torch.compile`, rather than at any subsequent call / triggered compilation. Subsequent compilations will restore the config if there is a config mismatch of the existing global config with the saved config. TODO: - [X] add tests Follow up PRs: - [x] add revised cache size computation (follow up PR: #111300 , based on: #107496) - [ ] handle run-only mode? - [ ] config restoration itself is not thread-safe (tracked: #111150) cc voznesenskym ezyang Chillee [ghstack-poisoned]
jon-chuang
added a commit
that referenced
this pull request
Oct 26, 2023
--- Fixes: #110682 Replaces: #111074 The guards are installed based on config that is valid at the call to `torch.compile`, rather than at any subsequent call / triggered compilation. Subsequent compilations will restore the config if there is a config mismatch of the existing global config with the saved config. TODO: - [X] add tests Follow up PRs: - [x] add revised cache size computation (follow up PR: #111300 , based on: #107496) - [ ] handle run-only mode? - [ ] config restoration itself is not thread-safe (tracked: #111150) cc voznesenskym ezyang Chillee [ghstack-poisoned]
jon-chuang
added a commit
that referenced
this pull request
Nov 16, 2023
--- Fixes: #110682 Replaces: #111074 The guards are installed based on config that is valid at the call to `torch.compile`, rather than at any subsequent call / triggered compilation. Subsequent compilations will restore the config if there is a config mismatch of the existing global config with the saved config. TODO: - [X] add tests Follow up PRs: - [x] add revised cache size computation (follow up PR: #111300 , based on: #107496) - [ ] handle run-only mode? - [ ] config restoration itself is not thread-safe (tracked: #111150) cc voznesenskym ezyang Chillee [ghstack-poisoned]
jon-chuang
added a commit
that referenced
this pull request
Nov 16, 2023
--- Fixes: #110682 Replaces: #111074 The guards are installed based on config that is valid at the call to `torch.compile`, rather than at any subsequent call / triggered compilation. Subsequent compilations will restore the config if there is a config mismatch of the existing global config with the saved config. TODO: - [X] add tests Follow up PRs: - [x] add revised cache size computation (follow up PR: #111300 , based on: #107496) - [ ] handle run-only mode? - [ ] config restoration itself is not thread-safe (tracked: #111150) cc voznesenskym ezyang Chillee [ghstack-poisoned]
jon-chuang
added a commit
that referenced
this pull request
Nov 16, 2023
--- Fixes: #110682 Replaces: #111074 The guards are installed based on config that is valid at the call to `torch.compile`, rather than at any subsequent call / triggered compilation. Subsequent compilations will restore the config if there is a config mismatch of the existing global config with the saved config. TODO: - [X] add tests Follow up PRs: - [x] add revised cache size computation (follow up PR: #111300 , based on: #107496) - [ ] handle run-only mode? - [ ] config restoration itself is not thread-safe (tracked: #111150) cc voznesenskym ezyang Chillee [ghstack-poisoned]
jon-chuang
added a commit
that referenced
this pull request
Nov 16, 2023
--- Fixes: #110682 Replaces: #111074 The guards are installed based on config that is valid at the call to `torch.compile`, rather than at any subsequent call / triggered compilation. Subsequent compilations will restore the config if there is a config mismatch of the existing global config with the saved config. TODO: - [X] add tests Follow up PRs: - [x] add revised cache size computation (follow up PR: #111300 , based on: #107496) - [ ] handle run-only mode? - [ ] config restoration itself is not thread-safe (tracked: #111150) cc voznesenskym ezyang Chillee [ghstack-poisoned]
jon-chuang
added a commit
that referenced
this pull request
Nov 16, 2023
--- Fixes: #110682 Replaces: #111074 The guards are installed based on config that is valid at the call to `torch.compile`, rather than at any subsequent call / triggered compilation. Subsequent compilations will restore the config if there is a config mismatch of the existing global config with the saved config. TODO: - [X] add tests Follow up PRs: - [x] add revised cache size computation (follow up PR: #111300 , based on: #107496) - [ ] handle run-only mode? - [ ] config restoration itself is not thread-safe (tracked: #111150) cc voznesenskym ezyang Chillee [ghstack-poisoned]
jon-chuang
added a commit
that referenced
this pull request
Nov 16, 2023
--- Fixes: #110682 Replaces: #111074 The guards are installed based on config that is valid at the call to `torch.compile`, rather than at any subsequent call / triggered compilation. Subsequent compilations will restore the config if there is a config mismatch of the existing global config with the saved config. TODO: - [X] add tests Follow up PRs: - [x] add revised cache size computation (follow up PR: #111300 , based on: #107496) - [ ] handle run-only mode? - [ ] config restoration itself is not thread-safe (tracked: #111150) cc voznesenskym ezyang Chillee [ghstack-poisoned]
jon-chuang
added a commit
that referenced
this pull request
Nov 16, 2023
--- Fixes: #110682 Replaces: #111074 The guards are installed based on config that is valid at the call to `torch.compile`, rather than at any subsequent call / triggered compilation. Subsequent compilations will restore the config if there is a config mismatch of the existing global config with the saved config. TODO: - [X] add tests Follow up PRs: - [x] add revised cache size computation (follow up PR: #111300 , based on: #107496) - [ ] handle run-only mode? - [ ] config restoration itself is not thread-safe (tracked: #111150) cc voznesenskym ezyang Chillee [ghstack-poisoned]
jon-chuang
added a commit
that referenced
this pull request
Nov 16, 2023
--- Fixes: #110682 Replaces: #111074 The guards are installed based on config that is valid at the call to `torch.compile`, rather than at any subsequent call / triggered compilation. Subsequent compilations will restore the config if there is a config mismatch of the existing global config with the saved config. TODO: - [X] add tests Follow up PRs: - [x] add revised cache size computation (follow up PR: #111300 , based on: #107496) - [ ] handle run-only mode? - [ ] config restoration itself is not thread-safe (tracked: #111150) cc voznesenskym ezyang Chillee [ghstack-poisoned]
jon-chuang
added a commit
that referenced
this pull request
Nov 16, 2023
--- Fixes: #110682 Replaces: #111074 The guards are installed based on config that is valid at the call to `torch.compile`, rather than at any subsequent call / triggered compilation. Subsequent compilations will restore the config if there is a config mismatch of the existing global config with the saved config. TODO: - [X] add tests Follow up PRs: - [x] add revised cache size computation (follow up PR: #111300 , based on: #107496) - [ ] handle run-only mode? - [ ] config restoration itself is not thread-safe (tracked: #111150) cc voznesenskym ezyang Chillee [ghstack-poisoned]
jon-chuang
added a commit
that referenced
this pull request
Nov 16, 2023
--- Fixes: #110682 Replaces: #111074 The guards are installed based on config that is valid at the call to `torch.compile`, rather than at any subsequent call / triggered compilation. Subsequent compilations will restore the config if there is a config mismatch of the existing global config with the saved config. TODO: - [X] add tests Follow up PRs: - [x] add revised cache size computation (follow up PR: #111300 , based on: #107496) - [ ] handle run-only mode? - [ ] config restoration itself is not thread-safe (tracked: #111150) cc voznesenskym ezyang Chillee [ghstack-poisoned]
jon-chuang
added a commit
that referenced
this pull request
Nov 17, 2023
--- Fixes: #110682 Replaces: #111074 The guards are installed based on config that is valid at the call to `torch.compile`, rather than at any subsequent call / triggered compilation. Subsequent compilations will restore the config if there is a config mismatch of the existing global config with the saved config. TODO: - [X] add tests Follow up PRs: - [x] add revised cache size computation (follow up PR: #111300 , based on: #107496) - [ ] handle run-only mode? - [ ] config restoration itself is not thread-safe (tracked: #111150) cc voznesenskym ezyang Chillee [ghstack-poisoned]
jon-chuang
added a commit
that referenced
this pull request
Nov 17, 2023
--- Fixes: #110682 Replaces: #111074 The guards are installed based on config that is valid at the call to `torch.compile`, rather than at any subsequent call / triggered compilation. Subsequent compilations will restore the config if there is a config mismatch of the existing global config with the saved config. TODO: - [X] add tests Follow up PRs: - [x] add revised cache size computation (follow up PR: #111300 , based on: #107496) - [ ] handle run-only mode? - [ ] config restoration itself is not thread-safe (tracked: #111150) cc voznesenskym ezyang Chillee [ghstack-poisoned]
jon-chuang
added a commit
that referenced
this pull request
Nov 17, 2023
--- Fixes: #110682 Replaces: #111074 The guards are installed based on config that is valid at the call to `torch.compile`, rather than at any subsequent call / triggered compilation. Subsequent compilations will restore the config if there is a config mismatch of the existing global config with the saved config. TODO: - [X] add tests Follow up PRs: - [x] add revised cache size computation (follow up PR: #111300 , based on: #107496) - [ ] handle run-only mode? - [ ] config restoration itself is not thread-safe (tracked: #111150) cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx chenyang78 aakhundov kadeng ezyang Chillee [ghstack-poisoned]
jon-chuang
added a commit
that referenced
this pull request
Nov 17, 2023
--- Fixes: #110682 Replaces: #111074 The guards are installed based on config that is valid at the call to `torch.compile`, rather than at any subsequent call / triggered compilation. Subsequent compilations will restore the config if there is a config mismatch of the existing global config with the saved config. TODO: - [X] add tests Follow up PRs: - [x] add revised cache size computation (follow up PR: #111300 , based on: #107496) - [ ] handle run-only mode? - [ ] config restoration itself is not thread-safe (tracked: #111150) cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx chenyang78 aakhundov kadeng ezyang Chillee [ghstack-poisoned]
jon-chuang
added a commit
that referenced
this pull request
Nov 17, 2023
--- Fixes: #110682 Replaces: #111074 The guards are installed based on config that is valid at the call to `torch.compile`, rather than at any subsequent call / triggered compilation. Subsequent compilations will restore the config if there is a config mismatch of the existing global config with the saved config. TODO: - [X] add tests Follow up PRs: - [x] add revised cache size computation (follow up PR: #111300 , based on: #107496) - [ ] handle run-only mode? - [ ] config restoration itself is not thread-safe (tracked: #111150) cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx chenyang78 aakhundov kadeng ezyang Chillee [ghstack-poisoned]
jon-chuang
added a commit
that referenced
this pull request
Nov 17, 2023
--- Fixes: #110682 Replaces: #111074 The guards are installed based on config that is valid at the call to `torch.compile`, rather than at any subsequent call / triggered compilation. Subsequent compilations will restore the config if there is a config mismatch of the existing global config with the saved config. TODO: - [X] add tests Follow up PRs: - [x] add revised cache size computation (follow up PR: #111300 , based on: #107496) - [ ] handle run-only mode? - [ ] config restoration itself is not thread-safe (tracked: #111150) cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx chenyang78 aakhundov kadeng ezyang Chillee [ghstack-poisoned]
jon-chuang
added a commit
that referenced
this pull request
Nov 17, 2023
--- Fixes: #110682 Replaces: #111074 The guards are installed based on config that is valid at the call to `torch.compile`, rather than at any subsequent call / triggered compilation. Subsequent compilations will restore the config if there is a config mismatch of the existing global config with the saved config. TODO: - [X] add tests Follow up PRs: - [x] add revised cache size computation (follow up PR: #111300 , based on: #107496) - [ ] handle run-only mode? - [ ] config restoration itself is not thread-safe (tracked: #111150) cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx chenyang78 aakhundov kadeng ezyang Chillee [ghstack-poisoned]
jon-chuang
added a commit
that referenced
this pull request
Nov 17, 2023
--- Fixes: #110682 Replaces: #111074 The guards are installed based on config that is valid at the call to `torch.compile`, rather than at any subsequent call / triggered compilation. Subsequent compilations will restore the config if there is a config mismatch of the existing global config with the saved config. TODO: - [X] add tests Follow up PRs: - [x] add revised cache size computation (follow up PR: #111300 , based on: #107496) - [ ] handle run-only mode? - [ ] config restoration itself is not thread-safe (tracked: #111150) cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx chenyang78 aakhundov kadeng ezyang Chillee [ghstack-poisoned]
jon-chuang
added a commit
that referenced
this pull request
Nov 17, 2023
--- Fixes: #110682 Replaces: #111074 The guards are installed based on config that is valid at the call to `torch.compile`, rather than at any subsequent call / triggered compilation. Subsequent compilations will restore the config if there is a config mismatch of the existing global config with the saved config. TODO: - [X] add tests Follow up PRs: - [x] add revised cache size computation (follow up PR: #111300 , based on: #107496) - [ ] handle run-only mode? - [ ] config restoration itself is not thread-safe (tracked: #111150) cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx chenyang78 aakhundov kadeng ezyang Chillee [ghstack-poisoned]
jon-chuang
added a commit
that referenced
this pull request
Nov 17, 2023
--- Fixes: #110682 Replaces: #111074 The guards are installed based on config that is valid at the call to `torch.compile`, rather than at any subsequent call / triggered compilation. Subsequent compilations will restore the config if there is a config mismatch of the existing global config with the saved config. TODO: - [X] add tests Follow up PRs: - [x] add revised cache size computation (follow up PR: #111300 , based on: #107496) - [ ] handle run-only mode? - [ ] config restoration itself is not thread-safe (tracked: #111150) cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx chenyang78 aakhundov kadeng ezyang Chillee [ghstack-poisoned]
jon-chuang
added a commit
that referenced
this pull request
Nov 17, 2023
--- Fixes: #110682 Replaces: #111074 The guards are installed based on config that is valid at the call to `torch.compile`, rather than at any subsequent call / triggered compilation. Subsequent compilations will restore the config if there is a config mismatch of the existing global config with the saved config. TODO: - [X] add tests Follow up PRs: - [x] add revised cache size computation (follow up PR: #111300 , based on: #107496) - [ ] handle run-only mode? - [ ] config restoration itself is not thread-safe (tracked: #111150) cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx chenyang78 aakhundov kadeng ezyang Chillee [ghstack-poisoned]
jon-chuang
added a commit
that referenced
this pull request
Nov 17, 2023
--- Fixes: #110682 Replaces: #111074 The guards are installed based on config that is valid at the call to `torch.compile`, rather than at any subsequent call / triggered compilation. Subsequent compilations will restore the config if there is a config mismatch of the existing global config with the saved config. TODO: - [X] add tests Follow up PRs: - [x] add revised cache size computation (follow up PR: #111300 , based on: #107496) - [ ] handle run-only mode? - [ ] config restoration itself is not thread-safe (tracked: #111150) cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx chenyang78 aakhundov kadeng ezyang Chillee [ghstack-poisoned]
pytorchmergebot
pushed a commit
that referenced
this pull request
Nov 17, 2023
--- Fixes: #110682 Replaces: #111074 The guards are installed based on config that is valid at the call to `torch.compile`, rather than at any subsequent call / triggered compilation. Subsequent compilations will restore the config if there is a config mismatch of the existing global config with the saved config. TODO: - [X] add tests Follow up PRs: - [x] add revised cache size computation (follow up PR: #111300 , based on: #107496) - [ ] handle run-only mode? - [ ] config restoration itself is not thread-safe (tracked: #111150) Pull Request resolved: #111299 Approved by: https://github.com/ezyang
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
cc @voznesenskym @penguinwu @EikanWang @jgong5 @Guobing-Chen @XiaobingSuper @zhuhaozhe @blzheng @Xia-Weiwen @wenzhe-nrv @jiayisunx @ipiszy @chenyang78 @aakhundov