Single source of truth for guard logging #107532
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Edward Z. Yang <ezyang@meta.com> [ghstack-poisoned]
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/107532
Note: Links to docs will display an error until the docs builds have been completed. ✅ 1 Unrelated FailureAs of commit c53c72f with merge base bdecdfd ( FLAKY - The following job failed but was likely due to flakiness present on trunk:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
This was referenced Aug 20, 2023
github-actions
bot
requested review from
albanD,
antoniojkim,
bdhirsh,
jbschlosser,
miladm,
SherlockNoMad,
voznesenskym and
wconstab
ezyang
added a commit
that referenced
this pull request
Aug 20, 2023
Signed-off-by: Edward Z. Yang <ezyangmeta.com> ghstack-source-id: 3bcbaebb65e2cec04dc524b773d40b48c2494bba Pull Request resolved: #107532
Instead of (poorly) reconstructing the guard list from the guards on OutputGraph, we log them at the horses mouth: when we actually codegen the guard. This only requires very modest refactoring: as we translate guards into code parts, we also have to pass the source guard along so we can use it to give stack information. Signed-off-by: Edward Z. Yang <ezyangmeta.com> cc voznesenskym penguinwu anijain2305 EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng Xia-Weiwen wenzhe-nrv jiayisunx ipiszy chenyang78 aakhundov [ghstack-poisoned]
ezyang
added a commit
that referenced
this pull request
Aug 20, 2023
Signed-off-by: Edward Z. Yang <ezyangmeta.com> ghstack-source-id: fb2b8e5fc3cd05834222014818dfe88955f69fd8 Pull Request resolved: #107532
Instead of (poorly) reconstructing the guard list from the guards on OutputGraph, we log them at the horses mouth: when we actually codegen the guard. This only requires very modest refactoring: as we translate guards into code parts, we also have to pass the source guard along so we can use it to give stack information. Signed-off-by: Edward Z. Yang <ezyangmeta.com> cc voznesenskym penguinwu anijain2305 EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng Xia-Weiwen wenzhe-nrv jiayisunx ipiszy chenyang78 aakhundov [ghstack-poisoned]
ezyang
added a commit
that referenced
this pull request
Aug 20, 2023
Signed-off-by: Edward Z. Yang <ezyangmeta.com> ghstack-source-id: 8939f65343a462772c3c84d6e421bcf80a7bcb5b Pull Request resolved: #107532
|
Why is this better than the status quo? Won't this yield the same result as iterating through code parts if we log the guard at codegen time? |
Instead of (poorly) reconstructing the guard list from the guards on OutputGraph, we log them at the horses mouth: when we actually codegen the guard. This only requires very modest refactoring: as we translate guards into code parts, we also have to pass the source guard along so we can use it to give stack information. Signed-off-by: Edward Z. Yang <ezyangmeta.com> cc voznesenskym penguinwu anijain2305 EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng Xia-Weiwen wenzhe-nrv jiayisunx ipiszy chenyang78 aakhundov [ghstack-poisoned]
ezyang
added a commit
that referenced
this pull request
Aug 20, 2023
Signed-off-by: Edward Z. Yang <ezyangmeta.com> ghstack-source-id: 61d49e428861ceeba3e5a93bb0f2822d8c0a3201 Pull Request resolved: #107532
anijain2305
reviewed
Aug 21, 2023
| @@ -193,6 +216,7 @@ def __init__( | |||
| # check it against this example", and it all ends up getting | |||
| # swept up into a single call to ___check_tensors. Invariant: | |||
| # len(tensor_check_names) == len(tensor_check_examples). | |||
| # TODO: something here | |||
anijain2305
approved these changes
Aug 21, 2023
This was referenced Aug 21, 2023
|
@pytorchbot merge |
Merge failedReason: This PR needs a If not, please add the To add a label, you can comment to pytorchbot, for example For more information, see Details for Dev Infra teamRaised by workflow job |
|
@pytorchbot merge |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
pytorchmergebot
pushed a commit
that referenced
this pull request
Aug 21, 2023
The new guard messages look like: ``` check_tensor(L['y'], Tensor, DispatchKeySet(CPU, BackendSelect, ADInplaceOrView, AutogradCPU), torch.float32, device=None, requires_grad=False, size=[3], stride=[1]) # _dynamo/variables/builder.py:1237 in wrap_fx_proxy_cls ``` Signed-off-by: Edward Z. Yang <ezyang@meta.com> Pull Request resolved: #107562 Approved by: https://github.com/anijain2305, https://github.com/jansel ghstack dependencies: #107505, #107516, #107530, #107532
pytorchmergebot
pushed a commit
that referenced
this pull request
Aug 22, 2023
CapturedTraceback is fast but one downside is that it has strong references to code objects, which via `co_extra` can cause un-collectable cycles. This means that it is important to clear out CapturedTraceback when you are done with it; e.g., if you tracebacks during compilation, you need to explicitly clear them out at the end of compilation to actually make sure they promptly deallocate. Instead of caching `summary` on the CapturedTraceback, we simply allow for tracebacks to have `tb = None`. Tracebacks get dropped if you pickle the traceback, or if you explicitly call cleanup(). Signed-off-by: Edward Z. Yang <ezyang@meta.com> Pull Request resolved: #107471 Approved by: https://github.com/voznesenskym ghstack dependencies: #107505, #107516, #107530, #107532, #107562
pytorchmergebot
pushed a commit
that referenced
this pull request
Aug 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
Instead of (poorly) reconstructing the guard list from the guards on OutputGraph, we log them at the horses mouth: when we actually codegen the guard. This only requires very modest refactoring: as we translate guards into code parts, we also have to pass the source guard along so we can use it to give stack information.
Signed-off-by: Edward Z. Yang ezyang@meta.com
cc @voznesenskym @penguinwu @anijain2305 @EikanWang @jgong5 @Guobing-Chen @XiaobingSuper @zhuhaozhe @blzheng @Xia-Weiwen @wenzhe-nrv @jiayisunx @ipiszy @chenyang78 @aakhundov