Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ao] updating embedding_bag support for fx and eager #107623

Closed
wants to merge 9 commits into from
Closed

[ao] updating embedding_bag support for fx and eager #107623

wants to merge 9 commits into from

Commits on Aug 21, 2023

  1. [ao] updating embedding_bag support 

    Summary: our docs were saying dynamic embedding bag wasn't supported but
it actually is (at least at the same level as embeddings were) it just wasn't previously tested/listed.

Test Plan: python test/test_quantization.py -k "test_embedding"

Reviewers:

Subscribers:

Tasks:

Tags:

[ghstack-poisoned]
    @HDCharles
    HDCharles committed Aug 21, 2023
    Configuration menu
    Copy the full SHA
    a854f51 View commit details
    Browse the repository at this point in the history

  2. Update on "[ao] updating embedding_bag support" 

    Summary: our docs were saying dynamic embedding bag wasn't supported but
it actually is (at least at the same level as embeddings were) it just wasn't previously tested/listed.

Test Plan: python test/test_quantization.py -k "test_embedding"

Reviewers:

Subscribers:

Tasks:

Tags:

[ghstack-poisoned]
    @HDCharles
    HDCharles committed Aug 21, 2023
    Configuration menu
    Copy the full SHA
    81979e5 View commit details
    Browse the repository at this point in the history

  3. Update on "[ao] updating embedding_bag support" 

    Summary: our docs were saying dynamic embedding bag wasn't supported but
it actually is (at least at the same level as embeddings were) it just wasn't previously tested/listed.

Test Plan: python test/test_quantization.py -k "test_embedding"

Reviewers:

Subscribers:

Tasks:

Tags:

[ghstack-poisoned]
    @HDCharles
    HDCharles committed Aug 21, 2023
    Configuration menu
    Copy the full SHA
    46249a8 View commit details
    Browse the repository at this point in the history

  4. Update on "[ao] updating embedding_bag support for fx and eager" 

    Summary: our docs were saying dynamic embedding bag wasn't supported but
it actually is (at least at the same level as embeddings were) it just wasn't previously tested/listed.

Test Plan: python test/test_quantization.py -k "test_embedding"

Reviewers:

Subscribers:

Tasks:

Tags:

[ghstack-poisoned]
    @HDCharles
    HDCharles committed Aug 21, 2023
    Configuration menu
    Copy the full SHA
    6c66fa9 View commit details
    Browse the repository at this point in the history

  5. Update on "[ao] updating embedding_bag support for fx and eager" 

    Summary: our docs were saying dynamic embedding bag wasn't supported but
it actually is (at least at the same level as embeddings were) it just wasn't previously tested/listed.

Test Plan: python test/test_quantization.py -k "test_embedding"

Reviewers:

Subscribers:

Tasks:

Tags:

[ghstack-poisoned]
    @HDCharles
    HDCharles committed Aug 21, 2023
    Configuration menu
    Copy the full SHA
    a878174 View commit details
    Browse the repository at this point in the history

  6. Update on "[ao] updating embedding_bag support for fx and eager" 

    Summary: our docs were saying dynamic embedding bag wasn't supported but
it actually is (at least at the same level as embeddings were) it just wasn't previously tested/listed.

Test Plan: python test/test_quantization.py -k "test_embedding"

Reviewers:

Subscribers:

Tasks:

Tags:

[ghstack-poisoned]
    @HDCharles
    HDCharles committed Aug 21, 2023
    Configuration menu
    Copy the full SHA
    88ff1f2 View commit details
    Browse the repository at this point in the history

Commits on Aug 23, 2023

  1. Update on "[ao] updating embedding_bag support for fx and eager" 

    Summary: our docs were saying dynamic embedding bag wasn't supported but
it actually is (at least at the same level as embeddings were) it just wasn't previously tested/listed.

Test Plan: python test/test_quantization.py -k "test_embedding"

Reviewers:

Subscribers:

Tasks:

Tags:

[ghstack-poisoned]
    @HDCharles
    HDCharles committed Aug 23, 2023
    Configuration menu
    Copy the full SHA
    44dfa4d View commit details
    Browse the repository at this point in the history

Commits on Nov 18, 2023

  1. Update on "[ao] updating embedding_bag support for fx and eager" 

    Summary: our docs were saying dynamic embedding bag wasn't supported but
it actually is (at least at the same level as embeddings were) it just wasn't previously tested/listed.

Test Plan: python test/test_quantization.py -k "test_embedding"

Reviewers:

Subscribers:

Tasks:

Tags:

[ghstack-poisoned]
    @HDCharles
    HDCharles committed Nov 18, 2023
    Configuration menu
    Copy the full SHA
    1464f8a View commit details
    Browse the repository at this point in the history

Commits on Nov 20, 2023

  1. Update on "[ao] updating embedding_bag support for fx and eager" 

    Summary: our docs were saying dynamic embedding bag wasn't supported but
it actually is (at least at the same level as embeddings were) it just wasn't previously tested/listed.

Test Plan: python test/test_quantization.py -k "test_embedding"

Reviewers:

Subscribers:

Tasks:

Tags:

[ghstack-poisoned]
    @HDCharles
    HDCharles committed Nov 20, 2023
    Configuration menu
    Copy the full SHA
    e924738 View commit details
    Browse the repository at this point in the history