Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[core aten] Add ops to core aten set #107766

Closed
wants to merge 2 commits into from
Closed

[core aten] Add ops to core aten set #107766

wants to merge 2 commits into from

Conversation

angelayi
Copy link
Contributor

@angelayi angelayi commented Aug 23, 2023

Update the list of core aten ops with the ones we determined here.

aten::adaptive_avg_pool1d
aten::_adaptive_avg_pool3d
aten::_cdist_forward
aten::_embedding_bag
aten::_local_scalar_dense
aten::_native_batch_norm_legit_no_training
aten::_native_batch_norm_legit
aten::_pdist_forward
aten::any
aten::any.dim
aten::avg_pool1d
aten::avg_pool3d
aten::bitwise_and.Scalar
aten::bitwise_or.Scalar
aten::bitwise_xor.Scalar
aten::ceil
aten::clamp.Tensor
aten::cumsum
aten::embedding
aten::floor
aten::fmod.Scalar
aten::index_put
aten::index.Tensor
aten::logical_xor
aten::mean
aten::mean.dim
aten::pixel_shuffle
aten::prod
aten::prod.dim_int
aten::rand
aten::randperm
aten::reflection_pad_1d
aten::reflection_pad_2d
aten::reflection_pad_3d
aten::remainder.Scalar
aten::roll
aten::round
aten::scatter.src
aten::scatter.value
aten::select_scatter
aten::sort
aten::split.Tensor
aten::split_with_sizes
aten::squeeze.dims
aten::tan
aten::unsqueeze
aten::var.correction

@pytorch-bot
Copy link

pytorch-bot bot commented Aug 23, 2023

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/107766

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 21dad82 with merge base d0f8ee4 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

Copy link
Contributor

@kirklandsign kirklandsign left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I reviewed that all the added ops are in the doc.

@angelayi
Copy link
Contributor Author

@pytorchbot merge

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Aug 23, 2023
@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@SherlockNoMad
Copy link
Contributor

native_batch_norm_legit
native_batch_norm_legit_no_training
native_batch_norm_legit_functional
are the "functionalization-happy" variants of batch norm that show up in inductor / export today

So we need to include all three.

@pytorchmergebot
Copy link
Collaborator

Merge failed

Reason: 2 jobs have failed, first few of them are: trunk / linux-focal-cuda12.1-py3.10-gcc9 / test (nogpu_AVX512, 1, 1, linux.2xlarge), trunk / linux-focal-cuda12.1-py3.10-gcc9 / test (nogpu_NO_AVX2, 1, 1, linux.2xlarge)

Details for Dev Infra team Raised by workflow job

@angelayi
Copy link
Contributor Author

Added native_batch_norm_legit. I think native_batch_norm_legit_functional doesn't exist as a direct function in native_functions.yaml

@angelayi
Copy link
Contributor Author

@pytorchbot merge

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@facebook-github-bot
Copy link
Contributor

@angelayi has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ciflow/trunk Trigger trunk jobs on your pull request Merged release notes: export
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants