[ONNX] Enable 'ExportOutput.save' for models larger than 2GB #107904
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[ghstack-poisoned]
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/107904
Note: Links to docs will display an error until the docs builds have been completed. ✅ You can merge normally! (1 Unrelated Failure)As of commit 0f07ca7 with merge base 1ef4bd1 ( UNSTABLE - The following job failed but was likely due to flakiness present on trunk and has been marked as unstable:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
pytorch-bot
bot
added
release notes: onnx
BowenBao
added a commit
that referenced
this pull request
Aug 24, 2023
ghstack-source-id: e92a457a3648d78f268649c6a256f31a70b87fa5 Pull Request resolved: #107904
Previously it fails during serialization, despite onnxscript graph_building managed to return ModelProto > 2GB. [ghstack-poisoned]
BowenBao
added a commit
that referenced
this pull request
Aug 24, 2023
ghstack-source-id: addb87d18df4175ef7c29be205e30f346cee6c8a Pull Request resolved: #107904
BowenBao
requested review from
abock,
thiagocrepaldi and
wschin
as code owners
… 2GB" Previously it fails during serialization, despite onnxscript graph_building managed to return ModelProto > 2GB. [ghstack-poisoned]
BowenBao
added a commit
that referenced
this pull request
Aug 24, 2023
ghstack-source-id: 9593c65479fd4d7faa66925dd7028b072b38ef81 Pull Request resolved: #107904
abock
approved these changes
Aug 25, 2023
Previously it fails during serialization, despite onnxscript graph_building managed to return ModelProto > 2GB. [ghstack-poisoned]
BowenBao
added a commit
that referenced
this pull request
Aug 25, 2023
ghstack-source-id: b8c31b52901880eb231e124e19794d4f0a430cea Pull Request resolved: #107904
|
@pytorchbot merge |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
voznesenskym
pushed a commit
that referenced
this pull request
Aug 27, 2023
Previously it fails during serialization, despite onnxscript graph_building managed to return ModelProto > 2GB. Pull Request resolved: #107904 Approved by: https://github.com/abock
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
Previously it fails during serialization, despite onnxscript graph_building managed to return ModelProto > 2GB.