Fix the coredump described by #106702 #108002
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/108002
Note: Links to docs will display an error until the docs builds have been completed. ⏳ No Failures, 2 PendingAs of commit 6ed997d with merge base c2ac0da ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
FFFrog
force-pushed
the
mrl_fix_unpool_output_size
branch
from
93a1c87
to
6ed997d
Compare
|
Hi @albanD, please take a look at this pr, thank you. |
|
Hi @albanD, please have a look at this, thank you :D |
albanD
approved these changes
Aug 29, 2023
|
@pytorchbot merge |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #106702 and add some tests
As shown by maxUnpool1d(
MaxUnpool2d,MaxUnpool3dalso),InputandOutputsupport(N,C,*)or(C,*), but the c++ api currently supports the former, and the latter will cause a coredump.