Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix LayerNorm(bias=False) error #108060

Conversation

mikaylagawarecki
Copy link
Contributor

@mikaylagawarecki mikaylagawarecki commented Aug 28, 2023

Fixes #108048

  • Cherry pick this here

Stack from ghstack (oldest at bottom):

@pytorch-bot
Copy link

pytorch-bot bot commented Aug 28, 2023

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/108060

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit f4ac614 with merge base dcc674d (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

mikaylagawarecki added a commit that referenced this pull request Aug 28, 2023
ghstack-source-id: e867e70c464f1635ee21db647c3fc116f6cc6d33
Pull Request resolved: #108060
mikaylagawarecki added a commit that referenced this pull request Aug 28, 2023
ghstack-source-id: 613c4f3608b1a375013fc9da64545c1084025650
Pull Request resolved: #108060
@mikaylagawarecki mikaylagawarecki added topic: not user facing topic category ciflow/trunk Trigger trunk jobs on your pull request labels Aug 28, 2023
Copy link
Contributor

@jbschlosser jbschlosser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks for the fast fix!

@mikaylagawarecki
Copy link
Contributor Author

@pytorchbot merge

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

mikaylagawarecki added a commit that referenced this pull request Aug 28, 2023
ghstack-source-id: 613c4f3608b1a375013fc9da64545c1084025650
Pull Request resolved: #108060
atalman pushed a commit that referenced this pull request Aug 30, 2023
ghstack-source-id: 613c4f3608b1a375013fc9da64545c1084025650
Pull Request resolved: #108060
@facebook-github-bot facebook-github-bot deleted the gh/mikaylagawarecki/149/head branch September 1, 2023 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ciflow/trunk Trigger trunk jobs on your pull request Merged topic: not user facing topic category
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants