[pytorch-vulkan] aten::.rand_like #108086

tina134 · 2023-08-28T19:17:32Z

Summary: Before implementing aten::.randn_like as requested (T152843033), I think it worth to extend aten::rand_like from existing aten::uniform, since they're so similar.

Test Plan:

[ttingchulin@6945.od /data/sandcastle/boxes/fbsource (rand_like)]$ LD_LIBRARY_PATH=third-party/swiftshader/lib/linux-x64/ buck run fbcode/mode/dev-nosan //xplat/caffe2:pt_vulkan_api_test_bin  -- --gtest_filter="*<test>*" eg.  -- --gtest_filter="*rand_like*"
[==========] Running 1 test from 1 test suite.
[----------] Global test environment set-up.
[----------] 1 test from VulkanAPITest
[ RUN      ] VulkanAPITest.rand_like
[       OK ] VulkanAPITest.rand_like (136 ms)
[----------] 1 test from VulkanAPITest (136 ms total)

[----------] Global test environment tear-down
[==========] 1 test from 1 test suite ran. (136 ms total)
[  PASSED  ] 1 test.

[ttingchulin@6945.od /data/sandcastle/boxes/fbsource (rand_like)]$ LD_LIBRARY_PATH=third-party/swiftshader/lib/linux-x64/ buck run fbcode/mode/dev-nosan //xplat/caffe2:pt_vulkan_api_test_bin  -- --gtest_filter="*<test>*" eg.  -- --gtest_filter="*uniform*"
Building: finished in 0.1 sec (100%) 329/329 jobs, 0/329 updated
  Total time: 0.1 sec
BUILD SUCCEEDED
Running main() from xplat/third-party/gmock/googletest-1.12.1/googletest/src/gtest_main.cc
Note: Google Test filter = *uniform*
[==========] Running 1 test from 1 test suite.
[----------] Global test environment set-up.
[----------] 1 test from VulkanAPITest
[ RUN      ] VulkanAPITest.uniform
[       OK ] VulkanAPITest.uniform (131 ms)
[----------] 1 test from VulkanAPITest (131 ms total)

[----------] Global test environment tear-down
[==========] 1 test from 1 test suite ran. (131 ms total)
[  PASSED  ] 1 test.

[ttingchulin@6945.od /data/sandcastle/boxes/fbsource (rand_like)]$ LD_LIBRARY_PATH=third-party/swiftshader/lib/linux-x64/ buck run fbcode/mode/dev-nosan //xplat/caffe2:pt_vulkan_api_test_bin
ALL PASS

Differential Revision: D48710273

pytorch-bot · 2023-08-28T19:17:35Z

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/108086

📄 Preview Python docs built from this PR
📄 Preview C++ docs built from this PR
❓ Need help or want to give feedback on the CI? Visit the bot commands wiki or our office hours

Note: Links to docs will display an error until the docs builds have been completed.

❗ 1 Merge Blocking SEVs

There is 1 active merge blocking SEVs. Please view them below:

(merge blocking) GH API issues are preventing multiple ci jobs to start.

If you must merge, use @pytorchbot merge -f.

❌ 1 New Failure

As of commit 524d037 with merge base 64ad16a ():

NEW FAILURE - The following job has failed:

linux-focal-cuda11.8-py3.9-gcc9 / test (multigpu, 1, 1, linux.g5.12xlarge.nvidia.gpu) (gh)

This comment was automatically generated by Dr. CI and updates every 15 minutes.

linux-foundation-easycla · 2023-08-28T19:17:36Z

The committers listed above are authorized under a signed CLA.

✅ login: tina134 (524d037)

facebook-github-bot · 2023-08-28T19:18:02Z

This pull request was exported from Phabricator. Differential Revision: D48710273

facebook-github-bot · 2023-08-28T19:38:32Z

This pull request was exported from Phabricator. Differential Revision: D48710273

Summary: Pull Request resolved: pytorch#108086 Before implementing `aten::.randn_like` as requested (T152843033), I think it worth to extend `aten::rand_like` from existing `aten::uniform`, since they're so similar. Test Plan: ``` [ttingchulin@6945.od /data/sandcastle/boxes/fbsource (rand_like)]$ LD_LIBRARY_PATH=third-party/swiftshader/lib/linux-x64/ buck run fbcode/mode/dev-nosan //xplat/caffe2:pt_vulkan_api_test_bin -- --gtest_filter="*<test>*" eg. -- --gtest_filter="*rand_like*" [==========] Running 1 test from 1 test suite. [----------] Global test environment set-up. [----------] 1 test from VulkanAPITest [ RUN ] VulkanAPITest.rand_like [ OK ] VulkanAPITest.rand_like (136 ms) [----------] 1 test from VulkanAPITest (136 ms total) [----------] Global test environment tear-down [==========] 1 test from 1 test suite ran. (136 ms total) [ PASSED ] 1 test. [ttingchulin@6945.od /data/sandcastle/boxes/fbsource (rand_like)]$ LD_LIBRARY_PATH=third-party/swiftshader/lib/linux-x64/ buck run fbcode/mode/dev-nosan //xplat/caffe2:pt_vulkan_api_test_bin -- --gtest_filter="*<test>*" eg. -- --gtest_filter="*uniform*" Building: finished in 0.1 sec (100%) 329/329 jobs, 0/329 updated Total time: 0.1 sec BUILD SUCCEEDED Running main() from xplat/third-party/gmock/googletest-1.12.1/googletest/src/gtest_main.cc Note: Google Test filter = *uniform* [==========] Running 1 test from 1 test suite. [----------] Global test environment set-up. [----------] 1 test from VulkanAPITest [ RUN ] VulkanAPITest.uniform [ OK ] VulkanAPITest.uniform (131 ms) [----------] 1 test from VulkanAPITest (131 ms total) [----------] Global test environment tear-down [==========] 1 test from 1 test suite ran. (131 ms total) [ PASSED ] 1 test. [ttingchulin@6945.od /data/sandcastle/boxes/fbsource (rand_like)]$ LD_LIBRARY_PATH=third-party/swiftshader/lib/linux-x64/ buck run fbcode/mode/dev-nosan //xplat/caffe2:pt_vulkan_api_test_bin ALL PASS ``` Differential Revision: D48710273 fbshipit-source-id: ed59704e54b3ba09e5b2592a7d2c00f3208edd7a

facebook-github-bot · 2023-08-28T20:59:39Z

This pull request was exported from Phabricator. Differential Revision: D48710273

Summary: Pull Request resolved: pytorch#108086 Before implementing `aten::.randn_like` as requested (T152843033), I think it worth to extend `aten::rand_like` from existing `aten::uniform`, since they're so similar. Test Plan: ``` [ttingchulin@6945.od /data/sandcastle/boxes/fbsource (rand_like)]$ LD_LIBRARY_PATH=third-party/swiftshader/lib/linux-x64/ buck run fbcode/mode/dev-nosan //xplat/caffe2:pt_vulkan_api_test_bin -- --gtest_filter="*<test>*" eg. -- --gtest_filter="*rand_like*" [==========] Running 1 test from 1 test suite. [----------] Global test environment set-up. [----------] 1 test from VulkanAPITest [ RUN ] VulkanAPITest.rand_like [ OK ] VulkanAPITest.rand_like (136 ms) [----------] 1 test from VulkanAPITest (136 ms total) [----------] Global test environment tear-down [==========] 1 test from 1 test suite ran. (136 ms total) [ PASSED ] 1 test. [ttingchulin@6945.od /data/sandcastle/boxes/fbsource (rand_like)]$ LD_LIBRARY_PATH=third-party/swiftshader/lib/linux-x64/ buck run fbcode/mode/dev-nosan //xplat/caffe2:pt_vulkan_api_test_bin -- --gtest_filter="*<test>*" eg. -- --gtest_filter="*uniform*" Building: finished in 0.1 sec (100%) 329/329 jobs, 0/329 updated Total time: 0.1 sec BUILD SUCCEEDED Running main() from xplat/third-party/gmock/googletest-1.12.1/googletest/src/gtest_main.cc Note: Google Test filter = *uniform* [==========] Running 1 test from 1 test suite. [----------] Global test environment set-up. [----------] 1 test from VulkanAPITest [ RUN ] VulkanAPITest.uniform [ OK ] VulkanAPITest.uniform (131 ms) [----------] 1 test from VulkanAPITest (131 ms total) [----------] Global test environment tear-down [==========] 1 test from 1 test suite ran. (131 ms total) [ PASSED ] 1 test. [ttingchulin@6945.od /data/sandcastle/boxes/fbsource (rand_like)]$ LD_LIBRARY_PATH=third-party/swiftshader/lib/linux-x64/ buck run fbcode/mode/dev-nosan //xplat/caffe2:pt_vulkan_api_test_bin ALL PASS ``` Differential Revision: D48710273 fbshipit-source-id: 9f74b7b0ad9aee5753f0b2efba7a90520a1348a4

facebook-github-bot · 2023-08-31T20:13:10Z

This pull request was exported from Phabricator. Differential Revision: D48710273

Summary: Pull Request resolved: pytorch#108086 Before implementing `aten::.randn_like` as requested (T152843033), I think it worth to extend `aten::rand_like` from existing `aten::uniform`, since they're so similar. Test Plan: ``` [ttingchulin@6945.od /data/sandcastle/boxes/fbsource (rand_like)]$ LD_LIBRARY_PATH=third-party/swiftshader/lib/linux-x64/ buck run fbcode/mode/dev-nosan //xplat/caffe2:pt_vulkan_api_test_bin -- --gtest_filter="*<test>*" eg. -- --gtest_filter="*rand_like*" [==========] Running 1 test from 1 test suite. [----------] Global test environment set-up. [----------] 1 test from VulkanAPITest [ RUN ] VulkanAPITest.rand_like [ OK ] VulkanAPITest.rand_like (136 ms) [----------] 1 test from VulkanAPITest (136 ms total) [----------] Global test environment tear-down [==========] 1 test from 1 test suite ran. (136 ms total) [ PASSED ] 1 test. [ttingchulin@6945.od /data/sandcastle/boxes/fbsource (rand_like)]$ LD_LIBRARY_PATH=third-party/swiftshader/lib/linux-x64/ buck run fbcode/mode/dev-nosan //xplat/caffe2:pt_vulkan_api_test_bin -- --gtest_filter="*<test>*" eg. -- --gtest_filter="*uniform*" Building: finished in 0.1 sec (100%) 329/329 jobs, 0/329 updated Total time: 0.1 sec BUILD SUCCEEDED Running main() from xplat/third-party/gmock/googletest-1.12.1/googletest/src/gtest_main.cc Note: Google Test filter = *uniform* [==========] Running 1 test from 1 test suite. [----------] Global test environment set-up. [----------] 1 test from VulkanAPITest [ RUN ] VulkanAPITest.uniform [ OK ] VulkanAPITest.uniform (131 ms) [----------] 1 test from VulkanAPITest (131 ms total) [----------] Global test environment tear-down [==========] 1 test from 1 test suite ran. (131 ms total) [ PASSED ] 1 test. [ttingchulin@6945.od /data/sandcastle/boxes/fbsource (rand_like)]$ LD_LIBRARY_PATH=third-party/swiftshader/lib/linux-x64/ buck run fbcode/mode/dev-nosan //xplat/caffe2:pt_vulkan_api_test_bin ALL PASS ``` Differential Revision: D48710273 fbshipit-source-id: 385e2d4c54cca8149f0b5fbf126b705b96cca032

facebook-github-bot · 2023-08-31T23:07:57Z

This pull request was exported from Phabricator. Differential Revision: D48710273

Summary: Pull Request resolved: pytorch#108086 Before implementing `aten::.randn_like` as requested (T152843033), I think it worth to extend `aten::rand_like` from existing `aten::uniform`, since they're so similar. Test Plan: ``` [ttingchulin@6945.od /data/sandcastle/boxes/fbsource (rand_like)]$ LD_LIBRARY_PATH=third-party/swiftshader/lib/linux-x64/ buck run fbcode/mode/dev-nosan //xplat/caffe2:pt_vulkan_api_test_bin -- --gtest_filter="*<test>*" eg. -- --gtest_filter="*rand_like*" [==========] Running 1 test from 1 test suite. [----------] Global test environment set-up. [----------] 1 test from VulkanAPITest [ RUN ] VulkanAPITest.rand_like [ OK ] VulkanAPITest.rand_like (136 ms) [----------] 1 test from VulkanAPITest (136 ms total) [----------] Global test environment tear-down [==========] 1 test from 1 test suite ran. (136 ms total) [ PASSED ] 1 test. [ttingchulin@6945.od /data/sandcastle/boxes/fbsource (rand_like)]$ LD_LIBRARY_PATH=third-party/swiftshader/lib/linux-x64/ buck run fbcode/mode/dev-nosan //xplat/caffe2:pt_vulkan_api_test_bin -- --gtest_filter="*<test>*" eg. -- --gtest_filter="*uniform*" Building: finished in 0.1 sec (100%) 329/329 jobs, 0/329 updated Total time: 0.1 sec BUILD SUCCEEDED Running main() from xplat/third-party/gmock/googletest-1.12.1/googletest/src/gtest_main.cc Note: Google Test filter = *uniform* [==========] Running 1 test from 1 test suite. [----------] Global test environment set-up. [----------] 1 test from VulkanAPITest [ RUN ] VulkanAPITest.uniform [ OK ] VulkanAPITest.uniform (131 ms) [----------] 1 test from VulkanAPITest (131 ms total) [----------] Global test environment tear-down [==========] 1 test from 1 test suite ran. (131 ms total) [ PASSED ] 1 test. [ttingchulin@6945.od /data/sandcastle/boxes/fbsource (rand_like)]$ LD_LIBRARY_PATH=third-party/swiftshader/lib/linux-x64/ buck run fbcode/mode/dev-nosan //xplat/caffe2:pt_vulkan_api_test_bin ALL PASS ``` Differential Revision: D48710273 fbshipit-source-id: 727362de12416d3935a9fdf958616472bee134b8

Summary: Before implementing `aten::.randn_like` as requested (T152843033), I think it worth to extend `aten::rand_like` from existing `aten::uniform`, since they're so similar. Test Plan: ``` [ttingchulin@6945.od /data/sandcastle/boxes/fbsource (rand_like)]$ LD_LIBRARY_PATH=third-party/swiftshader/lib/linux-x64/ buck run fbcode/mode/dev-nosan //xplat/caffe2:pt_vulkan_api_test_bin -- --gtest_filter="*<test>*" eg. -- --gtest_filter="*rand_like*" [==========] Running 1 test from 1 test suite. [----------] Global test environment set-up. [----------] 1 test from VulkanAPITest [ RUN ] VulkanAPITest.rand_like [ OK ] VulkanAPITest.rand_like (136 ms) [----------] 1 test from VulkanAPITest (136 ms total) [----------] Global test environment tear-down [==========] 1 test from 1 test suite ran. (136 ms total) [ PASSED ] 1 test. [ttingchulin@6945.od /data/sandcastle/boxes/fbsource (rand_like)]$ LD_LIBRARY_PATH=third-party/swiftshader/lib/linux-x64/ buck run fbcode/mode/dev-nosan //xplat/caffe2:pt_vulkan_api_test_bin -- --gtest_filter="*<test>*" eg. -- --gtest_filter="*uniform*" Building: finished in 0.1 sec (100%) 329/329 jobs, 0/329 updated Total time: 0.1 sec BUILD SUCCEEDED Running main() from xplat/third-party/gmock/googletest-1.12.1/googletest/src/gtest_main.cc Note: Google Test filter = *uniform* [==========] Running 1 test from 1 test suite. [----------] Global test environment set-up. [----------] 1 test from VulkanAPITest [ RUN ] VulkanAPITest.uniform [ OK ] VulkanAPITest.uniform (131 ms) [----------] 1 test from VulkanAPITest (131 ms total) [----------] Global test environment tear-down [==========] 1 test from 1 test suite ran. (131 ms total) [ PASSED ] 1 test. [ttingchulin@6945.od /data/sandcastle/boxes/fbsource (rand_like)]$ LD_LIBRARY_PATH=third-party/swiftshader/lib/linux-x64/ buck run fbcode/mode/dev-nosan //xplat/caffe2:pt_vulkan_api_test_bin ALL PASS ``` Reviewed By: yipjustin Differential Revision: D48710273

facebook-github-bot · 2023-09-05T21:38:22Z

This pull request was exported from Phabricator. Differential Revision: D48710273

facebook-github-bot · 2023-09-05T21:38:41Z

This pull request was exported from Phabricator. Differential Revision: D48710273

facebook-github-bot · 2023-09-06T01:23:28Z

@pytorchbot merge

(Initiating merge automatically since Phabricator Diff has merged)

pytorchmergebot · 2023-09-06T01:24:58Z

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging

Check the merge workflow status
here

pytorch-bot bot added ciflow/periodic Trigger jobs ran periodically on master (periodic.yml) on the PR module: vulkan release notes: vulkan release notes category labels Aug 28, 2023

facebook-github-bot added the fb-exported label Aug 28, 2023

tina134 force-pushed the export-D48710273 branch from 4d8e3bc to a45a790 Compare August 28, 2023 19:38

tina134 force-pushed the export-D48710273 branch from a45a790 to 06f56f6 Compare August 28, 2023 20:59

tina134 force-pushed the export-D48710273 branch from 06f56f6 to 62ae53a Compare August 31, 2023 20:13

tina134 force-pushed the export-D48710273 branch from 62ae53a to 2f3e97b Compare August 31, 2023 23:08

tina134 requested a review from yipjustin September 5, 2023 17:51

yipjustin approved these changes Sep 5, 2023

View reviewed changes

tina134 force-pushed the export-D48710273 branch from 2f3e97b to 524d037 Compare September 5, 2023 21:38

pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Sep 6, 2023

pytorchmergebot added the merging label Sep 6, 2023

pytorchmergebot added the Merged label Sep 6, 2023

pytorchmergebot removed the merging label Sep 6, 2023

pytorchmergebot closed this in d494b92 Sep 6, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[pytorch-vulkan] aten::.rand_like #108086

[pytorch-vulkan] aten::.rand_like #108086

tina134 commented Aug 28, 2023

pytorch-bot bot commented Aug 28, 2023 •

edited

linux-foundation-easycla bot commented Aug 28, 2023 •

edited

facebook-github-bot commented Aug 28, 2023

facebook-github-bot commented Aug 28, 2023

facebook-github-bot commented Aug 28, 2023

facebook-github-bot commented Aug 31, 2023

facebook-github-bot commented Aug 31, 2023

facebook-github-bot commented Sep 5, 2023

facebook-github-bot commented Sep 5, 2023

facebook-github-bot commented Sep 6, 2023

pytorchmergebot commented Sep 6, 2023

[pytorch-vulkan] aten::.rand_like #108086

[pytorch-vulkan] aten::.rand_like #108086

Conversation

tina134 commented Aug 28, 2023

pytorch-bot bot commented Aug 28, 2023 • edited

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/108086

❗ 1 Merge Blocking SEVs

❌ 1 New Failure

linux-foundation-easycla bot commented Aug 28, 2023 • edited

facebook-github-bot commented Aug 28, 2023

facebook-github-bot commented Aug 28, 2023

facebook-github-bot commented Aug 28, 2023

facebook-github-bot commented Aug 31, 2023

facebook-github-bot commented Aug 31, 2023

facebook-github-bot commented Sep 5, 2023

facebook-github-bot commented Sep 5, 2023

facebook-github-bot commented Sep 6, 2023

pytorchmergebot commented Sep 6, 2023

Merge started

pytorch-bot bot commented Aug 28, 2023 •

edited

linux-foundation-easycla bot commented Aug 28, 2023 •

edited